malloc in libssl/src/apps

Hello, I've gone through lib/libssl/src/apps with the goal of making {m,c,re}alloc uses more idiomatic, adding error checking in some places where missing, and some minor style unification. Feedback appreciated, better patches to come after the semester ends. Index: apps.c =

Re: [PATCH] 1 of 2 s3_lib.c KNF retry

On 3 May 2014 20:29, Philip Guenther wrote: > On Sat, May 3, 2014 at 12:40 PM, Chris Hettrick > wrote: >> >> I was too ambitious with the previous diffs. Here they are again. >> First diff is whitespace only that can be checked with tr and md5. >> Second diff is for non-whitespace KNF cleanup. >>

Re: [PATCH] 1 of 2 s3_lib.c KNF retry

On Sat, May 3, 2014 at 12:40 PM, Chris Hettrick wrote: > > I was too ambitious with the previous diffs. Here they are again. > First diff is whitespace only that can be checked with tr and md5. > Second diff is for non-whitespace KNF cleanup. > Uh, thanks, but bulk KNF diffs are really best done b

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

>> "Everybody does it" is an argumentum ad populum. It's not right >> because all systems do this. All systems do this because some RFC >> told them to and apparently nobody considered the downsides (or they >> dismissed them). >> >> I'm arguing it should be different since it is unexpected behav

[PATCH] 2 of 2 s3_lib.c KNF retry

Hi tech@ This is the second diff for s3_lib.c Apply it after my previous diff. This diff cleans up non-whitespace KNF such as missing parens around returns and redundant if-elses. --- s3_lib.c.oldSat May 3 12:27:25 2014 +++ s3_lib.cSat May 3 12:24:37 2014 @@ -1357,7 +1357,7 @@ OPEN

[PATCH] 1 of 2 s3_lib.c KNF retry

Hi tech@ I was too ambitious with the previous diffs. Here they are again. First diff is whitespace only that can be checked with tr and md5. Second diff is for non-whitespace KNF cleanup. Index: s3_lib.c === RCS file: /cvs/src/lib/l

Re: libc: #define to remove support for %n from printf(3)?

On Sat, May 03, 2014 at 01:00:28PM +0200, Henning Brauer wrote: > * Marc Espie [2014-05-03 11:50]: > > On Sat, May 03, 2014 at 11:28:16AM +0200, Reyk Floeter wrote: > > > On Fri, May 02, 2014 at 06:50:04PM -0600, Bob Beck wrote: > > > > What's their hangup with %n? We normally don't like pollutin

Re: libc: #define to remove support for %n from printf(3)?

On Fri, May 02, 2014 at 15:17, enh wrote: > ideally i'd like to have no differences between Android and OpenBSD in > the shared source files, because i've seen what a mess things were > when we diverged (and how many bugs went unfixed in Android despite > having been fixed for years upstream). so r

zless is less

Hello all. Just run into the following issue with zmore/zless: if you have PAGER envvar set, it's no matter whatever you'll call, zmore or zless - it'll always run $PAGER. The problem is that I have PAGER=/usr/bin/more but sometimes I want to use less. If I run "less foo", I get what I requested;

Re: libc: #define to remove support for %n from printf(3)?

* Marc Espie [2014-05-03 11:50]: > On Sat, May 03, 2014 at 11:28:16AM +0200, Reyk Floeter wrote: > > On Fri, May 02, 2014 at 06:50:04PM -0600, Bob Beck wrote: > > > What's their hangup with %n? We normally don't like polluting the world > > > with #ifdef OPENSSL_NO_PERCENT_N... We normally nuke

Re: libc: #define to remove support for %n from printf(3)?

On Sat, May 03, 2014 at 11:28:16AM +0200, Reyk Floeter wrote: > On Fri, May 02, 2014 at 06:50:04PM -0600, Bob Beck wrote: > > What's their hangup with %n? We normally don't like polluting the world > > with #ifdef OPENSSL_NO_PERCENT_N... We normally nuke stuff like that > > Well, it is an evil t

[PATCH] 1 of 2 s3_lib.c KNF cleanup

Hi tech@ Some KNF whitespace cleanup in s3_lib.c that can be checked with tr and md5. Another diff will follow for the non-whitespace KNF cleanup. Index: src/ssl/s3_lib.c === RCS file: /cvs/src/lib/libssl/src/ssl/s3_lib.c,v retrievin

[PATCH] 2 of 2 s3_lib.c KNF cleanup

Hi tech@ Apply this diff after my previous diff. This diff cleans up the non-whitespace KNF in s3_lib.c --- s3_lib.cThu May 1 21:32:06 2014 +++ /usr/src/lib/libssl/src/ssl/s3_lib.cFri May 2 22:10:24 2014 @@ -1357,7 +1357,7 @@ OPENSSL_GLOBAL SSL_CIPHER ssl3_ciphers[] = {

Re: FETCH_PACKAGES=Yes doesn't work

On Fri, May 02, 2014 at 12:08:47PM +0200, Marc Espie wrote: > On Thu, May 01, 2014 at 07:04:24PM +0200, Stefan Sperling wrote: > > I noticed that ports are always built even with FETCH_PACKAGES=Yes > > and matching binary packages on the mirror. > > > > Starting from 'make depends' I traced the pr

Re: libc: #define to remove support for %n from printf(3)?

On Fri, May 02, 2014 at 06:50:04PM -0600, Bob Beck wrote: > What's their hangup with %n? We normally don't like polluting the world > with #ifdef OPENSSL_NO_PERCENT_N... We normally nuke stuff like that Well, it is an evil thing that is rarely used and well-known for some format string vulnerabi

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

On Sat, May 03, 2014 at 10:03:30AM +0200, Paul de Weerd wrote: > On Fri, May 02, 2014 at 11:20:38PM +0200, Jérémie Courrèges-Anglas wrote: > | > I'm not referring to SLAAC. I'm referring to addresses that are > | > configured on interfaces without the user even requesting them. > | > link-local ad

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

On Fri, May 02, 2014 at 11:29:11PM +0200, Henning Brauer wrote: | > > Anyway, I believe at least -inet6 is a better default than the current | > > situation. | > -inet6 as the default seems more OpenBSD'ish to me. Everything off | > that can be off, but not more. | | there is way more to it than "

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

On Fri, May 02, 2014 at 11:20:38PM +0200, Jérémie Courrèges-Anglas wrote: | > I'm not referring to SLAAC. I'm referring to addresses that are | > configured on interfaces without the user even requesting them. | > link-local addresses, specifically. | | I was actually answering your question abou