Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: > > What about using a more generic name which is not bound to 80211 since the > > field is a generic pointer. This may allow us to use something similar in > > other drivers like mpe(4), gif(4), gre(4). > > That is basically the only

Re: skip pflog interfaces in pcap_lookupdev()

2014-03-17 Thread Lawrence Teo
On Thu, Aug 08, 2013 at 12:12:39AM -0500, joshua stein wrote: > Running tcpdump with no -i arg finds a good interface to listen on > by default on many machines, but on my laptop it finds pflog0 before > urtwn0. Can we skip pflog interfaces like loopbacks? I got reminded of this diff while workin

Re: remove `my $_` from usr.bin/libtool

2014-03-17 Thread Andrew Fresh
On Sun, Mar 16, 2014 at 06:45:31PM -0700, Andrew Fresh wrote: > Lexical $_ (my $_) has been made experimental in perl 5.18 which causes > warnings where used. This makes usr.bin/libtool stop using them. > > http://perldoc.perl.org/perldiag.html#Use-of-my-$_-is-experimental > > Also standardizes

upd(4) needs testing

2014-03-17 Thread Andre de Oliveira
upd(4) has been integrated to the tree a few hours ago. it is disabled for now, so if you follow current and can test it, please use this patch (mostly the same mpi@'s patch from yesterday, plus the removal of the supported product/device-ids from usb_quirks.c). if you have an ups with you which

thinkpad adaptive keyboard patch

2014-03-17 Thread rivo nurges
Hi! New 2nd generation Lenovo X1 Carbon has touchable lcd strip instead of the F1-12 keys and the multimedia keys. It has 5 modes with tons of useless buttons triggering acpi hotkey events and 6th inactive mode. This patch adds support for switching between the Home and the Function modes. The Fu

Re: lock(1) timeout message deduplication

2014-03-17 Thread Jean-Philippe Ouellet
Thank you very much for the feedback. On 3/14/14 9:38 AM, Ingo Schwarze wrote: > According to the sigaction(3) manual, "volatile sig_atomic_t" would > be better. If i understand correctly, overzealous compilers might > otherwise optimize checks away. Dammit, of course. I should have caught that.

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Theo de Raadt
> What about using a more generic name which is not bound to 80211 since the > field is a generic pointer. This may allow us to use something similar in > other drivers like mpe(4), gif(4), gre(4). That is basically the only thought I had. I mean you could also start passing it as a mbuf tag, but

fixup arp(8) rdomain hang

2014-03-17 Thread Mike Belopuhov
Hi, It's been known for ages that "arp -V 1 -d 10.0.0.1" would hang forever. Apparently the cause is simple: we pass the target rdomain in the rtm, but the AF_ROUTE socket that we create is always in rdomain 0 (c.f. getsocket in the arp source code). The hang happens in the read syscall at the bo

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:14:24AM +0100, Martin Pieuchot wrote: > On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: > > Diff below adds a new pointer to "struct pkthdr" to explicitly pass > > some wireless nodes to the pointer without abusing the interface > > pointer that I'd like to kill. > > > >

[PATCH] Allow bioctl(8) to recognise DUIDs (and such) for many operations

2014-03-17 Thread bytevolcano
This patch allows bioctl(8) to perform operations on volumes using either the fully-qualified device path (eg. "/dev/sd0a") or a valid DUID pointing to the RAID volume or device. Basically, anything that opendev(3) can open. Index: sbin/bioctl/bioctl.c ==

Re: if_detach() addresses cleanup

2014-03-17 Thread Martin Pieuchot
On 06/03/14(Thu) 09:35, Martin Pieuchot wrote: > On 22/01/14(Wed) 11:46, Martin Pieuchot wrote: > > Network addresses added to the interface local list thought ifa_add() > > are the link-local address and the IPv4/6 ones. > > > > Since if_detach() now calls in_ifdetach(), there should be no addres

Re: Split IPv4 automagic route to prefix/host creation

2014-03-17 Thread Martin Pieuchot
On 10/03/14(Mon) 15:28, Martin Pieuchot wrote: > Diff below splits in_addprefix() into two functions, one for adding a > route to host (for point-to-point interfaces) and one for adding a > route prefix. > > This simplifies a lot the RTF_* flags logic and will make it easier > to create routes to

arp resolution completion notifications

2014-03-17 Thread Mike Belopuhov
Hi, I would like to send results of ARP resolution back to the userland in order to be able to catch them via the AF_ROUTE socket. I'm cooking some SNMPd changes (ipNetToMediaPhysAddress support primarily) based on this. I have inspected bgpd's and ospfd's kroute.c files and believe they should s

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Martin Pieuchot
On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: > Diff below adds a new pointer to "struct pkthdr" to explicitly pass > some wireless nodes to the pointer without abusing the interface > pointer that I'd like to kill. > > I kept and updated the comments saying that this way of passing the > corresp