Re: md5/sha256 -c option

2014-01-09 Thread Jason McIntyre
On Fri, Jan 10, 2014 at 12:54:20AM -0700, Theo de Raadt wrote: > > On Fri, Jan 10, 2014 at 12:13:45AM -0500, Ted Unangst wrote: > > > The synopsis for -c is dreadfully confusing. it's a mode, not an > > > option. as such, all the other stuff isn't available. > > > > > > > i see it's already done,

Re: md5/sha256 -c option

2014-01-09 Thread Theo de Raadt
> On Fri, Jan 10, 2014 at 12:13:45AM -0500, Ted Unangst wrote: > > The synopsis for -c is dreadfully confusing. it's a mode, not an > > option. as such, all the other stuff isn't available. > > > > i see it's already done, so i'm late to the party. but i'll add my > thoughts anyway. > > i dislik

Re: md5/sha256 -c option

2014-01-09 Thread Jason McIntyre
On Fri, Jan 10, 2014 at 12:13:45AM -0500, Ted Unangst wrote: > The synopsis for -c is dreadfully confusing. it's a mode, not an > option. as such, all the other stuff isn't available. > i see it's already done, so i'm late to the party. but i'll add my thoughts anyway. i dislike this. i dislike

Re: remove kcopy

2014-01-09 Thread Theo de Raadt
> > The only caller of kcopy is uiomove. There is no way a function like > > this can ever work. If you need to rely on your copy function to save > > you from pointers outside the address space, it means you don't know > > what garbage you're passing it. Meaning you may well be passing it > > poin

md5/sha256 -c option

2014-01-09 Thread Ted Unangst
The synopsis for -c is dreadfully confusing. it's a mode, not an option. as such, all the other stuff isn't available. Index: md5.1 === RCS file: /cvs/src/bin/md5/md5.1,v retrieving revision 1.36 diff -u -p -r1.36 md5.1 --- md5.1

Re: remove kcopy

2014-01-09 Thread Miod Vallat
> The only caller of kcopy is uiomove. There is no way a function like > this can ever work. If you need to rely on your copy function to save > you from pointers outside the address space, it means you don't know > what garbage you're passing it. Meaning you may well be passing it > pointers insid

Re: remove kcopy

2014-01-09 Thread Ted Unangst
On Fri, Jan 10, 2014 at 05:14, Miod Vallat wrote: >> The only caller of kcopy is uiomove. There is no way a function like >> this can ever work. If you need to rely on your copy function to save >> you from pointers outside the address space, it means you don't know >> what garbage you're passing i

tcpdrop(8): check strdup() return values

2014-01-09 Thread Lawrence Teo
This checks the return values of strdup() calls in tcpdrop(8). OK? Index: tcpdrop.c === RCS file: /cvs/src/usr.sbin/tcpdrop/tcpdrop.c,v retrieving revision 1.12 diff -u -p -r1.12 tcpdrop.c --- tcpdrop.c 24 Oct 2013 02:55:50 -

remove kcopy

2014-01-09 Thread Ted Unangst
The only caller of kcopy is uiomove. There is no way a function like this can ever work. If you need to rely on your copy function to save you from pointers outside the address space, it means you don't know what garbage you're passing it. Meaning you may well be passing it pointers inside the addr

rc default PF ruleset too restrictive for DHCPv6

2014-01-09 Thread Brad Smith
The default PF ruleset as setup by rc is too restrictive. Have the default ruleset allow for DHCPv6. Index: rc === RCS file: /home/cvs/src/etc/rc,v retrieving revision 1.419 diff -u -p -u -p -r1.419 rc --- rc 3 Jan 2014 23:24:19 -00

Re: awk(1) update

2014-01-09 Thread Jérémie Courrèges-Anglas
Miod Vallat writes: >> So here's the same diff without the "negative 0.0" change. >> Update which: >> - marks some functions as __dead (instead of upstream >> __attribute__((__noreturn__))) >> - fixes split(a[1], a). >> >> ok? > > FIXES still lists the setfval change, which you did not include

Patch to uftdi(4): update list of supported chips

2014-01-09 Thread Chris Hettrick
Hi tech@ Here is an update to uftdi(4) that lists all the currently supported FTDI chips. Index: uftdi.4 === RCS file: /cvs/src/share/man/man4/uftdi.4,v retrieving revision 1.28 diff -u -p -r1.28 uftdi.4 --- uftdi.4 11 Sep 2012 1