em(4): Don't count RX overruns and missed packets as input errros

2013-12-30 Thread Brad Smith
Don't count RX overruns and missed packets as inputs errors. They're expected to increment when using MCLGETI. OK? Index: if_em.c === RCS file: /cvs/src/sys/dev/pci/if_em.c,v retrieving revision 1.275 diff -u -p -u -p -r1.275 if_em.

re(4): tedu some unused code

2013-12-30 Thread Brad Smith
tedu some unused code. it has never been enabled and will not be; to deal with a hardware defect for rare boards. unmaintained, untested, etc. want to get rid of it. Comments? OK? Index: re.c === RCS file: /home/cvs/src/sys/dev/ic/r

Re: call for testing: MSI for msk(4)

2013-12-30 Thread Brad Smith
On 16/05/13 5:55 PM, Jérémie Courrèges-Anglas wrote: Hi, I've been using msk(4) with MSI on my laptop since a few days, with no apparent problem. mskc0 at pci2 dev 0 function 0 "Marvell Yukon 88E8040" rev 0x13, Yukon-2 FE+ rev. A0 (0x0): msi msk0 at mskc0 port A: address 00:24:54:xx:xx:xx eeph

Re: base64 b64_pton fix

2013-12-30 Thread Ted Unangst
On Thu, Dec 26, 2013 at 05:17, Todd C. Miller wrote: > This is nit picking but it bugs me to see the conditional repeated > like that. Perhaps instead of: > > if (nextbyte && tarindex + 1 >= targsize) > return (-1); > if (tarindex + 1 < targsize) > target[tarindex+1] = nextbyte; > > Something mo

Re: TOD clock for octeons

2013-12-30 Thread Paul Irofti
On Mon, Dec 30, 2013 at 06:49:38PM +0200, Paul Irofti wrote: > On Mon, Dec 30, 2013 at 02:47:58PM +0200, Paul Irofti wrote: > > The following enables the DS1337 RTC clock found on octeon boards. > > > > I've tested it on my DSR-500 and would love to hear about tests on other > > machines. > > > >

Re: column memory leak fix

2013-12-30 Thread Theo de Raadt
> I'm mostly interested in finding the small security issues and fixing > them, rather than fixing style issues :-) As yet, none of these have anything to do with security. Many of the rest are about to get cleaned up by exit, so they are not really fixes of value either. So they come down to st

Re: column memory leak fix

2013-12-30 Thread Ted Unangst
On Mon, Dec 30, 2013 at 22:50, Loganaden Velvindron wrote: > Hi Patrick, the base source code is pretty huge, and I'm sure that there are > memory/fd leak issues lurking around that need to be fixed. I'd much rather > spend time finding and fixing them :-) > > After I got feedback on my diffs, I

Add Intel Centrino Wireless-N 2230 support in iwn(4)

2013-12-30 Thread Fabian Raetz
Hi tech@, the diff below adds support for the Intel Centrino Wireless-N 2230 card found in my Lenovo E330 to iwn(4). iwn0 at pci2 dev 0 function 0 "Intel Centrino Wireless-N 2230" rev 0xc4: msi, MIMO 2T2R, BGN, address 60:6c:66:3b:ea:39 This is the 0x0888 version. I've got most changes from

Re: column memory leak fix

2013-12-30 Thread Ted Unangst
On Mon, Dec 30, 2013 at 10:32, patrick keshishian wrote: > Maybe so, but ever since I've known of OpenBSD, it has always > "preached" good coding practices and exemplified through its > base source code. So why are you discouraging such fixes? You My concern is that these patches are being taken f

Re: user(8) free() before returning in groupmod()

2013-12-30 Thread Ted Unangst
On Mon, Dec 30, 2013 at 08:23, Loganaden Velvindron wrote: > Index: src/usr.sbin/user/user.c > === > RCS file: /cvs/src/usr.sbin/user/user.c,v > retrieving revision 1.98 > diff -u -p -r1.98 user.c > --- src/usr.sbin/user/user.c 23 Nov

Re: column memory leak fix

2013-12-30 Thread Loganaden Velvindron
On Mon, Dec 30, 2013 at 10:32 PM, patrick keshishian wrote: > On Mon, Dec 30, 2013 at 04:58:50PM +0100, Mike Belopuhov wrote: >> On 30 December 2013 16:35, Loganaden Velvindron wrote: >> > On Mon, Dec 30, 2013 at 08:42:00AM -0500, Ted Unangst wrote: >> >> On Mon, Dec 30, 2013 at 13:53, Mike Belop

Re: column memory leak fix

2013-12-30 Thread Alexander Hall
Loganaden Velvindron wrote: >I'm mostly interested in finding the small security issues and fixing >them, rather than fixing style issues :-) Keeping good style helps avoiding bugs, though.

Re: column memory leak fix

2013-12-30 Thread patrick keshishian
On Mon, Dec 30, 2013 at 04:58:50PM +0100, Mike Belopuhov wrote: > On 30 December 2013 16:35, Loganaden Velvindron wrote: > > On Mon, Dec 30, 2013 at 08:42:00AM -0500, Ted Unangst wrote: > >> On Mon, Dec 30, 2013 at 13:53, Mike Belopuhov wrote: > >> > On Mon, Dec 30, 2013 at 03:59 -0800, Loganaden

Re: TOD clock for octeons

2013-12-30 Thread Paul Irofti
On Mon, Dec 30, 2013 at 02:47:58PM +0200, Paul Irofti wrote: > The following enables the DS1337 RTC clock found on octeon boards. > > I've tested it on my DSR-500 and would love to hear about tests on other > machines. > > Comments? Okays? New diff after a helpful tip from miod Index: conf/GEN

user(8) free() before returning in groupmod()

2013-12-30 Thread Loganaden Velvindron
>From NetBSD: Coverity annotation -- although memsave free()s its first argument, it will allocate memory and assign it to its first argument, so it is neutral Coverity CID 3228: memory leak -- failed to free() newname in groupmod() Index: src/usr.sbin/user/user.c ==

Re: column memory leak fix

2013-12-30 Thread Mike Belopuhov
On 30 December 2013 16:35, Loganaden Velvindron wrote: > On Mon, Dec 30, 2013 at 08:42:00AM -0500, Ted Unangst wrote: >> On Mon, Dec 30, 2013 at 13:53, Mike Belopuhov wrote: >> > On Mon, Dec 30, 2013 at 03:59 -0800, Loganaden Velvindron wrote: >> >> On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike B

Re: Typo in nfs_boot.c

2013-12-30 Thread matteo filippetto
2013/12/30 matteo filippetto : > 2013/9/12 Eivind Evensen : >> Hello. >> >> Trying to figure out what I've done wrong to have a diskless setup >> boot the kernel and then try to talk to a broadcast address rather than >> the nfsserver, I saw this typo. >> >> Eivind >> > > Hi, > > I think I have the

Re: column memory leak fix

2013-12-30 Thread Loganaden Velvindron
On Mon, Dec 30, 2013 at 08:42:00AM -0500, Ted Unangst wrote: > On Mon, Dec 30, 2013 at 13:53, Mike Belopuhov wrote: > > On Mon, Dec 30, 2013 at 03:59 -0800, Loganaden Velvindron wrote: > >> On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike Belopuhov wrote: > >> > On Sun, Dec 29, 2013 at 22:45 -0800, L

Re: Typo in nfs_boot.c

2013-12-30 Thread matteo filippetto
2013/9/12 Eivind Evensen : > Hello. > > Trying to figure out what I've done wrong to have a diskless setup > boot the kernel and then try to talk to a broadcast address rather than > the nfsserver, I saw this typo. > > Eivind > Hi, I think I have the same problem as, when booting a client, I get

Re: column memory leak fix

2013-12-30 Thread Ted Unangst
On Mon, Dec 30, 2013 at 13:53, Mike Belopuhov wrote: > On Mon, Dec 30, 2013 at 03:59 -0800, Loganaden Velvindron wrote: >> On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike Belopuhov wrote: >> > On Sun, Dec 29, 2013 at 22:45 -0800, Loganaden Velvindron wrote: >> > > Hi All, >> > > >> > > From NetBSD:

Re: column memory leak fix

2013-12-30 Thread Mike Belopuhov
On Mon, Dec 30, 2013 at 03:59 -0800, Loganaden Velvindron wrote: > On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike Belopuhov wrote: > > On Sun, Dec 29, 2013 at 22:45 -0800, Loganaden Velvindron wrote: > > > Hi All, > > > > > > From NetBSD: > > > > > > Plug memory leak. Coverity CID 1596 > > > > >

TOD clock for octeons

2013-12-30 Thread Paul Irofti
The following enables the DS1337 RTC clock found on octeon boards. I've tested it on my DSR-500 and would love to hear about tests on other machines. Comments? Okays? Index: conf/GENERIC === RCS file: /cvs/src/sys/arch/octeon/conf/

Re: column memory leak fix

2013-12-30 Thread Loganaden Velvindron
On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike Belopuhov wrote: > On Sun, Dec 29, 2013 at 22:45 -0800, Loganaden Velvindron wrote: > > Hi All, > > > > From NetBSD: > > > > Plug memory leak. Coverity CID 1596 > > > > memory leak? can you please elaborate where else this memory > is "leaking" if

Re: column memory leak fix

2013-12-30 Thread Mike Belopuhov
On Sun, Dec 29, 2013 at 22:45 -0800, Loganaden Velvindron wrote: > Hi All, > > From NetBSD: > > Plug memory leak. Coverity CID 1596 > memory leak? can you please elaborate where else this memory is "leaking" if not back to the system. > Index: src/usr.bin/column/column.c > ===

Re: cmp fd leak fix

2013-12-30 Thread Mike Belopuhov
On Sun, Dec 29, 2013 at 23:28 -0800, Loganaden Velvindron wrote: > Hi All, > > From NetBSD: > > Plug fd leak. Coverity CID 1624. > fd leak? they're "leaking" back to the system. the function is not recursive nor it's called in a loop. > Index: src/usr.bin/cmp/special.c >

irc.mindcry.org down

2013-12-30 Thread Loganaden Velvindron
Hi All, I can no longer find irc.mindcry.org on the internet. Is that permanent or temporary ? //logan c-x-c-c

fgen free alias in error path

2013-12-30 Thread Loganaden Velvindron
Hi All, >From NetBSD: Coverity CID 1748: Free alias on error. alias->name = strdup(token->text); if (alias->name == NULL) (void)err(1, "out of memory"); token = yylex(