cmp fd leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Plug fd leak. Coverity CID 1624. Index: src/usr.bin/cmp/special.c === RCS file: /cvs/src/usr.bin/cmp/special.c,v retrieving revision 1.7 diff -u -p -r1.7 special.c --- src/usr.bin/cmp/special.c 19 Jan 2011 13

column memory leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Plug memory leak. Coverity CID 1596 Index: src/usr.bin/column/column.c === RCS file: /cvs/src/usr.bin/column/column.c,v retrieving revision 1.16 diff -u -p -r1.16 column.c --- src/usr.bin/column/column.c 26 Nov

Re: OpenBSD base doesn't build on ARMv7

2013-12-29 Thread Juan Francisco Cantero Hurtado
On Wed, Dec 25, 2013 at 10:56:59PM -0500, Nick Holland wrote: > On 12/25/13 19:08, Juan Francisco Cantero Hurtado wrote: > > Hi, I've been seeing the same error for weeks: > > > > ===> gnu/usr.bin/cc/libgcc > > Using undefined dynamic variable $* (line 0 of (null)) > > Using undefined dynamic vari

Re: ldconfig fd leak fix

2013-12-29 Thread patrick keshishian
On Sun, Dec 29, 2013 at 11:49:29AM -0800, Loganaden Velvindron wrote: > On Sun, Dec 29, 2013 at 09:51:28AM -0800, patrick keshishian wrote: > > Hi, > > > > Accidentally deleted this message from my inbox. This is > > a "reconstruction" from mailing list archive. > > > > Suggestion/comment below.

Re: user(8) fd fix

2013-12-29 Thread Loganaden Velvindron
On Sun, Dec 29, 2013 at 03:19:08PM -0500, Ted Unangst wrote: > On Sun, Dec 29, 2013 at 11:59, Loganaden Velvindron wrote: > > Hi All, > > > > From NetBSD: > > Close masterfd after reading from it. Found by cppcheck. > > This is wrong. > > Proper code using fdopen() with error checking shoul

Re: user(8) fd fix

2013-12-29 Thread Ted Unangst
On Sun, Dec 29, 2013 at 11:59, Loganaden Velvindron wrote: > Hi All, > > From NetBSD: > Close masterfd after reading from it. Found by cppcheck. This is wrong. Proper code using fdopen() with error checking should close(2) fildes in case of failure, and fclose(3) the resulting FILE * i

pwd_mkdb fd leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: fd leak fix, found by cppcheck. Index: src/usr.sbin/pwd_mkdb/pwd_mkdb.c === RCS file: /cvs/src/usr.sbin/pwd_mkdb/pwd_mkdb.c,v retrieving revision 1.43 diff -u -p -r1.43 pwd_mkdb.c --- src/usr.sbin/pwd_mkdb/pwd_m

user(8) fd fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Close masterfd after reading from it. Found by cppcheck. Index: src/usr.sbin/user/user.c === RCS file: /cvs/src/usr.sbin/user/user.c,v retrieving revision 1.98 diff -u -p -r1.98 user.c --- src/usr.sbin/user/use

Re: ldconfig fd leak fix

2013-12-29 Thread Loganaden Velvindron
On Sun, Dec 29, 2013 at 09:51:28AM -0800, patrick keshishian wrote: > Hi, > > Accidentally deleted this message from my inbox. This is > a "reconstruction" from mailing list archive. > > Suggestion/comment below. > > Earlier today: > > Hi All, > > > > From NetBSD: > > Fix file descriptor leak.

Re: ldconfig fd leak fix

2013-12-29 Thread patrick keshishian
Hi, Accidentally deleted this message from my inbox. This is a "reconstruction" from mailing list archive. Suggestion/comment below. Earlier today: > Hi All, > > From NetBSD: > Fix file descriptor leak. Found by cppcheck. > > Index: src/libexec/ld.so/ldconfig/ldconfig.c >

Re: lpr fd leak fix

2013-12-29 Thread Loganaden Velvindron
Diff got garbled. Re-sending it: Index: cmds.c === RCS file: /cvs/src/usr.sbin/lpr/lpc/cmds.c,v retrieving revision 1.25 diff -u -p -r1.25 cmds.c --- cmds.c 24 Nov 2013 21:32:32 - 1.25 +++ cmds.c 29 Dec 2013 12:12:

lpr fd leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Fix fd leak in error cases. Found by cppcheck. Index: cmds.c === RCS file: /cvs/src/usr.sbin/lpr/lpc/cmds.c,v Index: cmds.c === RCS file: /cvs/src

ldconfig fd leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Fix file descriptor leak. Found by cppcheck. Index: src/libexec/ld.so/ldconfig/ldconfig.c === RCS file: /cvs/src/libexec/ld.so/ldconfig/ldconfig.c,v retrieving revision 1.31 diff -u -p -r1.31 ldconfig.c --- src

restore(8) fd leak fix

2013-12-29 Thread Loganaden Velvindron
Hi All, >From NetBSD: Fix fd leak. Found by cppcheck Index: src/sbin/restore/symtab.c === RCS file: /cvs/src/sbin/restore/symtab.c,v retrieving revision 1.20 diff -u -p -r1.20 symtab.c --- src/sbin/restore/symtab.c 24 Apr 2013 13:4