mke2fs.c memory leak

2013-12-24 Thread Loganaden Velvindron
>From NetBSD: free(bbp) in error paths. Coverity CID 274748. Index: src/sbin/newfs_ext2fs/mke2fs.c === RCS file: /cvs/src/sbin/newfs_ext2fs/mke2fs.c,v retrieving revision 1.5 diff -u -p -r1.5 mke2fs.c --- src/sbin/newfs_ext2fs/mke2f

[PATCH] usr.bin/indent: add -Wall -Werror to CFLAGS

2013-12-24 Thread Kent R. Spillner
usr.bin/indent nearly builds clean with -Wall -Werror. The diff below adds both to CFLAGS and fixes the minor fallout. Arguably, this doesn't buy us that much, but it makes me feel a little warmer before I start making too many more changes. I believe initializing tabs_to_var to zero is safe bec

[PATCH] usr.bin/indent: drop casts on malloc

2013-12-24 Thread Kent R. Spillner
One more tiny usr.bin/indent diff: drop some casts that are no longer needed. Index: indent.c === RCS file: /work/cvsroot/src/usr.bin/indent/indent.c,v retrieving revision 1.23 diff -p -u -r1.23 indent.c --- indent.c26 Nov 2013 1

[PATCH] regress: initial regression tests for usr.bin/indent

2013-12-24 Thread Kent R. Spillner
usr.bin/indent could use a little love, but first it needs some regression tests. The diff below is my initial attempt at this but before I progress too much further I'd like some feedback on the general direction I'm going, especially that Makefile. Is there a way to generalize all of the depend

Re: small ssh refinements

2013-12-24 Thread Darren Tucker
On Mon, Dec 23, 2013 at 10:21:59AM -0500, Ted Unangst wrote: > On Mon, Dec 23, 2013 at 10:25, Jérémie Courrèges-Anglas wrote: > > Ted Unangst writes: > > > >> Part one of this diff eliminates a series of u_long casts in favor of > >> just using native size_t types. A few other type adjustments. >

Re: base64 b64_pton fix

2013-12-24 Thread Gilles Chehade
On Mon, Dec 23, 2013 at 02:49:45PM -0500, Ted Unangst wrote: > be afraid, be very afraid... > b > If you base64 encode a buffer that's not a nice multiple of 3, you get > padding (=) bytes. When you decode those padding bytes, you should > get back a correctly sized buffer, but b64_pton doe