base64 b64_pton fix

2013-12-23 Thread Ted Unangst
be afraid, be very afraid... If you base64 encode a buffer that's not a nice multiple of 3, you get padding (=) bytes. When you decode those padding bytes, you should get back a correctly sized buffer, but b64_pton doesn't quite know this. It tries to write past the end sometimes. Test string bel

Re: small ssh refinements

2013-12-23 Thread Ted Unangst
On Mon, Dec 23, 2013 at 10:25, Jérémie Courrèges-Anglas wrote: > Ted Unangst writes: > >> Part one of this diff eliminates a series of u_long casts in favor of >> just using native size_t types. A few other type adjustments. > > Wouldn't that make ssh harder to port to systems where those types

Re: small ssh refinements

2013-12-23 Thread Jérémie Courrèges-Anglas
Ted Unangst writes: > Part one of this diff eliminates a series of u_long casts in favor of > just using native size_t types. A few other type adjustments. Wouldn't that make ssh harder to port to systems where those types aren't available? See for example millert's last commit to yacc/skeleton

Re: sha512 program

2013-12-23 Thread Jérémie Courrèges-Anglas
Ted Unangst writes: > 1. bigger is better. make a link to sha512. > > 2. simplify md5.c. there's really only two modes. > > 3. add a note to sha256.1 about sha512. I didn't go through and copy > all the text -- I would hope people can figure it out. Looks fine. Please see below. > Index: Makef