Re: Fix of sysctl.c rev. 1.191 related bug and unbreak diskless(8)

2013-07-14 Thread Philip Guenther
On Sun, Jul 14, 2013 at 12:54 AM, Rafael Neves wrote: > The patch below fixes a bug on sysctl(8) introduced by revision 1.191 > of sysctl.c. After rev1.191, `sysctl vfs' mangles information about > filesystems (mounted instances of ffs are attributed to nfs, of nfs > are atrributed to mfs, and so

Re: awk(1) update

2013-07-14 Thread Jérémie Courrèges-Anglas
Mark Kettenis writes: >> From: j...@wxcvbn.org (=?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges-Anglas?=) >> Date: Sun, 14 Jul 2013 09:41:28 +0200 >> >> >> This diff updates awk to the 20121220 upstream version, with a few >> fixups. >> >> ok? >> >> Index: tran.c >> ===

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Kenneth R Westerback
On Sun, Jul 14, 2013 at 08:22:45PM +0200, J??r??mie Courr??ges-Anglas wrote: > Kenneth R Westerback writes: > > > On Sun, Jul 14, 2013 at 05:56:46PM +0200, J??r??mie Courr??ges-Anglas wrote: > >> Kenneth R Westerback writes: > >> > >> > On Sun, Jul 14, 2013 at 03:13:32PM +0200, J??r??mie Courr?

Re: awk(1) update

2013-07-14 Thread Mark Kettenis
> From: j...@wxcvbn.org (=?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges-Anglas?=) > Date: Sun, 14 Jul 2013 09:41:28 +0200 > > > This diff updates awk to the 20121220 upstream version, with a few > fixups. > > ok? > > Index: tran.c > ==

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Rafael Neves
On 7/14/13, Theo de Raadt wrote: >> > Date: Sun, 14 Jul 2013 18:51:13 +0200 >> > From: Sebastian Benoit >> > >> > Mark Kettenis(mark.kette...@xs4all.nl) on 2013.07.14 17:06:24 +0200: >> > > > Date: Sun, 14 Jul 2013 14:09:26 +0200 >> > > > From: Henning Brauer >> > > > >> > > > * Rafael Neves [2

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: [...] >>> len = read(fd, &footer, sizeof(struct prebind_footer)); >>> + if (len >= -1 && len < sizeof(struct prebind_footer)) { >> >> I think this condition is incorrect. > > It checks whether len is in the [-1; 80] range. Err, [-1; 79] (i

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Jérémie Courrèges-Anglas
Kenneth R Westerback writes: > On Sun, Jul 14, 2013 at 05:56:46PM +0200, J??r??mie Courr??ges-Anglas wrote: >> Kenneth R Westerback writes: >> >> > On Sun, Jul 14, 2013 at 03:13:32PM +0200, J??r??mie Courr??ges-Anglas >> > wrote: >> >> Kenneth R Westerback writes: >> >> >> >> > On Sun, Jul 1

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Theo de Raadt
> > Date: Sun, 14 Jul 2013 18:51:13 +0200 > > From: Sebastian Benoit > > > > Mark Kettenis(mark.kette...@xs4all.nl) on 2013.07.14 17:06:24 +0200: > > > > Date: Sun, 14 Jul 2013 14:09:26 +0200 > > > > From: Henning Brauer > > > > > > > > * Rafael Neves [2013-07-14 11:01]: > > > > > Amd64 and i3

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Kenneth R Westerback
On Sun, Jul 14, 2013 at 05:56:46PM +0200, J??r??mie Courr??ges-Anglas wrote: > Kenneth R Westerback writes: > > > On Sun, Jul 14, 2013 at 03:13:32PM +0200, J??r??mie Courr??ges-Anglas wrote: > >> Kenneth R Westerback writes: > >> > >> > On Sun, Jul 14, 2013 at 09:23:53AM +0200, J??r??mie Courr?

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Mark Kettenis
> Date: Sun, 14 Jul 2013 18:51:13 +0200 > From: Sebastian Benoit > > Mark Kettenis(mark.kette...@xs4all.nl) on 2013.07.14 17:06:24 +0200: > > > Date: Sun, 14 Jul 2013 14:09:26 +0200 > > > From: Henning Brauer > > > > > > * Rafael Neves [2013-07-14 11:01]: > > > > Amd64 and i386 diskless(8) set

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Sebastian Benoit
Mark Kettenis(mark.kette...@xs4all.nl) on 2013.07.14 17:06:24 +0200: > > Date: Sun, 14 Jul 2013 14:09:26 +0200 > > From: Henning Brauer > > > > * Rafael Neves [2013-07-14 11:01]: > > > Amd64 and i386 diskless(8) setups need rpc.bootparamd(8) > > > > no, they don't. > > True diskless(4) operati

Re: manual patch for isakmpd's FIFO "r"

2013-07-14 Thread Jason McIntyre
On Fri, Jul 12, 2013 at 03:52:45PM +0200, Anders Berggren wrote: > >>> The following patch clarifies that sending "r" over the FIFO doesn't > >>> produce the exact same results as SIGUSR1. Or do you prefer that we > >>> change the behaviour of the FIFO's "r" to match SIGUSR1, for example by > >>

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Jérémie Courrèges-Anglas
Kenneth R Westerback writes: > On Sun, Jul 14, 2013 at 03:13:32PM +0200, J??r??mie Courr??ges-Anglas wrote: >> Kenneth R Westerback writes: >> >> > On Sun, Jul 14, 2013 at 09:23:53AM +0200, J??r??mie Courr??ges-Anglas >> > wrote: >> >> David Hill writes: >> >> >> >> > remove unused variables

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Mark Kettenis
> Date: Sun, 14 Jul 2013 14:09:26 +0200 > From: Henning Brauer > > * Rafael Neves [2013-07-14 11:01]: > > Amd64 and i386 diskless(8) setups need rpc.bootparamd(8) > > no, they don't. True diskless(4) operation (with root on nfs) needs rpc.bootparamd(8) an *all* architectures. Merely booting a

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Kenneth R Westerback
On Sun, Jul 14, 2013 at 03:13:32PM +0200, J??r??mie Courr??ges-Anglas wrote: > Kenneth R Westerback writes: > > > On Sun, Jul 14, 2013 at 09:23:53AM +0200, J??r??mie Courr??ges-Anglas wrote: > >> David Hill writes: > >> > >> > remove unused variables. > >> > >> Makes sense. ok? > >> > > [..

Re: add nl(1)

2013-07-14 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > On Mon, 20 May 2013 12:43:19 +0300, Arto Jonsson wrote: > >> Updated diff. I removed the int width handling and modified the >> separator printing based on your comment. > > That looks good to me. > > - todd I propose to import it. ok? (+ a note about NetBSD and Open

Re: Fix of sysctl.c rev. 1.191 related bug and unbreak diskless(8)

2013-07-14 Thread RD Thrush
Your patch applies correctly. 5>sysctl kern.version kern.version=OpenBSD 5.4-beta (GENERIC.MP) #27: Fri Jul 12 10:35:54 MDT 2013 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP 6>mount /dev/sd0a on / type ffs (local, softdep) mfs:26558 on /tmp type mfs (asynchronous, local

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Jérémie Courrèges-Anglas
Kenneth R Westerback writes: > On Sun, Jul 14, 2013 at 09:23:53AM +0200, J??r??mie Courr??ges-Anglas wrote: >> David Hill writes: >> >> > remove unused variables. >> >> Makes sense. ok? >> [...] >> >lseek(fd, -((off_t)sizeof(struct prebind_footer)), SEEK_END); >> > - len = read(fd, &f

Re: ldd.c - plug memleak

2013-07-14 Thread Kenneth R Westerback
On Sun, Jul 14, 2013 at 09:23:05AM +0200, J??r??mie Courr??ges-Anglas wrote: > David Hill writes: > > > Hello - > > Hi, > > > doit() was not free()'ing memory or close()'ing the file descriptor if > > realpath() failed or dlopen() returned NULL. > > > > This diff just moves close() and free() u

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Kenneth R Westerback
On Sun, Jul 14, 2013 at 09:23:53AM +0200, J??r??mie Courr??ges-Anglas wrote: > David Hill writes: > > > remove unused variables. > > Makes sense. ok? > > > Index: ldconfig/prebind.c > > === > > RCS file: /cvs/src/libexec/ld.so/ldc

Re: Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Jason McIntyre
On Sun, Jul 14, 2013 at 05:59:53AM -0300, Rafael Neves wrote: > Hi, > > Amd64 and i386 diskless(8) setups need rpc.bootparamd(8) to be enabled > to read /etc/bootparams. The patch below adds both archs to the list > of the ones that needs rpc.bootparamd(8). > they shouldn;t - this stuff is all c

Fix to diskless(8) manpage: add amd64 and i386 to the list of clients that needs rpc.bootparamd(8)

2013-07-14 Thread Rafael Neves
Hi, Amd64 and i386 diskless(8) setups need rpc.bootparamd(8) to be enabled to read /etc/bootparams. The patch below adds both archs to the list of the ones that needs rpc.bootparamd(8). Index: diskless.8 === RCS file: /cvs/src/share/

Fix of sysctl.c rev. 1.191 related bug and unbreak diskless(8)

2013-07-14 Thread Rafael Neves
Hi tech@, The patch below fixes a bug on sysctl(8) introduced by revision 1.191 of sysctl.c. After rev1.191, `sysctl vfs' mangles information about filesystems (mounted instances of ffs are attributed to nfs, of nfs are atrributed to mfs, and so on). As a consequence, `sysctl vfs.mounts.nfs' repor

awk(1) update

2013-07-14 Thread Jérémie Courrèges-Anglas
This diff updates awk to the 20121220 upstream version, with a few fixups. ok? Index: FIXES === RCS file: /cvs/src/usr.bin/awk/FIXES,v retrieving revision 1.16 diff -u -p -r1.16 FIXES --- FIXES 28 Sep 2011 19:27:18 -

Re: ldconfig/prebind.c - remove dead assignments

2013-07-14 Thread Jérémie Courrèges-Anglas
David Hill writes: > remove unused variables. Makes sense. ok? > Index: ldconfig/prebind.c > === > RCS file: /cvs/src/libexec/ld.so/ldconfig/prebind.c,v > retrieving revision 1.20 > diff -u -p -r1.20 prebind.c > --- ldconfig/prebi

Re: ldd.c - plug memleak

2013-07-14 Thread Jérémie Courrèges-Anglas
David Hill writes: > Hello - Hi, > doit() was not free()'ing memory or close()'ing the file descriptor if > realpath() failed or dlopen() returned NULL. > > This diff just moves close() and free() up once we are done using them. Makes sense. ok? > Index: ldd/ldd.c > =