Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Theo de Raadt
> sad but ok dlg@ > > On 22/05/2013, at 2:06 AM, Mark Kettenis wrote: > > >> From: Theo de Raadt > >> Date: Tue, 21 May 2013 09:23:04 -0600 > >> > >>> I'd say no. Why is the driver tearing down and reinitializing the dma > >>> maps when a watchdog timeout happens? That's just wrong. > >> >

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread David Gwynne
sad but ok dlg@ On 22/05/2013, at 2:06 AM, Mark Kettenis wrote: >> From: Theo de Raadt >> Date: Tue, 21 May 2013 09:23:04 -0600 >> >>> I'd say no. Why is the driver tearing down and reinitializing the dma >>> maps when a watchdog timeout happens? That's just wrong. >> >> Because bge_watchdo

Re: De-static functions' prototypes

2013-05-21 Thread Mark Kettenis
> From: "Alexey E. Suslikov" > Date: Tue, 21 May 2013 17:40:43 + (UTC) > > > CVSROOT:/cvs > > Module name:src > > Changes by: kettenis cvs.openbsd.org 2013/05/20 11:34:08 > > > > Modified files: > > sys/arch/i386/i386: amd64errata.c > > sys/arch/amd64/amd64: amd64errat

mg(1): shell-command

2013-05-21 Thread Mark Lumsden
This diff modifies the shell-command-on-region function and gives us shell-command. It makes getting output from other commands into mg really easy. Comments/oks? -lum Index: def.h === RCS file: /cvs/src/usr.bin/mg/def.h,v retrieving

[Patch] fix typo in bin/pax/cpio.c

2013-05-21 Thread Caspar Schutijser
Hi tech@, I found a typo in bin/pax/cpio.c. The comment is talking about a function called rd_nam(), but the function below it is called rd_nm(). In the file, there are no other references to rd_nam(). The patch is below. Best regards, Caspar Schutijser Index: bin/pax/cpio.c =

Re: call for testing: MSI for msk(4)

2013-05-21 Thread Mark Kettenis
> Date: Tue, 21 May 2013 18:46:23 +0200 > From: Martin Pieuchot > > On 16/05/13(Thu) 23:55, Jérémie Courrèges-Anglas wrote: > > Hi, > > > > I've been using msk(4) with MSI on my laptop since a few days, with no > > apparent problem. > > > > mskc0 at pci2 dev 0 function 0 "Marvell Yukon 88E80

De-static functions' prototypes

2013-05-21 Thread Alexey E. Suslikov
> CVSROOT: /cvs > Module name: src > Changes by: kettenis cvs.openbsd.org 2013/05/20 11:34:08 > > Modified files: > sys/arch/i386/i386: amd64errata.c > sys/arch/amd64/amd64: amd64errata.c > > Log message: > de-static-ize, such that people don't get confused by aesni failure

Re: call for testing: MSI for msk(4)

2013-05-21 Thread Martin Pieuchot
On 16/05/13(Thu) 23:55, Jérémie Courrèges-Anglas wrote: > Hi, > > I've been using msk(4) with MSI on my laptop since a few days, with no > apparent problem. > > mskc0 at pci2 dev 0 function 0 "Marvell Yukon 88E8040" rev 0x13, Yukon-2 FE+ > rev. A0 (0x0): msi > msk0 at mskc0 port A: address 00:24

Re: Kernel panic with alternative wscons console fonts

2013-05-21 Thread Miod Vallat
> While experimenting, I've found that fonts with WSDISPLAY_FONTENC_ISO > encoding like bold8x16-iso1 or sony8x16 are ok, while fonts with > WSDISPLAY_FONTENC_IBM (bold8x16, vt220l8x8) cause the kernel panic > below: Fixed. Thanks for the report!

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mark Kettenis
> From: Theo de Raadt > Date: Tue, 21 May 2013 09:23:04 -0600 > > > I'd say no. Why is the driver tearing down and reinitializing the dma > > maps when a watchdog timeout happens? That's just wrong. > > Because bge_watchdog() simply calls bge_init() to redo everything. It > is simply the way

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mike Belopuhov
On 21 May 2013 17:18, Mark Kettenis wrote: >> Date: Tue, 21 May 2013 17:10:57 +0200 >> From: Mike Belopuhov >> >> prevent the system from spitting loads of splasserts when bge_watchdog >> fires. ok? > > I'd say no. Why is the driver tearing down and reinitializing the dma > maps when a watchdog

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Theo de Raadt
> I'd say no. Why is the driver tearing down and reinitializing the dma > maps when a watchdog timeout happens? That's just wrong. Because bge_watchdog() simply calls bge_init() to redo everything. It is simply the way the driver was written. During autoconfig, NOWAIT will be OK. bge is not a

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mark Kettenis
> Date: Tue, 21 May 2013 17:10:57 +0200 > From: Mike Belopuhov > > prevent the system from spitting loads of splasserts when bge_watchdog > fires. ok? I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens? That's just wrong. > diff --git s

brgphy: reset autonegotiation timer when we get the link

2013-05-21 Thread Mike Belopuhov
from freebsd. ok? diff --git sys/dev/mii/brgphy.c sys/dev/mii/brgphy.c index 7f0bae2..461c798 100644 --- sys/dev/mii/brgphy.c +++ sys/dev/mii/brgphy.c @@ -412,8 +412,10 @@ setit: * the BMSR twice in case it's latched. */ reg = PHY_READ(sc, MII_BMSR

bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mike Belopuhov
prevent the system from spitting loads of splasserts when bge_watchdog fires. ok? diff --git sys/dev/pci/if_bge.c sys/dev/pci/if_bge.c index 055ceec..ffad959 100644 --- sys/dev/pci/if_bge.c +++ sys/dev/pci/if_bge.c @@ -1226,7 +1226,7 @@ bge_init_rx_ring_std(struct bge_softc *sc) for (i

Kernel panic with alternative wscons console fonts

2013-05-21 Thread David Coppa
Hi! So I have this netbook with a small screen (10 inch 1024x600)... I have toyed with a custom kernel using an alternative font for the wscons framebuffer console to get bigger screen estate. ---8<--- Index: GENERIC === RCS file:

Re: Somewhat important ACPI diff

2013-05-21 Thread Jérémie Courrèges-Anglas
Hi, No problem here on a samsung NC10, including suspend/resume. No dmesg change. -- Jérémie Courrèges-Anglas PGP Key fingerprint: 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494 OpenBSD 5.3-current (GENERIC) #29: Tue May 21 10:48:51 CEST 2013 j...@shannon.wxcvbn.org:/usr/src/sys/arch/i3

Re: Somewhat important ACPI diff

2013-05-21 Thread Mark Kettenis
> From: Henri Kemppainen > Date: Tue, 21 May 2013 10:50:19 +0300 (EEST) > > > + if (blen > aml_intlen) { > > + if (mode == ACPI_IOREAD) { > > + /* Read from a large field: create buffer */ > > + _aml_setvalue(val, AML_OBJTYPE_BUFFER, > > +

Re: Somewhat important ACPI diff

2013-05-21 Thread Gregor Best
On Tue, May 21, 2013 at 10:15:02AM +0400, Vadim Zhukov wrote: > [...] > ThinkPad X201i, fine here for an half a day (running since the time you > posted the diff). dmesg doesn't have any borked stuff, suspend/resume works > fine, both for short and long periods. > [...] Likewise with my Thinkpad R