Re: ftpd log address format

2013-05-07 Thread Bob Beck
My two cents on this is that it should be possible (or the default) to have it logging the IP address. Having said that ted, yes, DNS is not "reliable" in some sense - on the other hand the reverse lookup *is* information that can be useful, and in the case of dynamic DNS it may contain informatio

Re: ftpd log address format

2013-05-07 Thread Nick Holland
On 05/07/2013 04:15 PM, Stuart Henderson wrote: On 2013/05/07 16:09, Ted Unangst wrote: On Tue, May 07, 2013 at 20:54, Stuart Henderson wrote: I don't like logging both because there's a not unreasonable chance the reverse name will be a complete lie, which will just mislead you. Oh, it does

Re: ftpd log address format

2013-05-07 Thread Ted Unangst
On Tue, May 07, 2013 at 21:15, Stuart Henderson wrote: > On 2013/05/07 16:09, Ted Unangst wrote: >> On Tue, May 07, 2013 at 20:54, Stuart Henderson wrote: >> >> >> I don't like logging both because there's a not unreasonable chance >> >> the reverse name will be a complete lie, which will just misl

Re: ftpd log address format

2013-05-07 Thread Stuart Henderson
On 2013/05/07 16:09, Ted Unangst wrote: > On Tue, May 07, 2013 at 20:54, Stuart Henderson wrote: > > >> I don't like logging both because there's a not unreasonable chance > >> the reverse name will be a complete lie, which will just mislead you. > > > > Oh, it doesn't do a forward check of the n

Re: ftpd log address format

2013-05-07 Thread Ted Unangst
On Tue, May 07, 2013 at 20:54, Stuart Henderson wrote: >> I don't like logging both because there's a not unreasonable chance >> the reverse name will be a complete lie, which will just mislead you. > > Oh, it doesn't do a forward check of the name it got from reverse > lookup? Yes that's bad. W

Re: ftpd log address format

2013-05-07 Thread Stuart Henderson
On 2013/05/07 14:26, Ted Unangst wrote: > On Sun, May 05, 2013 at 15:18, Stuart Henderson wrote: > > > I don't feel too strongly about it but my preference would be to > > log both. There are circumstances (e.g. dhcp with dynamic dns updates) > > where it's useful to have the reverse at the time o

Re: ftpd log address format

2013-05-07 Thread Peter Hessler
On 2013 May 07 (Tue) at 14:26:07 -0400 (-0400), Ted Unangst wrote: :On Sun, May 05, 2013 at 15:18, Stuart Henderson wrote: : :> I don't feel too strongly about it but my preference would be to :> log both. There are circumstances (e.g. dhcp with dynamic dns updates) :> where it's useful to have the

Re: ftpd log address format

2013-05-07 Thread Ted Unangst
On Sun, May 05, 2013 at 15:18, Stuart Henderson wrote: > I don't feel too strongly about it but my preference would be to > log both. There are circumstances (e.g. dhcp with dynamic dns updates) > where it's useful to have the reverse at the time of connection. Are you talking about internal or e

Re: ftpd log address format

2013-05-07 Thread Martijn van Duren
On 05/05/13 16:18, Stuart Henderson wrote: On 2013/05/05 10:06, Nick Holland wrote: On 05/04/13 01:57, Ted Unangst wrote: On Sat, May 04, 2013 at 07:26, Martijn van Duren wrote: For a lot of cases this isn't a problem. But there are a couple of instances where the domain name resolves to somet

off by one in vi(1)

2013-05-07 Thread Arto Jonsson
Apr 23 -current snapshot amd64 While writing an email vi(1) crashed with segmentation fault. When ^W (WERASE) is hit in insert mode it's possible that the line buffer is accessed out of bounds. If 'max' == 0 and 'tp->cno' == 1 the 'tp->cno' value is first reduced by one and then 'tp->lb' is acces

Re: CryptoCard support broken on AMD64

2013-05-07 Thread Ted Unangst
On Tue, May 07, 2013 at 11:13, Matthias Pitzl wrote: > Hi! > > I think the support for CryptoCards is broken on AMD64. > The diff below fixes it again. Very good!

CryptoCard support broken on AMD64

2013-05-07 Thread Matthias Pitzl
Hi! I think the support for CryptoCards is broken on AMD64. The diff below fixes it again. Greetings, Matthias --- libexec/login_token/token.c Sun Jan 13 22:21:17 2013 +++ libexec/login_token/token.c Mon May 6 15:28:17 2013 @@ -63,7 +63,