Re: libc warnings

On Thu, Apr 4, 2013 at 6:49 PM, Ted Unangst wrote: > To prevent the future recurrence of some rather serious libc build > bugs, such as a macro like strong_alias suddenly turning into an > implicit function prototype, I think we should add some warnings and > use as much -Werror as possible. (I'm

pool again protection

I was given a scare today by an unnamed party because calling pool_init twice causes bad things to happen. And whenever bad things happen in pool, I get blamed. To turn future tedu panics into kernel panics, here's a diff. Whenever pool_init is called, we check the list of existing pools to make s

Re: include isa.h in sys/arch/i386/i386/trap.c

On Mon, Apr 8, 2013 at 2:43 AM, Christian Groessler wrote: > trap.c has a "#if NISA > 0" at line 504. > > But NISA is never defined, so the code in the #if clause never gets compiled > in. > This patch includes isa.h from the build directory in order to have the NISA > definition. Yep. Diff com

Re: amd64/identcpu.c: Missing #ifdef CRYPTO for amd64_has_aesni

On Mon, Apr 8, 2013 at 6:17 AM, Silamael wrote: > I think the check whether the CPU has AES builtin misses an #ifdef > CRYPTO as it is there for the declaration of amd64_has_aesni. Yep. Diff committed. Thanks! Philip Guenther

Re: external ip/tcp (sysctl) variables

On Mon, Apr 8, 2013 at 6:30 AM, Martin Pieuchot wrote: > Diff below remove various external variable declaration from sources > files and move them to the corresponding header with an appropriate > comment if necessary. > > ok? I like the idea. I agree with Alexey about copying forward the #ifde

Possible relayd memory leak analysis

hi tech@ tools used: * ps auxwww | grep relayd * httperf --hog --server=192.168.5.201 --wsess=25,1000,0.1 --rate=50 --timeout=5 target machine: OpenBSD 5.3-current (GENERIC.MP) #0: Sun Apr 7 15:14:10 EEST 2013 *@*:/usr/src/sys/arch/amd64/compile/GENERIC.MP /etc/relayd.conf: ext_addr="192.1

Re: biowaittime

On Sun, Apr 07, 2013 at 22:31, Navan Carson wrote: > Hi Ted, > > I really like the idea of gathering data about time spent waiting for a > disk, but where do I find this data? (as root) pstat -d lld biowaittime it's not exported anywhere, at least not as part of that diff.

Re: external ip/tcp (sysctl) variables

> RCS file: /home/ncvs/src/sys/netinet/ip_var.h,v > retrieving revision 1.44 > diff -u -p -r1.44 ip_var.h > --- netinet/ip_var.h 16 Jul 2012 18:05:36 - 1.44 > +++ netinet/ip_var.h 8 Apr 2013 13:23:23 - > @@ -149,8 +149,20 @@ extern struct ipstat ipstat; > extern LIST_HEAD(ipqhead, ipq) ipq

add ut/nut indent flags

The following adds ut/nut flags to indent to enable/disable tabs which seems to have originated in gnu indent. -nut seems to have quite a bit of usage and is currently assumed in the Mesa3D build when generating code. Diff based on FreeBSD svn rev 131184. Unrelated to this diff there seems to b

external ip/tcp (sysctl) variables

Diff below remove various external variable declaration from sources files and move them to the corresponding header with an appropriate comment if necessary. ok? Index: netinet/igmp.c === RCS file: /home/ncvs/src/sys/netinet/igmp.c,

amd64/identcpu.c: Missing #ifdef CRYPTO for amd64_has_aesni

Hi there, I think the check whether the CPU has AES builtin misses an #ifdef CRYPTO as it is there for the declaration of amd64_has_aesni. -- Matthias Index: identcpu.c === RCS file: /cvs/src/sys/arch/amd64/amd64/identcpu.c,v retri

RSVP

Diff below removes code protected under RSVP_ISI that doesn't even compile. Anybody objecting to it's teduification? Any ok? Index: netinet/igmp.c === RCS file: /home/ncvs/src/sys/netinet/igmp.c,v retrieving revision 1.31 diff -u -p

include isa.h in sys/arch/i386/i386/trap.c

Hi, trap.c has a "#if NISA > 0" at line 504. But NISA is never defined, so the code in the #if clause never gets compiled in. This patch includes isa.h from the build directory in order to have the NISA definition. regards, chris Index: sys/arch/i386/i386/trap.c ==