Re: have wakeup() return the number of processes woken up

2013-03-14 Thread Theo de Raadt
> Mostly useful for debugging and error checking. I know this isn't actually the whole truth, and there is some risk someone will do something stupid in the future, but then we never truly are safe against stupidity, are we... OK.

Re: have wakeup() return the number of processes woken up

2013-03-14 Thread Philip Guenther
On Thu, Mar 14, 2013 at 9:20 PM, Jonathan Gray wrote: > The following diff changes wakeup so it will return > the number of processes it has woken up. Mostly > useful for debugging and error checking. > > I initialy had a seperate function to check for a pending > wakeup but switched to the follo

have wakeup() return the number of processes woken up

2013-03-14 Thread Jonathan Gray
The following diff changes wakeup so it will return the number of processes it has woken up. Mostly useful for debugging and error checking. I initialy had a seperate function to check for a pending wakeup but switched to the following after a suggestion from guenther. Index: sys/sys/systm.h ===

kernel malloc poison

2013-03-14 Thread Ted Unangst
In prep for some other changes, I'm factoring some of the deadbeef checking. It doesn't change anything functional (yet), but at a minimum I think this is much clearer than all the pointers and casts and lions and tigers: - end = (int32_t *)&freep->next + - (sizeof(freep->next) /

Re: [PATCH] tftpd: DoS vuln

2013-03-14 Thread Ted Unangst
After reading your description, I was expecting the patch to include a line setting options to null after freeing it. Whatever else we do, shouldn't we do that too? On Fri, Mar 15, 2013 at 00:02, Maxime Villard wrote: > Hi, > there is a huge bug in the tftp daemon. > > -- /usr/src/usr.sbin/tft

[PATCH] tftpd: DoS vuln

2013-03-14 Thread Maxime Villard
Hi, there is a huge bug in the tftp daemon. -- /usr/src/usr.sbin/tftpd/tftpd.c -- In tftp_open() on line 870, the daemon checks for options (OACK) and handle them through the oack() function. Then, it frees and NULLs the variable client->options. oack() - l.1390 - does some stuff, and if an error

Re: Let Geode-based systems restart automatically after power failure

2013-03-14 Thread Miod Vallat
> the Soerkis 5501 doesn't have any power switch. If automatic power on > mode wouldn't have been enabled for them by default, any power failure > would've bricked them. I am not surprised, there is likely a pull-up somewhere on the board to achieve this. But I still would like to know if Soekris

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Alexey Suslikov
On Thu, Mar 14, 2013 at 6:48 PM, Ted Unangst wrote: > On Thu, Mar 14, 2013 at 17:24, Antoine Jacoutot wrote: >> On Thu, Mar 14, 2013 at 11:41:52AM -0400, Ted Unangst wrote: >>> On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: >>> >>> > FYI I am seeing a somehow similar crash when using sysut

[Patch] Support F13-F24 on PC-122 terminal keyboard

2013-03-14 Thread Creamy
The following patch adds the keycodes for F13-F24 on a standard PC-122 terminal keyboard. Doesn't seem to conflict with anything else I've found. -- Creamy --- wskbdmap_mfii.c.origTue May 24 13:23:46 2011 +++ wskbdmap_mfii.c Thu Mar 14 13:10:56 2013 @@ -130,6 +130,18 @@ KC(83),

[Patch] Repeat key patch against 5.2-release

2013-03-14 Thread Creamy
Diff'ed against 5.2-release -- Creamy --- wsksymdef.h.origTue May 24 13:23:49 2011 +++ wsksymdef.h Thu Mar 7 18:50:32 2013 @@ -507,6 +509,7 @@ #define KS_Henkan 0xf115 /* Alias for Henkan_Mode */ #define KS_Muhenkan0xf116 /* Cancel Conversion */ #define KS_Mode_L

[Patch] Add repeat key functionality

2013-03-14 Thread Creamy
Hello, The following patches add functionality to the console for a 'repeat' key, basically a modifier key which adjusts the typematic delay whilst held down. Usually these were found on systems which didn't have auto-repeat, but this implementation preserves the normal functionality, so that you

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Antoine Jacoutot
On Thu, Mar 14, 2013 at 12:48:52PM -0400, Ted Unangst wrote: > On Thu, Mar 14, 2013 at 17:24, Antoine Jacoutot wrote: > > On Thu, Mar 14, 2013 at 11:41:52AM -0400, Ted Unangst wrote: > >> On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: > >> > >> > FYI I am seeing a somehow similar crash when

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Ted Unangst
On Thu, Mar 14, 2013 at 17:24, Antoine Jacoutot wrote: > On Thu, Mar 14, 2013 at 11:41:52AM -0400, Ted Unangst wrote: >> On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: >> >> > FYI I am seeing a somehow similar crash when using sysutils/bacula (both >> > 5.2 and 5.3). >> > It is 100% reprodu

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Antoine Jacoutot
On Thu, Mar 14, 2013 at 11:41:52AM -0400, Ted Unangst wrote: > On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: > > > FYI I am seeing a somehow similar crash when using sysutils/bacula (both > > 5.2 and 5.3). > > It is 100% reproducible on my setup. Obviously painful since it means I > > can

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Ted Unangst
On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: > FYI I am seeing a somehow similar crash when using sysutils/bacula (both > 5.2 and 5.3). > It is 100% reproducible on my setup. Obviously painful since it means I > cannot run backups anymore... The following is brought to you without testi

Re: [PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Jason McIntyre
On Thu, Mar 14, 2013 at 02:49:01PM +, Jason McIntyre wrote: > > sorry, i obviously didn;t read the diff well enough. i agree at least > mail/README should be fixed. i'll see what millert thinks. > ok, diff committed (except for the Revision strings, which cvs would just re-expand); jmc

Re: [PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Stuart Henderson
On 2013/03/14 15:37, Jérémie Courrèges-Anglas wrote: > PS: are there people already working on a sendmail port? Not that I know of, but I think it is wanted. Having it in ports will actually make it easier for certain uses (e.g. people using it with SASL and/or LDAP). And of course any groff-based

Re: [PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Jason McIntyre
On Thu, Mar 14, 2013 at 03:37:25PM +0100, J??r??mie Courr??ges-Anglas wrote: > > OK, perhaps should I have taken more time to explain my thinking: > my understanding was indeed that those had been on-purpose unlinked from > the build, and I do not suggest re-linking them. My point was just to > m

Re: [PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Jérémie Courrèges-Anglas
Jason McIntyre writes: > On Thu, Mar 14, 2013 at 12:59:22PM +0100, Jérémie Courrèges-Anglas wrote: >> Hi, >> >> while the various README files are helpful, not everyone has the bat >> book at hand for more complex questions. Here's a diff to update the >> doc/op/Makefile and make it useful to p

Re: [PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Jason McIntyre
On Thu, Mar 14, 2013 at 12:59:22PM +0100, J??r??mie Courr??ges-Anglas wrote: > Hi, > > while the various README files are helpful, not everyone has the bat > book at hand for more complex questions. Here's a diff to update the > doc/op/Makefile and make it useful to people who have groff installe

bgpd(8): fix use after free

2013-03-14 Thread Florian Obser
33% found by llvm. The -1 is propagated up from a failed calloc in kif_kr_insert/kif_kr6_insert. ok? Index: kroute.c === RCS file: /cvs/src/usr.sbin/bgpd/kroute.c,v retrieving revision 1.191 diff -u -p -r1.191 kroute.c --- kroute.c

bgpd(8): fix sizeof(struct)

2013-03-14 Thread Florian Obser
found by llvm ok? Index: rde_rib.c === RCS file: /cvs/src/usr.sbin/bgpd/rde_rib.c,v retrieving revision 1.134 diff -u -p -r1.134 rde_rib.c --- rde_rib.c 12 Sep 2012 05:56:22 - 1.134 +++ rde_rib.c 14 Mar 2013 13:07:30 -000

Re: Threads related SIGSEGV in random.c (diff, v2)

2013-03-14 Thread Antoine Jacoutot
On Thu, Sep 27, 2012 at 12:43:24PM +0300, Alexey Suslikov wrote: > Program received signal SIGSEGV, Segmentation fault. > [Switching to thread 1006387] > 0x0cb33345cf6e in random () at /usr/src/lib/libc/stdlib/random.c:387 > 387 *fptr += *rptr; > > Back trace: > > Thread 1

[PATCH] make Sendmail documentation easier to build

2013-03-14 Thread Jérémie Courrèges-Anglas
Hi, while the various README files are helpful, not everyone has the bat book at hand for more complex questions. Here's a diff to update the doc/op/Makefile and make it useful to people who have groff installed. The Makefile is just a slightly tweaked version from upstream, I have also updated

Re: [PATCH] Add Canadian calendar to calendar(1)

2013-03-14 Thread Jason McIntyre
On Fri, Mar 08, 2013 at 02:57:30PM -0500, Ryan Kavanagh wrote: > Hi, > > I'm attaching a patch that adds a calendar with Canadian holidays to > calendar(1). This complements the current calendar.usholidays file. > > Best wishes, > Ryan > with the exception of spelling it "All Hallows' Eve" (apo