Hi,
here are my small changes for pfctl.
1) There are cases where we could leak a file descriptor by
returning.
2) We don't need to check memory before freeing it, as
free() already does that.
3) Just replaced a snprintf() by strlcpy(), it's faster.
Ok/Comments ?
Index: pfctl.c
===
On Fri, Dec 21, 2012 at 06:47:49PM +, Stuart Henderson wrote:
> On 2012/12/21 18:31, Jason McIntyre wrote:
> > > -There's no hardware involved: thru boxes are created by
> > > +There is no hardware involved: thru boxes are created by
> >
> > i don;t see why this is an improvement. what's wrong
> > -There's no hardware involved: thru boxes are created by
> > +There is no hardware involved: thru boxes are created by
>
> i don;t see why this is an improvement. what's wrong with it?
Well, I didn't mean it was wrong or a bug, but the relaxed style seemed
inconsistent with the rest of the pa
On 2012/12/21 18:31, Jason McIntyre wrote:
> > -There's no hardware involved: thru boxes are created by
> > +There is no hardware involved: thru boxes are created by
>
> i don;t see why this is an improvement. what's wrong with it?
"No hardware is involved" might be a slight improvement,
"There i
On Fri, Dec 21, 2012 at 06:04:47PM +0100, Martin Toft wrote:
> One typo and two style issues:
>
> --- sndio.7.orig2012-12-21 17:55:39.415008759 +0100
> +++ sndio.7 2012-12-21 18:01:20.607018154 +0100
> @@ -44,7 +44,7 @@
> while doing all necessary conversions on the fly.
> It can mix multipl
One typo and two style issues:
--- sndio.7.orig2012-12-21 17:55:39.415008759 +0100
+++ sndio.7 2012-12-21 18:01:20.607018154 +0100
@@ -44,7 +44,7 @@
while doing all necessary conversions on the fly.
It can mix multiple streams or split the hardware into
multiple subdevices, to allow program
