Re: [PATCH] OpenSSH: auth.c

2012-12-13 Thread Darren Tucker
On Thu, Dec 13, 2012 at 07:31:46PM +0100, Maxime Villard wrote: > Hi, > I was looking at some openssh code when I spotted a mistake applied, thanks. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experi

[PATCH] OpenSSH: auth.c

2012-12-13 Thread Maxime Villard
Hi, I was looking at some openssh code when I spotted a mistake in a function from auth.c: static int secure_filename(FILE *f, const char *file, struct passwd *pw, char *err, size_t errlen) { char buf[MAXPATHLEN]; struct stat st; /* check the open file to avoid races

Re: ix: implement sfp+ module attach interrupt handling

2012-12-13 Thread Mike Belopuhov
On Thu, Dec 13, 2012 at 20:49 +0100, Mike Belopuhov wrote: > first this allows you to connect the sfp+ cable after boot > and correctly identify and use it, secondly it allows you > (supposedly as i've only tested two different types of > direct attach cables, i.e. different phys) to switch between

ix: implement sfp+ module attach interrupt handling

2012-12-13 Thread Mike Belopuhov
first this allows you to connect the sfp+ cable after boot and correctly identify and use it, secondly it allows you (supposedly as i've only tested two different types of direct attach cables, i.e. different phys) to switch between copper and fiber w/o rebooting. SDP1 interrupt processing is not

ospf6d: redistribute blackholed default

2012-12-13 Thread Florian Obser
kroute.c rev 1.69 of ospfd for ospf6d date: 2009/06/02 20:16:59; author: claudio; state: Exp; lines: +13 -3 Track reject and blackhole routes and allow them to be redistributed even though they point to the loopback. Mainly

Re: [PATCH] remove useless casts in if_gre.c

2012-12-13 Thread sickmind
On 03:07 Thu 13 Dec , Rafael Ferreira Neves wrote: > Hello, > > I think that the original code is correct. The definition of ip_output > function says that the first argument is a pointer to an mbuf, but the > other are variadic. In this case style(9) states that (type *)NULL should > be used.

Re: dhclient(8): fix segfault if calloc()/strdup() return NULL

2012-12-13 Thread Joerg Zinke
Am 11.12.2012 um 04:12 schrieb Lawrence Teo : > There are a number of calloc() and strdup() calls in the > apply_defaults() and clone_lease() functions whose return values are not > checked. If they happen to return NULL, dhclient will segfault. > > This diff checks their return values and does