Re: [PATCH] simplify ntfs_access()

2012-11-20 Thread Miod Vallat
> Hi Tech, > > In ntfs_access(), 'mask' is being built up in > three different places. From what I can see > 'mode' doesn't change within this function, > so can't we simply set 'mask' once before > checking owner, groups and everyone? > Comments? Look again. The three instances compute different

[PATCH] remove goto label in msdosfs_vfsops.c

2012-11-20 Thread Michael W. Bombardieri
Hi Tech, I have a small msdosfs patch... Error cases are handled inconsistently in msdosfs_mount(). Some cases use the construct "if (error) goto error;", others just return error immediately. The following patch removes the goto label and makes the function return error consistently. Does this

[PATCH] simplify ntfs_access()

2012-11-20 Thread Michael W. Bombardieri
Hi Tech, In ntfs_access(), 'mask' is being built up in three different places. From what I can see 'mode' doesn't change within this function, so can't we simply set 'mask' once before checking owner, groups and everyone? Comments? - Michael Index: ntfs_vnops.c =

[PATCH] remove duplicate NULL check in if_ppp.c

2012-11-20 Thread Michael W. Bombardieri
Hi Tech, I have a small ppp diff... At the top of function ppp_ccp() we check m->m_len against PPP_HDRLEN. After accessing m_next we return if the new mp value is NULL. Immediately after that, we check mp for NULL again. The following patch removes the duplicate check. Does this look OK? - Mich

Re: missing include in sys/proc.h?

2012-11-20 Thread Ted Unangst
On Tue, Nov 20, 2012 at 16:08, Amit Kulkarni wrote: > While porting boost-1.52.0 (latest boost) and checking affected ports, I > came across this. > In file included from /usr/include/sys/sysctl.h:42, > I can patch and include sys/param.h in this graphics/mapnik port but > sys/proc.h doesn't inclu

missing include in sys/proc.h?

2012-11-20 Thread Amit Kulkarni
While porting boost-1.52.0 (latest boost) and checking affected ports, I came across this. c++ -o src/mapped_memory_cache.os -c -DHAVE_JPEG -pthread -ansi -Wall -pthread -ftemplate-depth-300 -DOPENBSD -DBOOST_SPIRIT_THREADSAFE -DMAPNIK_THREADSAFE -O3 -finline-functions -Wno-inline -DNDEBUG -DHA

Re: USB Wireless Micro Adapter IWL 4000 support

2012-11-20 Thread Peter J. Philipp
On Tue, Nov 20, 2012 at 04:33:27PM +0100, Peter J. Philipp wrote: > urtwn0 at uhub0 port 1 "Realtek Belkin Wireless Adapter" rev 2.00/2.00 addr 2 > urtwn0: MAC/BB RTL8192CU, RF 6052 2T2R, address ec:1a:59:0d:fa:1c Hrmm, sometimes it does not detect right. I had to cold boot my netbook last for it

USB Wireless Micro Adapter IWL 4000 support

2012-11-20 Thread Peter J. Philipp
First off I'd like to say that today luck was with me. Big time. I went to a local store (saturn.de) to buy a wireless usb adapter and picked one out that I thought was supported. I did not take my netbook with me so I didn't know if it would work or not. So when I got home it was detected as

Re: Add ATI Radeon HD 7850 to pcidevs

2012-11-20 Thread Thomas Pfaff
On Mon, 19 Nov 2012 18:44:23 +0100 Thomas Pfaff wrote: > Add ATI Radeon HD 7850 to pcidevs. Sorted by PCI ID this time (dmesg also included). Index: pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1661 di

axe(4) support for D-Link DUB-E100 rev C1

2012-11-20 Thread Kirill Bychkov
Hi. A friend of mine get D-Link DUB-E100, but it is build on another chip revision. This diff adds support for this adapter. Tested on amd64 for a couple of days, but without high load. Needs further testing or OK to commit? Index: if_axe.c =