ldpctl(8) fix invalid uptime

2012-05-10 Thread Rafael Zalamena
This patch fixes the invalid uptime for interface which are not active (no link). When ldpd is running on an interface with no link it shows a invalid value. Steps to reproduce: 1 - Configure ldpd on an interface without link 2 - Start ldpd 3 - Run 'ldpctl show interfaces' Bugged result: Interfac

Re: pf logs: def/(short) pass in , but should say block

2012-05-10 Thread Henning Brauer
I'm looking for oks on this diff to commit it. * Leonardo Guardati [2012-05-10 21:29]: > Hi, > here is a solution to the problem I posted on bugs@ about pf logging > incoming UDP packets to port 0 as pass while being blocked instead. > > action is added to pflog_packet() arguments. > > I trie

pf logs: def/(short) pass in , but should say block

2012-05-10 Thread Leonardo Guardati
Hi, here is a solution to the problem I posted on bugs@ about pf logging incoming UDP packets to port 0 as pass while being blocked instead. action is added to pflog_packet() arguments. I tried it and works. Here are the diffs: --- if_pflog.c 2012-05-10 20:04:40.16484 +0200 +++ if_pflog-

Tandil 67% OFF | Cena Gourmet en BRANDS 52% OFF | Cafetera de Filtro 51% OFF | Peninsula Valdez 75% OFF | Kingston de 8 GB 50% OFF | Camara Digital SAMSUNG 49% OFF | Grill George Foreman 59% OFF

2012-05-10 Thread Bonus Cupon
Para visualizar correctamente este newsletter ingresa a http://news1.bonuscupon.com.ar/r.html?uid=1.d.295h.5s.p7d8em4epv

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Otto Moerbeek
On Thu, May 10, 2012 at 05:00:19PM +, Miod Vallat wrote: > > Look, landry just reminded me that I forgot to commit this. It was mostly > > awaiting test results, and we've been running with this for almost two > > months. > > > > If you think something else is better, take it upstream, since

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Miod Vallat
> Look, landry just reminded me that I forgot to commit this. It was mostly > awaiting test results, and we've been running with this for almost two > months. > > If you think something else is better, take it upstream, since I actually > took the fix from recent gcc, and I'd prefer to avoid diver

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Marc Espie
On Thu, May 10, 2012 at 08:46:26AM -0700, Matthew Dempsky wrote: > On Thu, Mar 15, 2012 at 3:19 AM, Marc Espie wrote: > > #define __glibcxx_max(T) \ > > - (__glibcxx_signed (T) ? ((T)1 << __glibcxx_digits (T)) - 1 : ~(T)0) > > + (__glibcxx_signed (T) ? \ > > + (T)1 << (__glibcxx_digits

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Matthew Dempsky
Oh even if it's not signed that ternary branch will still be in code. I see. Hm. On May 10, 2012 9:23 AM, "Matthew Dempsky" wrote:

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Matthew Dempsky
I'm pretty sure unsigned int is never a signed type.

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Otto Moerbeek
On Thu, May 10, 2012 at 08:46:26AM -0700, Matthew Dempsky wrote: > On Thu, Mar 15, 2012 at 3:19 AM, Marc Espie wrote: > > #define __glibcxx_max(T) \ > > - (__glibcxx_signed (T) ? ((T)1 << __glibcxx_digits (T)) - 1 : ~(T)0) > > + (__glibcxx_signed (T) ? \ > > + (T)1 << (__glibcxx_digit

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Matthew Dempsky
On Thu, Mar 15, 2012 at 3:19 AM, Marc Espie wrote: > #define __glibcxx_max(T) \ > - (__glibcxx_signed (T) ? ((T)1 << __glibcxx_digits (T)) - 1 : ~(T)0) > + (__glibcxx_signed (T) ? \ > + (T)1 << (__glibcxx_digits (T) - 1)) - 1) << 1) + 1) : ~(T)0) > + How about (T)(((unsigned T)1 << __

Re: [patch] em: interrupt starvation

2012-05-10 Thread Erik Lax
On 5/10/12 3:41 PM, Mike Belopuhov wrote: > That's a great find. In fact, you're right, "em_start() a few lines up" > should be done after em_update_link_status because of the link_active. > The following diff makes it work the same way ix(4) does. Please verify > that it fixes the problem. Than

Re: [patch] em: interrupt starvation

2012-05-10 Thread Mike Belopuhov
On Thu, May 10, 2012 at 15:22 +0200, Erik Lax wrote: > Hi, > > I came across a real-world scenario where network traffic stopped due to > interrupt starvation with the em driver, tested with a few different > cards (on a network/interface where no packets were received). This is > what caused it.

[patch] em: interrupt starvation

2012-05-10 Thread Erik Lax
Hi, I came across a real-world scenario where network traffic stopped due to interrupt starvation with the em driver, tested with a few different cards (on a network/interface where no packets were received). This is what caused it. I had two computers with a cable directly connected on a small ne

Re: c++ headers w/ -pedantic, overflow in implicit constant conversion

2012-05-10 Thread Landry Breuil
On Thu, Mar 15, 2012 at 11:19:43AM +0100, Marc Espie wrote: > On Thu, Mar 15, 2012 at 01:39:18AM +, Stuart Henderson wrote: > > $ c++ -pedantic -c a.c > > In file included from /usr/include/g++/memory:60, > > from /usr/include/g++/string:48, > > from a.c:1: > >