ftp mput recursiv upload diff for testing

2012-01-12 Thread Jan Klemkow
Hello, this is my diff for recursive upload for ftp(1). It modifies the mput command for doing this. Please test it and tell me everything that is wrong with it. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v re

Re: overlapping IPv6 fragments in pf

2012-01-12 Thread Alexander Bluhm
On Thu, Jan 12, 2012 at 05:31:00AM -0300, Fernando Gont wrote: > I'd argue that you should drop all the "constituent fragments" as soon > as you receive them. > > Since there's no legitimate reason of overlapping fragments, get rid of > them asap. And if there were more fragments (for the same pac

Re: overlapping IPv6 fragments in pf

2012-01-12 Thread Kenneth Gober
On Thu, Jan 12, 2012 at 3:31 AM, Fernando Gont wrote: > On 01/12/2012 12:03 AM, Alexander Bluhm wrote: > > Drop overlapping IPv6 fragments in pf reassembly code. RFC 5722 > > is demanding that. Our stack does that already. > > > > The text "constituent fragments, including those not yet receive

pci label for SiS 6351

2012-01-12 Thread Loganaden Velvindron
vga1 at pci1 dev 0 function 0 "SiS 6351 VGA" rev 0x10 This is the integrated vga of the motherboard. diff: Index: src/sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1633 diff -u -p -r1.1633 pci

Re: SiS 5513 rev 0x015597/5598 freeze & diff

2012-01-12 Thread Loganaden Velvindron
On Wed, Jan 04, 2012 at 02:55:04PM +1100, Jonathan Gray wrote: > On Mon, Jan 02, 2012 at 04:35:39PM -0500, Loganaden Velvindron wrote: > > Attaching any CDROM/DVDRIVE causes this error message > > when mouting a disk. > > > > cd0(pciide0:0:1): timeout > > type: atapi > > c_bcount : 2048 > > c_skip

diff: fix compiler warnings of npppd

2012-01-12 Thread YASUOKA Masahiko
This fixes many compiler warnings and some styles. ok? Index: l2tp/l2tp.h === RCS file: /cvs/src/usr.sbin/npppd/l2tp/l2tp.h,v retrieving revision 1.5 diff -u -p -r1.5 l2tp.h --- l2tp/l2tp.h 15 Oct 2011 03:24:11 - 1.5 +++ l2

Re: handle overlapping IPv6 fragments

2012-01-12 Thread Simon Perreault
On 01/12/2012 03:39 AM, Fernando Gont wrote: Do we want this in our stack although it is not an RFC yet? Or perhaps only in pf for extra security? I should note that an RFC can take at least a year to publish (if ever). We should not wait for an RFC. We should wait for a consensus to emerge.

Re: ix: fixup hardware vlan tagging and stripping

2012-01-12 Thread Mike Belopuhov
Hi, If there's no objections, I'm going to commit it soon. Thanks On Tue, Dec 20, 2011 at 15:30 +0100, Mike Belopuhov wrote: > hi, > > hardware vlan tagging/stripping got broken with the driver update. > freebsd people have changed the code to handle events from the vlan(4) > pseudo-device into

Re: handle overlapping IPv6 fragments

2012-01-12 Thread Fernando Gont
On 01/11/2012 12:16 AM, Alexander Bluhm wrote: > On Tue, Jan 10, 2012 at 07:51:03PM -0300, Fernando Gont wrote: >> On 01/10/2012 01:20 PM, Alexander Bluhm wrote: >>> Implement RFC 5722 and drop all IPv6 fragments that belong to a >>> packet with overlapping fragments. >> >> FWIW, you may be interes

Re: overlapping IPv6 fragments in pf

2012-01-12 Thread Fernando Gont
On 01/12/2012 12:03 AM, Alexander Bluhm wrote: > Drop overlapping IPv6 fragments in pf reassembly code. RFC 5722 > is demanding that. Our stack does that already. > > The text "constituent fragments, including those not yet received, > MUST be discarded" does not make clear, how long to do that.