Re: ix: no reason to enable interrupts that we don't know how to handle

2011-12-08 Thread Mark Kettenis
> Date: Thu, 8 Dec 2011 18:08:02 +0100 > From: Mike Belopuhov > > we don't do intel i/oat and don't set up parameters for the > tcp timer interrupts, therefore there's no reason we should > enable the interrupt itself. > > ok? Defenitely! ok kettenis@ > diff --git dev/pci/ixgbe_type.h dev/pc

Re: ssh, extern cleanup

2011-12-08 Thread Mike Belopuhov
On Thu, Dec 8, 2011 at 7:25 PM, Aaron Stellman wrote: > Hello there, > > Is there any good reason why most of .c files need to have externs for > ServerOptions/Options? Any reason not to have them in appropriate header > files? > hi, patches for portable openssh should go to the portable openssh

ssh, extern cleanup

2011-12-08 Thread Aaron Stellman
Hello there, Is there any good reason why most of .c files need to have externs for ServerOptions/Options? Any reason not to have them in appropriate header files? Index: auth-chall.c === RCS file: /cvs/openssh/auth-chall.c,v retriev

Re: ix: don't forget to m_freem stuff in the error paths

2011-12-08 Thread Mike Belopuhov
On Thu, Dec 08, 2011 at 17:46 +0100, Mike Belopuhov wrote: > there are some m_freem's missing in the error code paths. > i guess that's because freebsd code is a bit different > and we didn't look closely at it. > > ok? > > @@ -2601,6 +2604,8 @@ no_split: > error = bus_dmamap_load_mbuf(rxr-

Re: ix: improve performance

2011-12-08 Thread Mike Belopuhov
On Fri, Nov 25, 2011 at 15:02 +0100, Mike Belopuhov wrote: > hi, > > i've spent a week trying to fix performance regression in ix(4) > since the introduction of the new driver and this is where i'm > right now. with the following change machine is able to sustain > 760kpps and reach 9Gbit/s of fo

Re: ix: no need to rearm interrupts, we only need to reenable queues

2011-12-08 Thread Mike Belopuhov
On Sun, Nov 27, 2011 at 11:26 +0100, Mike Belopuhov wrote: > On Sun, Nov 27, 2011 at 8:58 AM, Claudio Jeker wrote: > > On Fri, Nov 25, 2011 at 02:43:38PM +0100, Mike Belopuhov wrote: > >> shaves off some bus read/write operations. > >> tested on 82598 and 82599. ok? > > > > On what information is

ix: no reason to enable interrupts that we don't know how to handle

2011-12-08 Thread Mike Belopuhov
we don't do intel i/oat and don't set up parameters for the tcp timer interrupts, therefore there's no reason we should enable the interrupt itself. ok? diff --git dev/pci/ixgbe_type.h dev/pci/ixgbe_type.h index 601c6d5..b59 100644 --- dev/pci/ixgbe_type.h +++ dev/pci/ixgbe_type.h @@ -1318,7

ix: schedule an rxrefill callout correctly

2011-12-08 Thread Mike Belopuhov
we need to always schedule another rx ring refill callout in case we fail to do it at the spot. previously what would happen is that say we have 2 clusters on the rx ring and we schedule an rxrefill callout that fails to update the ring. then we still have those 2 clusters around. under heavy loa

ix: don't forget to m_freem stuff in the error paths

2011-12-08 Thread Mike Belopuhov
there are some m_freem's missing in the error code paths. i guess that's because freebsd code is a bit different and we didn't look closely at it. ok? diff --git dev/pci/if_ix.c dev/pci/if_ix.c index 4468401..8ab83f8 100644 --- dev/pci/if_ix.c +++ dev/pci/if_ix.c @@ -2547,7 +2547,7 @@ ixgbe_get_b

Girl Guide Update

2011-12-08 Thread black74hat
Hi, We would like to see you in Escort Girl Guide directory. Please visit http://escortsagency.ch to review our directory. Registration is fast and easy: http://escortsagency.ch/register.html Please do not hesitate to contact us if you have any questions. Best Regards Escorts Agency Team UN