Re: pthread_key_delete doesn't reset values

2011-07-02 Thread Federico Schwindt
you should only do that if key is valid, not always. also specific_data might be NULL. i don't think this is correct. On Sat, Jul 2, 2011 at 4:53 PM, Mike Belopuhov wrote: > On Sat, Jul 02, 2011 at 11:04 -0400, Ted Unangst wrote: >> On Mon, Jun 27, 2011, Henry Precheur wrote: >> > According to pt

Re: libpthread: don't context switch to yourself

2011-07-02 Thread Marco S Hyman
On Jul 2, 2011, at 3:06 PM, Philip Guenther wrote: > In libpthread, if the scheduler picks the current thread as the next to > run, it still does the full save+restore of errno, FPU, and regs, saving > them and then restoring the same values again. That's kinda silly, so > jump around that if

make amd64 return-to-user and sigreturn faster

2011-07-02 Thread Philip Guenther
First, expand the INTR_RESTORE_GPRS macro and then rearrange the register restores around the INTR_RESTORE_SELECTORS macro to minimize how long interupts are blocked. This also lets us eliminate all the adjusting of the stack pointer except for the necessary one on the iretq path. Instead of h

Re: BSD Authentication for popa3d(8)

2011-07-02 Thread Nicholas Marriott
Hi I don't think you need to strsep out the style yourself, a NULL style to auth_userokay will look for it after a : itself. Otherwise this reads fine to me. On Mon, Jun 27, 2011 at 07:30:53PM +0200, Nils Anspach wrote: > Hello list, > > attached is a patch for popa3d(8) to use BSD authenticat

libpthread: don't context switch to yourself

2011-07-02 Thread Philip Guenther
In libpthread, if the scheduler picks the current thread as the next to run, it still does the full save+restore of errno, FPU, and regs, saving them and then restoring the same values again. That's kinda silly, so jump around that if switching to the current thread. oks? Philip Guenther In

Fix/simplify physio() error path handling

2011-07-02 Thread Matthew Dempsky
In physio(), the after_unlock code assumes that b_resid is valid, but that value is only assigned if we actually call (*strategy)(), which doesn't happen if uvm_vslock_device() fails. None of that error handling code is actually needed if uvm_vslock_device() fails, so just break out of the loop in

Re: Testers needed for ahc(4) diff

2011-07-02 Thread Matthew Dempsky
Last call for preemptive testers, otherwise ahc(4) users will get to test it in tree! :) On Mon, Jun 27, 2011 at 10:52:40PM -0700, Matthew Dempsky wrote: > On Thu, Jun 23, 2011 at 11:33:53AM -0700, Matthew Dempsky wrote: > > Diff below cleans up ahc(4) to use scsi_link::bus instead of > > (mis)usi

Re: correct definition of NULL

2011-07-02 Thread Philip Guenther
On Sat, Jul 2, 2011 at 3:33 AM, Dunceor wrote: ... > Is there a reason for that NULL is defined at so many places? Because the standards say so. If the code to do so grows complicated enough (it's close already, IMHO) then perhaps that definition should be moved to an internal header (say, <_nul

more pthread_getspecific fixes

2011-07-02 Thread Ted Unangst
1. check that they key is not less than 0. 2. we can simplify several of the if/else chains. Index: uthread/uthread_spec.c === RCS file: /cvs/src/lib/libpthread/uthread/uthread_spec.c,v retrieving revision 1.10 diff -u -r1.10 uthrea

Nuevo traductor 2011

2011-07-02 Thread Traductor
NUEVO PACK DE TRADUCCION INGLES ESPAQOL ESPAQOL -INGLES 2011 En un CD todas las herramientas premium para traduccisn.Diseqadas para abordar cualquier tipo de necesidad y cualquier tipo de usuario Incluye Traductor interactivo traduce palabras ,permite importar traducir y exportar textos completo

Re: hostid 64-bit support

2011-07-02 Thread Ted Unangst
On Fri, Jul 01, 2011, Ted Unangst wrote: > hostid is a long, and that ship has sailed, but still 64-bit archs should > not truncate the value. > > I would like somebody to test this on a 64-bit machine. Even try > setting a 64-bit hostid maybe. never mind about this, it's a waste of time.

Re: pthread_key_delete doesn't reset values

2011-07-02 Thread Mike Belopuhov
On Sat, Jul 02, 2011 at 11:04 -0400, Ted Unangst wrote: > On Mon, Jun 27, 2011, Henry Precheur wrote: > > According to pthread_key_create(3): Upon key creation, the value NULL is > > associated with the new key in all active threads. > > > > > > When pthread_key_create reuse an existing key, the

fix rthread specific data

2011-07-02 Thread Ted Unangst
Fix is similar to libpthread. Also, use the spinlock and verify that key has a valid value, the implementation is too flexible right now. (I realize now that libpthread should also check for key < 0, I'll have to go back and fix that too.) Index: rthread_tls.c ===

Re: pthread_key_delete doesn't reset values

2011-07-02 Thread Ted Unangst
On Mon, Jun 27, 2011, Henry Precheur wrote: > According to pthread_key_create(3): Upon key creation, the value NULL is > associated with the new key in all active threads. > > > When pthread_key_create reuse an existing key, the old value is still > here, which can create problems. The following

Re: correct definition of NULL

2011-07-02 Thread Dunceor
On Sat, Jul 2, 2011 at 11:16 AM, Jonathan Gray wrote: > As pointed out by Richard Guenther our definition > of NULL will be incorrect for c++ compilers that aren't > gcc (or pretend to be gcc like clang). > > Index: dirent.h > === > R

correct definition of NULL

2011-07-02 Thread Jonathan Gray
As pointed out by Richard Guenther our definition of NULL will be incorrect for c++ compilers that aren't gcc (or pretend to be gcc like clang). Index: dirent.h === RCS file: /cvs/src/include/dirent.h,v retrieving revision 1.21 diff -