Re: pool_debug is good, but also bad

2011-04-03 Thread Damien Miller
On Sun, 3 Apr 2011, Theo de Raadt wrote: > based on a conversation at the bar. > > POOL_DEBUG is expensive. But we really want it because it finds bugs > before they hurt us. The solution to this is to make it simpler to > turn off. Is it expensive because it tests every pool entry? Could it be

Re: clarify bgpd err msg

2011-04-03 Thread Zamri Besar
On Mon, Apr 4, 2011 at 6:39 AM, Henning Brauer wrote: > - fatalx("Uh, oh a politician in the decision process"); > + fatalx("Merkel\'d"); >/* NOTREACHED */ > } > > Lol, is it April Fool? -- Thank you. Zamri Besar

pool_debug is good, but also bad

2011-04-03 Thread Theo de Raadt
based on a conversation at the bar. POOL_DEBUG is expensive. But we really want it because it finds bugs before they hurt us. The solution to this is to make it simpler to turn off. This diff starts the kernel with pool debug on, but allows it to be turned off with sysctl kern.pool_debug=0. Thi

Re: clarify bgpd err msg

2011-04-03 Thread olli hauer
On 2011-04-04 00:39, Henning Brauer wrote: > Index: rde_decide.c > === > RCS file: /cvs/src/usr.sbin/bgpd/rde_decide.c,v > retrieving revision 1.60 > diff -u -p -r1.60 rde_decide.c > --- rde_decide.c 3 May 2010 13:09:38 -

softraid iopoolification

2011-04-03 Thread Kenneth R Westerback
Works on my crypto volume. People with other volume types would be nice to hear from. Ken Index: softraid.c === RCS file: /cvs/src/sys/dev/softraid.c,v retrieving revision 1.222 diff -u -p -r1.222 softraid.c --- softraid.c 15 M

Re: wcwidth() fix in libform

2011-04-03 Thread Nicholas Marriott
Again so it is a cchar_t so I'm not sure it is valid for it to be nonprintable but this doesn't do any harm. Might want to run this stuff past upstream first though? It is better if we stay in sync if they do want to take it. On Sun, Apr 03, 2011 at 11:51:53PM +0200, Stefan Sperling wrote: > Som

clarify bgpd err msg

2011-04-03 Thread Henning Brauer
Index: rde_decide.c === RCS file: /cvs/src/usr.sbin/bgpd/rde_decide.c,v retrieving revision 1.60 diff -u -p -r1.60 rde_decide.c --- rde_decide.c3 May 2010 13:09:38 - 1.60 +++ rde_decide.c3 Apr 2011 22:39:19 -0

Re: wcswidth fix and man page

2011-04-03 Thread Nicholas Marriott
Works for me, ok nicm On Sun, Apr 03, 2011 at 08:49:15PM +0200, Stefan Sperling wrote: > Add a wcswidth man page (based on FreeBSD), and fix the implementation > to return -1 in case of an unprintable character. > > Index: string/Makefile.inc > ===

Re: wcwidth() fixes in libedit

2011-04-03 Thread Nicholas Marriott
Hi We don't currently build a wide char libedit but comments inline: On Sun, Apr 03, 2011 at 11:46:24PM +0200, Stefan Sperling wrote: > These callers in libedit might get confused if wcwidth() returns -1. > > Note how the result ct_visual_width() is used in refresh.c: > > refresh.c:

Re: wcwidth() fixes in libcurses

2011-04-03 Thread Nicholas Marriott
Hi On Sun, Apr 03, 2011 at 11:34:54PM +0200, Stefan Sperling wrote: > The upcoming diff to make wcwidth() return -1 for non-printable > characters might have funny effects for these callers in libcurses. > > Index: base/lib_addstr.c > ==

Re: relax gcc -Wsentinel checking

2011-04-03 Thread Miod Vallat
> Not really ok. Given the way the ISO C standard is formulated, not > casting NULL in this case is a genuine bug. > > One can argue though, that defining NULL in such a way that it is not > usable as a sentinel value would be really really silly, and that it > is not our job to catch missing cas

wcwidth() fix in file(1)

2011-04-03 Thread Stefan Sperling
Make the file_mbswidth() function cope if wcwidth() returns -1. Maybe this should just call wcswidth() but I'll leave that for another day. Index: file.c === RCS file: /cvs/src/usr.bin/file/file.c,v retrieving revision 1.22 diff -u -

wcwidth() fix in libform

2011-04-03 Thread Stefan Sperling
Some callers of myWCWIDTH(), a macro alias for cell_width(), won't cope with -1. Index: frm_driver.c === RCS file: /cvs/src/lib/libform/frm_driver.c,v retrieving revision 1.10 diff -u -p -r1.10 frm_driver.c --- frm_driver.c18

Re: Radeon HD3000

2011-04-03 Thread Pedro la Peu
Indeed, thanks Brad. Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1592 diff -u -p -r1.1592 pcidevs --- sys/dev/pci/pcidevs 23 Mar 2011 21:55:09 - 1.1592 +++ sys/dev/pci/pcidevs

wcwidth() fixes in libedit

2011-04-03 Thread Stefan Sperling
These callers in libedit might get confused if wcwidth() returns -1. Note how the result ct_visual_width() is used in refresh.c: refresh.c: h += ct_visual_width(*cp); Index: chartype.c === RCS file: /cvs/src/li

wcwidth() fixes in libcurses

2011-04-03 Thread Stefan Sperling
The upcoming diff to make wcwidth() return -1 for non-printable characters might have funny effects for these callers in libcurses. Index: base/lib_addstr.c === RCS file: /cvs/src/lib/libcurses/base/lib_addstr.c,v retrieving revision

Re: Radeon HD3000

2011-04-03 Thread Brad
On 03/04/11 5:06 PM, Pedro la Peu wrote: Index: sys/dev/pci/drm/radeon_drv.c === RCS file: /cvs/src/sys/dev/pci/drm/radeon_drv.c,v retrieving revision 1.51 diff -u -p -r1.51 radeon_drv.c --- sys/dev/pci/drm/radeon_drv.c29 Sep

Radeon HD3000

2011-04-03 Thread Pedro la Peu
Hi. Add Radeon HD 3000 to pcidevs and radeon_drv.c. Tested and works fine with xenocara from 24/3/11 snapshot. Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1592 diff -u -p -r1.1592 pc

Re: resurect and fix bce(4)

2011-04-03 Thread Mark Kettenis
> From: David Gwynne > Date: Mon, 4 Apr 2011 05:59:20 +1000 > > On 04/04/2011, at 5:31 AM, Mark Kettenis wrote: > > >> Date: Sun, 3 Apr 2011 13:46:40 +0200 > >> From: Claudio Jeker > >> > >> bce(4) was turned off because of limitations in the DMA engine that allows > >> the chip to access only

Re: ahci big mem friendlification

2011-04-03 Thread Mark Kettenis
> Date: Sun, 3 Apr 2011 09:38:44 -0400 > From: Kenneth R Westerback > > Another allocation/memory use made big mem friendly. Sorry, but this should really use bus_dmamem_alloc(). > Index: ahci.c > === > RCS file: /cvs/src/sys/dev/p

Re: add wcwidth man page

2011-04-03 Thread Nicholas Marriott
Works for me, ok nicm On Sun, Apr 03, 2011 at 08:34:48PM +0200, Stefan Sperling wrote: > On Sun, Apr 03, 2011 at 07:25:45PM +0100, Nicholas Marriott wrote: > > Do we normally have a LIBRARY section? > > > > mdoc(7) says no, good catch. > > .\" .Sh LIBRARY > .\" For sections 2

Re: resurect and fix bce(4)

2011-04-03 Thread David Gwynne
On 04/04/2011, at 5:31 AM, Mark Kettenis wrote: >> Date: Sun, 3 Apr 2011 13:46:40 +0200 >> From: Claudio Jeker >> >> bce(4) was turned off because of limitations in the DMA engine that allows >> the chip to access only 1G of memory. On systems with more then 1G of >> memory hilarity ensued. >>

[PATCH] fixes wrong battery type unit

2011-04-03 Thread Matthias Guedemann
Hi, this patch fixes wrong power unit reporting when booting without battery and inserting the battery later on Asus EEE 901 and Samsung N220 on i386. Both normally report amphour, but sensors gets fixed to watthour when booting without battery. When type change is detected on battery event, this

Re: Radeon HD5450

2011-04-03 Thread Nigel Taylor
Hi, I did some tests of latest ATI drivers, v6.13.2+patches, v6.14.0, v6.14.1 ati/radeon driver using zaphod mode with what hardware I have available. I am using OpenBSD current amd64 in all cases. Samsung R780 laptop which has a ATI HD 5470 (CEDAR chip), zaphod dual head, and triple head worked

Re: resurect and fix bce(4)

2011-04-03 Thread Mark Kettenis
> Date: Sun, 3 Apr 2011 13:46:40 +0200 > From: Claudio Jeker > > bce(4) was turned off because of limitations in the DMA engine that allows > the chip to access only 1G of memory. On systems with more then 1G of > memory hilarity ensued. > > Now I rewrote the driver to use bcopy() to copy the mb

wcswidth fix and man page

2011-04-03 Thread Stefan Sperling
Add a wcswidth man page (based on FreeBSD), and fix the implementation to return -1 in case of an unprintable character. Index: string/Makefile.inc === RCS file: /cvs/src/lib/libc/string/Makefile.inc,v retrieving revision 1.23 diff -u

Re: add wcwidth man page

2011-04-03 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 07:25:45PM +0100, Nicholas Marriott wrote: > Do we normally have a LIBRARY section? > mdoc(7) says no, good catch. .\" .Sh LIBRARY .\" For sections 2, 3, & 9 only. .\" Not used in OpenBSD. > Also $OpenBSD$ would be better at the start. F

Re: add wcwidth man page

2011-04-03 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 04:31:50PM +0200, Stefan Sperling wrote: > Based on man page from FreeBSD with some tweaks: > - use $OpenBSD$, $Mdocdate$ > - removed trivial example code > - removed quotes around .Nd arg > > I'd put in into lib/libc/locale along with the other locale-related > man page

Re: add wcwidth man page

2011-04-03 Thread Nicholas Marriott
Do we normally have a LIBRARY section? Also $OpenBSD$ would be better at the start. Otherwise reads good to me. On Sun, Apr 03, 2011 at 04:31:50PM +0200, Stefan Sperling wrote: > Based on man page from FreeBSD with some tweaks: > - use $OpenBSD$, $Mdocdate$ > - removed trivial example code >

Re: fix display glitches with hexdump -C and tcpdump -X in UTF-8 locale

2011-04-03 Thread Nicholas Marriott
Hi These look fine to me. On Sun, Apr 03, 2011 at 03:57:40PM +0200, Stefan Sperling wrote: > On Sat, Mar 05, 2011 at 01:45:40AM +0100, Stefan Sperling wrote: > > There are some display glitches when the UTF-8 locale is used. > > So far I know about hexdump -C (reported by naddy) and tcpdump -X.

Re: kill loopback link1 wankery

2011-04-03 Thread Henning Brauer
* Alexander Bluhm [2011-04-03 19:38]: > On Sat, Apr 02, 2011 at 02:49:09PM +0200, Henning Brauer wrote: > > lo has that link1 wankery where it kind of replies to all addresses in > > the subnet, except that it doesn't really - it is very halfbaked and > > gets in the way. unless somebody has a VER

Re: kill loopback link1 wankery

2011-04-03 Thread Alexander Bluhm
On Sat, Apr 02, 2011 at 02:49:09PM +0200, Henning Brauer wrote: > lo has that link1 wankery where it kind of replies to all addresses in > the subnet, except that it doesn't really - it is very halfbaked and > gets in the way. unless somebody has a VERY convincing reason to keep > this it'll be gon

bridge ip chsum handling

2011-04-03 Thread Henning Brauer
so we have to special case the bridge in teh stack because it doesn't behave wrt ip checksums (yes yes, all hail layer violations). so make the bridge behave by always peeking into the ip header, and not just when we have a kernel with pf compiled in (aka no change really) and apply the same cksum

Re: fast local address lookup in ip_input

2011-04-03 Thread Henning Brauer
same here, please help by testing so i can go on * Henning Brauer [2011-04-02 17:39]: > so now that the loopback link1 crap is out of the way - use the rb > tree for local address lookup in ip_input instead of traversing the > list of interfaces traversing the list of addresses on them linearily.

Re: pf and the ip checksum

2011-04-03 Thread Henning Brauer
please help me get this in quick-ish by testing so that i can go on... * Henning Brauer [2011-04-02 16:35]: > pf keep updating the dreaded ip checksum. which is entirely pointless > (except the quoted ip packet and its csum inside an icmp err) since we > uncondtionally recalculate the checksum an

avoiding races with timeout_del()

2011-04-03 Thread David Gwynne
there is an expectation that if you timeout_del the timeout will not run. however, it doesnt prevent it from being about to run, or from running on another cpu at the same time as you're doing the timeout_del. you can check if the timeout ran with timeout_triggered, but that can race unless you are

Re: ahci big mem friendlification

2011-04-03 Thread David Gwynne
ok On 04/04/2011, at 1:41 AM, Kenneth R Westerback wrote: > On Sun, Apr 03, 2011 at 09:38:44AM -0400, Kenneth R Westerback wrote: >> Another allocation/memory use made big mem friendly. >> >> Ken > > Try to avoid allocating memory in interrupt context, as pointed out > by dlg@. > > K

Re: ahci big mem friendlification

2011-04-03 Thread Kenneth R Westerback
On Sun, Apr 03, 2011 at 09:38:44AM -0400, Kenneth R Westerback wrote: > Another allocation/memory use made big mem friendly. > > Ken Try to avoid allocating memory in interrupt context, as pointed out by dlg@. Ken Index: ahci.c =

Re: clean up buf flags

2011-04-03 Thread Owain G. ainsworth
- Original message - > > This cleans up the buffer flags so we can add a few later without > going stupid. i'm sure i already oked this as part of the larger diff (specifically this bit). So ok. > > Index: sys/buf.h > ===

Re: missing function definition uvm_pmemrange.c

2011-04-03 Thread Philip Guenther
On Fri, Jul 16, 2010 at 12:41 PM, Fred Crowson wrote: > While trying to build a debug ramdisk kernel - I came across a build error > in uvm_pmemrange.c where the function uvm_pmr_isfree was not defined, I've > added it to #ifdef not sure if this is the correct process or whether it > needs its own

dont lose printfs in ddb to xconsole.

2011-04-03 Thread Dale Rahn
If xconsole is running (or xterm -C), if ddb is entered, the kernel printf output will be queued for xconsole to print out, however if one is on the text VT, it output appears to be missing. This stores the fact that we have entered ddb and in that case it acts as if xconsole is not running. howev

Re: ahci big mem friendlification

2011-04-03 Thread David Gwynne
ahci_port_read_ncq_error is used from interrupt context, so you either have to preallocate it during port attach (hi kettenis!) or fix your flags. dlg On 03/04/2011, at 11:38 PM, Kenneth R Westerback wrote: > Another allocation/memory use made big mem friendly. > > Ken > > Index: ahci.c > =

ahci big mem friendlification

2011-04-03 Thread Kenneth R Westerback
Another allocation/memory use made big mem friendly. Ken Index: ahci.c === RCS file: /cvs/src/sys/dev/pci/ahci.c,v retrieving revision 1.172 diff -u -p -r1.172 ahci.c --- ahci.c 28 Jan 2011 06:32:31 - 1.172 +++ ahc

Re: Radeon HD5450

2011-04-03 Thread Mark Peoples
On Sun, Apr 03, 2011 at 04:08:49PM +0200, Matthieu Herrb wrote: > On Sun, Apr 03, 2011 at 08:37:08AM -0400, Mark Peoples wrote: > > The following along with an update to xf86-video-ati-6.14.1 gets me some > > very sexy 1920x1080 on my Radeon HD5450 > > > > xrandr(1) hangs (no mouse movement, etc)

add wcwidth man page

2011-04-03 Thread Stefan Sperling
Based on man page from FreeBSD with some tweaks: - use $OpenBSD$, $Mdocdate$ - removed trivial example code - removed quotes around .Nd arg I'd put in into lib/libc/locale along with the other locale-related man pages. ok? Index: wcwidth.3 =

iopools for twe(4)

2011-04-03 Thread David Gwynne
if you have a twe, let me first say how sorry i am for you. this cuts twe over to using iopools. it gets the usual benefits of more reliable ioctl paths, better io scheduling between volumes and the pt busses, and a removal of NO_CCB. it is a bit more than a straight conversion, it also moves the

Re: nvi diff fixing a display glitch leading to crash

2011-04-03 Thread Martynas Venckus
> Delivered-To: marty...@venck.us > Received: by 10.100.125.2 with SMTP id x2cs7548anc; > Wed, 8 Dec 2010 00:00:53 -0800 (PST) > Received: by 10.231.32.197 with SMTP id e5mr738073ibd.188.1291795252925; > Wed, 08 Dec 2010 00:00:52 -0800 (PST) > Return-Path: > Received: from shear.uc

fix wcwidth (was: Re: ls(1) multibyte support)

2011-04-03 Thread Stefan Sperling
On Thu, Jan 06, 2011 at 07:52:19PM +0300, Alexander Polakov wrote: > * Alexander Polakov [110105 17:20]: > > Hi, > > > > here's an updated version. > > > > 1) en_US.UTF-8.src updates from FreeBSD > > 2) wcwidth() changed to use the same code as iswprint() > >* maybe just use iswprint() itsel

Re: Radeon HD5450

2011-04-03 Thread Matthieu Herrb
On Sun, Apr 03, 2011 at 08:37:08AM -0400, Mark Peoples wrote: > The following along with an update to xf86-video-ati-6.14.1 gets me some very > sexy 1920x1080 on my Radeon HD5450 > > xrandr(1) hangs (no mouse movement, etc) when running. also, i have > some weird pixel activity, but it's still se

Re: fix display glitches with hexdump -C and tcpdump -X in UTF-8 locale

2011-04-03 Thread Stefan Sperling
On Sat, Mar 05, 2011 at 01:45:40AM +0100, Stefan Sperling wrote: > There are some display glitches when the UTF-8 locale is used. > So far I know about hexdump -C (reported by naddy) and tcpdump -X. > Both print invalid UTF-8 to the screen. > > The problem is that latin1 characters end up being pr

clean up buf flags

2011-04-03 Thread Bob Beck
This cleans up the buffer flags so we can add a few later without going stupid. Index: sys/buf.h === RCS file: /cvs/src/sys/sys/buf.h,v retrieving revision 1.74 diff -u -r1.74 buf.h --- sys/buf.h 22 Sep 2010 01:18:57 - 1.74

...excelencia que trasciende los espacios

2011-04-03 Thread SQL Muebles de cocina
[IMAGE] [IMAGE] [IMAGE] SQL AMOBLAMIENTOS Somos una empresa dedicada a la fabricacisn de amoblamientos para el hogar, tendiente a la calidad, la innovacisn en diseqo y estilo de vida de nuestros clientes. El compromiso y nuestra lealtad con el cliente son nuestros valores fundamentales. Contamo

Radeon HD5450

2011-04-03 Thread Mark Peoples
The following along with an update to xf86-video-ati-6.14.1 gets me some very sexy 1920x1080 on my Radeon HD5450 xrandr(1) hangs (no mouse movement, etc) when running. also, i have some weird pixel activity, but it's still sexy i5.peoples$ xrandr

Unpaid invoices in Turkey?

2011-04-03 Thread DAT-Consultancy | Debt Collection Turkey
Unpaid invoices in Turkey? Published March 2011 debt collection in Turkey DAT-Consultancy is the first debt collection agency for both pre-legal and legal collections in Turkey. We are working on commission basis which you only pay if we are successful. Debt Collection has always been mainly

Re: horribly slow fsck_ffs pass1 performance

2011-04-03 Thread Andres Perera
On Sun, Apr 3, 2011 at 4:21 AM, Janne Johansson wrote: > 2011/4/2 Benny Lofgren > >> >> I've noticed that some (all?) linux systems do uncalled-for file system >> checks at boot if no check have been made recently, but I've never >> understood this practice. It must mean they don't trust their ow

Dump stupid dhclient script uses/phases

2011-04-03 Thread Kenneth R Westerback
Resolved, that 1) dhclient(8) forces the interface link up with interface_link_forceup(). Why call the script with PREINIT to call 'ifconfig up'? 2) ALIAS declarations in dhclient.conf were/are an experimental feature. Mixing dhclient and 'manual' info is incoherent, dangerous and unreliable. 3

pf: allow "pass in on rdomain 1"

2011-04-03 Thread Claudio Jeker
It is hard to limit pf rules to specific rdomains. This diff extends the syntax so that it is possible to specify an rdomain on pass and block rules similar to the way a interface is specified. So it is possible to write now rules like: block in on rdomain 0 or a bit more complex: pass out on rdoma

iopools for ips(4)

2011-04-03 Thread David Gwynne
this cuts ips over to using iopools. it gets the usual benefits of more reliable ioctl paths, better io scheduling between volumes and the pt busses, and a removal of NO_CCB. i dont have an ips, so i cant test this. id like more than an ok from gcc before committing this. Index: ips.c ===

resurect and fix bce(4)

2011-04-03 Thread Claudio Jeker
bce(4) was turned off because of limitations in the DMA engine that allows the chip to access only 1G of memory. On systems with more then 1G of memory hilarity ensued. Now I rewrote the driver to use bcopy() to copy the mbufs into a savely allocated DMA memory buffer. So the chip will now work wi

Re: horribly slow fsck_ffs pass1 performance

2011-04-03 Thread Janne Johansson
2011/4/2 Benny Lofgren > > I've noticed that some (all?) linux systems do uncalled-for file system > checks at boot if no check have been made recently, but I've never > understood this practice. It must mean they don't trust their own file > systems, > I'm quite sure this comes from the fact th