Re: fix crontab(1) NULL pointer dereference

2011-02-05 Thread Philip Guenther
On Sat, 5 Feb 2011, Lawrence Teo wrote: > When "crontab -l" is used to list a user's crontab file, crontab(1) > expects the crontab file to have three comment lines at the top. > > However, if there are fewer than three comment lines or if they are > completely absent, crontab(1) will segfault whe

How To Build Muscle and Gain Weight Fast

2011-02-05 Thread Muscle Building
who can't build muscle or gain weight no matter how hard they try. Take just five minutes to read this entire page and you'll discover. Start Now : http://good-links.us/how-to-build-muscle-and-gain-weight-fast.html

httpd(8) - allow location of etag-state to be configured

2011-02-05 Thread Dan Harnett
This allows the location of the etag-state file to be configured in httpd.conf rather than hardcoded to "logs/etag-state". Index: conf/httpd.conf === RCS file: /home/danh/.cvs/openbsd/src/usr.sbin/httpd/conf/httpd.conf,v retrieving re

Re: incorrect fallthrough in pf

2011-02-05 Thread Alexander Bluhm
On Sat, Feb 05, 2011 at 07:51:27PM +0100, Henning Brauer wrote: > indeed. and as much as i'm all for defensive programming, pf_test_rule > will never be called from anything but pf_test[6] - at least without > heavy heavy major super duper changes, besides there not being a reson > to. thus: I che

Re: ksh completion for [, :, $

2011-02-05 Thread Nick Guenther
On Fri, Feb 4, 2011 at 1:42 PM, Alexander Polakov wrote: > Hi there, > > I sent this diff to bugs@ some time ago but haven't got any replies. > Probably tech@ is a better place for it. > > The problem is known as bz#6006/user. > > The fix is taken from mksh (rev.1.4 for [ and rev.1.184 for others)

Re: fix crontab(1) NULL pointer dereference

2011-02-05 Thread Lawrence Teo
On Sat, Feb 05, 2011 at 02:48:54PM -0500, Lawrence Teo wrote: > When "crontab -l" is used to list a user's crontab file, crontab(1) > expects the crontab file to have three comment lines at the top. > > However, if there are fewer than three comment lines or if they are > completely absent, cronta

fix crontab(1) NULL pointer dereference

2011-02-05 Thread Lawrence Teo
When "crontab -l" is used to list a user's crontab file, crontab(1) expects the crontab file to have three comment lines at the top. However, if there are fewer than three comment lines or if they are completely absent, crontab(1) will segfault when the ignore_comments() function tries to use putc

Re: incorrect fallthrough in pf

2011-02-05 Thread Henning Brauer
* Alexander Bluhm [2011-02-05 19:02]: > On Sat, Feb 05, 2011 at 03:24:11PM +0100, Henning Brauer wrote: > > I'm pretty damn sure we catch that way earlier. > > You are right. > > pf_test(): > case IPPROTO_ICMPV6: { > action = PF_DROP; > DPFPRINTF(LOG_NOTIC

Re: incorrect fallthrough in pf

2011-02-05 Thread Alexander Bluhm
On Sat, Feb 05, 2011 at 03:24:11PM +0100, Henning Brauer wrote: > I'm pretty damn sure we catch that way earlier. You are right. pf_test(): case IPPROTO_ICMPV6: { action = PF_DROP; DPFPRINTF(LOG_NOTICE, "dropping IPv4 packet with ICMPv6

Re: incorrect fallthrough in pf

2011-02-05 Thread Alexander Bluhm
On Sat, Feb 05, 2011 at 03:24:11PM +0100, Henning Brauer wrote: > * Alexander Bluhm [2011-02-05 14:56]: > > Somebody could send us such a packet. > > I'm pretty damn sure we catch that way earlier. Yeah, it panics right away if nat/rdr is used with unusual protocol. panic: m_clget: request for

Re: incorrect fallthrough in pf

2011-02-05 Thread Mike Belopuhov
On Sat, Feb 5, 2011 at 2:54 PM, Alexander Bluhm wrote: > On Sat, Feb 05, 2011 at 02:03:25PM +0100, Mike Belopuhov wrote: >> we can check if "af == inet" in icmp case obviously, but how and why >> can we end up with af == inet6 and an icmp payload (or af == inet >> and icmp6 payload for that matter

Re: incorrect fallthrough in pf

2011-02-05 Thread Henning Brauer
* Alexander Bluhm [2011-02-05 14:56]: > On Sat, Feb 05, 2011 at 02:03:25PM +0100, Mike Belopuhov wrote: > > we can check if "af == inet" in icmp case obviously, but how and why > > can we end up with af == inet6 and an icmp payload (or af == inet > > and icmp6 payload for that matter)? > > Somebo

Re: incorrect fallthrough in pf

2011-02-05 Thread Mike Belopuhov
On Sat, Feb 5, 2011 at 1:50 PM, Alexander Bluhm wrote: > I think there is a missing check and fallthrough in the icmp case. > > The logic should be > > if (proto == tcp) { > } else if (proto == udp) { > } else if (proto == icmp && af == inet) { > } else if (proto == icmp6 && af == inet6) { > } els

Re: incorrect fallthrough in pf

2011-02-05 Thread Alexander Bluhm
On Sat, Feb 05, 2011 at 02:03:25PM +0100, Mike Belopuhov wrote: > we can check if "af == inet" in icmp case obviously, but how and why > can we end up with af == inet6 and an icmp payload (or af == inet > and icmp6 payload for that matter)? Somebody could send us such a packet. It is strange but

Re: incorrect fallthrough in pf

2011-02-05 Thread Alexander Bluhm
On Wed, Feb 02, 2011 at 04:14:01PM +0100, Mike Belopuhov wrote: > hi, in pf_translate, when we're changing addresses for the icmp messages > there's an unjustified fallthrough in the IPPROTO_ICMPV6 case. in fact > this doesn't seem to harm anything because default case performs the > same operatio

Re: carp shutdown in /etc/rc

2011-02-05 Thread Camiel Dobbelaar
On 5-2-2011 11:02, Henning Brauer wrote: > on the other side, fixing "ifconfig very slow with lots of interfaces" > deserves to be fixed anyway. looking at the code - either getifaddrs is > slow (which in turn wouldn't be ifconfig only), or the ioctls ifconfig > does in getinfo(). that's "just" 5 t

Re: carp shutdown in /etc/rc

2011-02-05 Thread Henning Brauer
* Camiel Dobbelaar [2011-02-05 10:12]: > No, it's ifconfig itself that takes long. as said privately, i'd be surprised if it isn't the gazillion ioctls ifconfig does. > It does not scale linearly, but the real world usage (200) is fine. I > think we can drop the diff, since it turned out not to

Unlock your Wii todday!

2011-02-05 Thread lqiryujpje
Get the Wii UNLOCKER ULTRA GUIDE Complete with 5 High Definition Video Tutorials That take you by the hand until you unlock your Wii without losing your warranty. Plus you get five cool bonuses that take your Wii to a whole new level of entertainment. Here is what you can do with your Wii after yo

Re: carp shutdown in /etc/rc

2011-02-05 Thread Camiel Dobbelaar
On 5-2-2011 2:15, Ted Unangst wrote: > On Fri, Feb 4, 2011 at 7:21 AM, Camiel Dobbelaar wrote: >> With hundreds of (vlan) interfaces, a shutdown takes quite a while. >># bring carp interfaces down gracefully >> - ifconfig | while read a b; do >> + ifconf