amd64 MP: stop sending superfluous IPIs

2010-09-05 Thread Philip Guenther
The amd64 pmap keeps track of which cpu(s) a given pmap is in use on, so that when the pmap's page tables are modified it can send IPIs to the neccessary processors to have them invalidate those pages in their caches. Unfortunately, there are two bugs in this: 1) the bitmaps used to do that ar

WEAK_ALIAS for more (all?) platforms

2010-09-05 Thread Philip Guenther
A few of our platforms don't provide a WEAK_ALIAS macro in That's annoying for those of us who aren't ASM polyglots, so here's a diff to add WEAK_ALIAS to hppa, hppa64, mips64, and powerpc, based on how their libc SYS.h files handled them. The diff also converts said SYS.h files to use WEAK_A

Re: cut swap over to bufq

2010-09-05 Thread Bob Beck
> > Basically by saying you will prevent swap is that you will make a > situation > > where you ask for a page of memory and don't get it because you are > > suspending. > > Nothing the kernel needs to touch is swappable. by this point the > suspend process only needs kernel stuff, userland has don

Re: AES-GCM Part 3: isakmpd

2010-09-05 Thread Mike Belopuhov
On Sun, Sep 05, 2010 at 16:49 +, Christian Weisgerber wrote: > Mike Belopuhov wrote: > > > note that it defaults to AESGCM-256 (i did it this way because > > linux picks largest key). > > I don't understand that rationale. > > A side effect of this is that you now get different key sizes if

Re: AES-GCM Part 3: isakmpd

2010-09-05 Thread Christian Weisgerber
Mike Belopuhov wrote: > note that it defaults to AESGCM-256 (i did it this way because > linux picks largest key). I don't understand that rationale. A side effect of this is that you now get different key sizes if you specify "aes-gcm" in a manual SA (128) or an IKE rule (256). -- Christian

Re: cut swap over to bufq

2010-09-05 Thread Owain Ainsworth
On Sun, Sep 05, 2010 at 09:43:30AM -0600, Bob Beck wrote: > > Like owain said, things will get quiesced anyway. And why wouldn't want > > to quiesce swap i/o when suspending the machine. > > > > > You may not want to queisce swap if you are depending on it to get you pages > so you can finish sus

Re: cut swap over to bufq

2010-09-05 Thread Bob Beck
> Like owain said, things will get quiesced anyway. And why wouldn't want > to quiesce swap i/o when suspending the machine. > You may not want to queisce swap if you are depending on it to get you pages so you can finish suspending. Basically by saying you will prevent swap is that you will mak

Re: cut swap over to bufq

2010-09-05 Thread Thordur I Bjornsson
On Sun, Sep 05, 2010 at 04:39:33PM +0200, Mark Kettenis wrote: > > Date: Sun, 5 Sep 2010 14:07:03 + > > From: Thordur I Bjornsson > > > > On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > > > Hi gang, > > > > Gabriel Kihlman spotted a small problem, swd_active was no

Re: cut swap over to bufq

2010-09-05 Thread Thordur I Bjornsson
On Sun, Sep 05, 2010 at 03:57:58PM +0100, Owain Ainsworth wrote: > On Sun, Sep 05, 2010 at 02:07:03PM +, Thordur I Bjornsson wrote: > > On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > > > Hi gang, > > > > Gabriel Kihlman spotted a small problem, swd_active was not >

Re: cut swap over to bufq

2010-09-05 Thread Marco Peereboom
> > +/* Abuse bufq_fifo, for swapping to regular files. */ > > +struct bufq_swapreg { > > + SIMPLEQ_ENTRY(buf) bqf_entries; > > + struct workq_task bqf_wqtask; > > + > > +}; > > BIKESHED: Perhaps this should be: > > struct bufq_swapreg { > struct bufq_fifobfs_fifo; >

Re: cut swap over to bufq

2010-09-05 Thread Owain Ainsworth
On Sun, Sep 05, 2010 at 02:07:03PM +, Thordur I Bjornsson wrote: > On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > > Hi gang, > > Gabriel Kihlman spotted a small problem, swd_active was not > being incremented. > > Here's an updated diff. Looks alright to m

Re: cut swap over to bufq

2010-09-05 Thread Owain Ainsworth
On Sun, Sep 05, 2010 at 04:39:33PM +0200, Mark Kettenis wrote: > > Date: Sun, 5 Sep 2010 14:07:03 + > > From: Thordur I Bjornsson > > > > On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > > > Hi gang, > > > > Gabriel Kihlman spotted a small problem, swd_active was no

Re: cut swap over to bufq

2010-09-05 Thread Mark Kettenis
> Date: Sun, 5 Sep 2010 14:07:03 + > From: Thordur I Bjornsson > > On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > > Hi gang, > > Gabriel Kihlman spotted a small problem, swd_active was not > being incremented. > > Here's an updated diff. Hmm, bufq means

Re: cut swap over to bufq

2010-09-05 Thread Thordur I Bjornsson
On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: > Hi gang, Gabriel Kihlman spotted a small problem, swd_active was not being incremented. Here's an updated diff. Index: sys/buf.h === RCS file: /home/