Re: Add timeout_add_abstv(9)

2010-08-21 Thread Philip Guenther
On Fri, 20 Aug 2010, Bret S. Lambert wrote: > Replied to quickly just now and missed the following... > > > >From an abstraction point of view, I don't think it makes sense for so > > much code to needlessly know about "ticks". > > Yes, thus the conversions to actual time values. And, again, a me

Re: sbt/sdmmc locking update

2010-08-21 Thread Bret S. Lambert
On Sat, Aug 21, 2010 at 05:21:20PM -0700, Matthew Dempsky wrote: > On Sat, Aug 21, 2010 at 10:04 AM, Bret S. Lambert > wrote: > > This diff changes the locking in sbt and sdmmc from the old-and-busted > > lockmgr locks to the new-hotness rwlock locks. I don't have the > > hardware to test this on

Re: usb(4) threads

2010-08-21 Thread Matthew Dempsky
On Sun, Aug 22, 2010 at 01:41:54AM +, Jacob Meuser wrote: > this is in the device task loop to catch that: > > > > + if (!TAILQ_EMPTY(&usb_hub_tasks)) > > > + break; Ahh, I missed that. So yes, that's fine then, just the code can be sim

Re: usb(4) threads

2010-08-21 Thread Jacob Meuser
On Sat, Aug 21, 2010 at 04:31:58PM -0700, Matthew Dempsky wrote: > On Sat, Aug 21, 2010 at 08:25:23AM +, Jacob Meuser wrote: > > +volatile int usb_run_tasks; > > +volatile int discover_pending = 0; > > Do these really need to be volatile? no > +/* called by usbd_finish when lasst usb is deta

Re: sbt/sdmmc locking update

2010-08-21 Thread Theo de Raadt
> Why not simply change the SDMMC_LOCK/SDMMC_UNLOCK/SDMMC_ASSERT_LOCKED > macros and leave the .c files untouched (other than the lock init)? Because it obscures things. Eventually we all have to learn the native locking API's. If they are throughout our tree wrapped up into 50-60 variations, wh

Re: sbt/sdmmc locking update

2010-08-21 Thread Matthew Dempsky
On Sat, Aug 21, 2010 at 10:04 AM, Bret S. Lambert wrote: > This diff changes the locking in sbt and sdmmc from the old-and-busted > lockmgr locks to the new-hotness rwlock locks. I don't have the > hardware to test this on, so anybody with sbt/sdmmc is encouraged > to give it a spin. Why not simp

Re: usb(4) threads

2010-08-21 Thread Matthew Dempsky
On Sat, Aug 21, 2010 at 4:31 PM, Matthew Dempsky wrote: > for (usb_run_tasks) { Should be "while (usb_run_tasks) {" of course...

Re: usb(4) threads

2010-08-21 Thread Matthew Dempsky
On Sat, Aug 21, 2010 at 08:25:23AM +, Jacob Meuser wrote: > +volatile int usb_run_tasks; > +volatile int discover_pending = 0; Do these really need to be volatile? +/* called by usbd_finish when lasst usb is detached */ s/lasst/last/ +void +usb_end_tasks(void) +{ + usb_run_tasks = 0;

Re: Huawei E1820

2010-08-21 Thread Jonathan Gray
On Sat, Aug 21, 2010 at 04:41:44PM +0200, David Zeillinger wrote: > Hello, > > this makes the E1820 work and due to shared IDs probably some other > devices as well. thanks, committed.

ufs_open: don't leak f_buf

2010-08-21 Thread Martynas Venckus
the little operating system we wrote eventually panic'd (overflowed heap); standalone ufs.c implementation we've used leaks f_buf everytime ufs_open fails Index: ufs.c === RCS file: /cvs/src/sys/lib/libsa/ufs.c,v retrieving revision

ftp double free

2010-08-21 Thread Martynas Venckus
it crashes for me about 50% of the times like this $ make install ===> docbook-4.4p0 depends on: docbook-dsssl-* - not found ===> Verifying install for docbook-dsssl-* in textproc/docbook-dsssl ===> Checking files for docbook-dsssl-1.72 >> Fetch http://downloads.sourceforge.net/sourceforge/docb

is lvds

2010-08-21 Thread Martynas Venckus
every time x starts i get "is lvds". i think this is a debugging leftover, since the official xf86-video-intel tree never had it? Index: i830_display.c === RCS file: /cvs/xenocara/driver/xf86-video-intel/src/i830_display.c,v retrievi

sbt/sdmmc locking update

2010-08-21 Thread Bret S. Lambert
This diff changes the locking in sbt and sdmmc from the old-and-busted lockmgr locks to the new-hotness rwlock locks. I don't have the hardware to test this on, so anybody with sbt/sdmmc is encouraged to give it a spin. -Bert -- all is achievable through the power of Robocop Index: sbt.c ===

Re: ehci booboo

2010-08-21 Thread Jacob Meuser
On Sat, Aug 21, 2010 at 10:46:22AM -0400, Kenneth R Westerback wrote: > On Sat, Aug 21, 2010 at 07:43:18AM +, Jacob Meuser wrote: > > returning here without calling usb_transfer_complete() can cause > > the usbtask thread to sleep forever, which breaks all usb devices > > that use usb_tasks. >

Re: ehci booboo

2010-08-21 Thread Kenneth R Westerback
On Sat, Aug 21, 2010 at 07:43:18AM +, Jacob Meuser wrote: > returning here without calling usb_transfer_complete() can cause > the usbtask thread to sleep forever, which breaks all usb devices > that use usb_tasks. > > -- > jake...@sdf.lonestar.org > SDF Public Access UNIX System - http://sdf

Huawei E1820

2010-08-21 Thread David Zeillinger
Hello, this makes the E1820 work and due to shared IDs probably some other devices as well. Index: usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.511 diff -u -r1.511 usbdevs --- usbdevs 29 Jul 2010 12:

Preko 20 proizvoda uz poklon!

2010-08-21 Thread Top Shop
Top Shop Najbolji domaDi Top Shop proizvodi uz poklon! POKLON Mini kuhinjska vaga sve za negu kose i tela, oprema za bebe, igraD ke, knjiga Dr. Feelgood-a... Ili neki od najpopularnijih proizvoda ovog leta! Ponuda vaE>i još do 31.8.2010. POE=URITE! Više POKLON: Mini kuhinjska vaga uz svaki

usb(4) threads

2010-08-21 Thread Jacob Meuser
usb(4) has a per-instance "event" thread, and there is also a single task thread that runs all other usb_tasks. usb_tasks are added to a tailq and the task thread runs the tasks one at a time. the per-usb "event" threads only run root hub explorations. these are responsible for determining when a

ehci booboo

2010-08-21 Thread Jacob Meuser
returning here without calling usb_transfer_complete() can cause the usbtask thread to sleep forever, which breaks all usb devices that use usb_tasks. -- jake...@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org Index: ehci.c ===