[tcpdump-workers] print_llc code question

2009-09-01 Thread Jean-Louis CHARTON
Hi, Maybe the following question is pretty obvious but since I'm not an 802.2/LLC expert, I can't find a response for it. I was reading print_llc.c code and in llc_print() function, I found something that I don't really understand. At lines 247 to 251, one has : if (ssap == LLCSAP_IP && dsa

Re: [tcpdump-workers] print_llc code question

2009-09-07 Thread Jean-Louis Charton
Guy Harris alum.mit.edu> writes: > > So I don't know who actually *used* an 802.2 header without a SNAP > header when sending IP datagrams. > I agree that IP + LLC without SNAP is probably very unusual. Michael Richardson suggested me that the extra byte could be there to make the IP datagra

[tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-08 Thread Jean-Louis CHARTON
Hi, In the following piece of AIX specific code from pcap-bpf.c that creates and configures the /dev/bpf*; I think a call to bpf_odmcleanup is required in the cases where either genmajor() or genminor() fail (see "FIX HERE" below). Otherwise, the bpf_load() function returns without unlocking the

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Jean-Louis Charton
BTW, does someone know why the number of BPF devices is limited to 4 (at least on AIX)? Is there a technical reason for this ? I've tried to add one more bpf device (/dev/bpf4) on an AIX 5.1 box. The device configuration seems ok (i.e. the sysconfig() calls are successfull). I can launch up to 4

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-12 Thread Jean-Louis Charton
Hi Guy, > > I've checked in and pushed your changes on the main Git branch. > Thank you for commiting the fix I suggested. However, I've got a little comment: in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of errbuf to the 2 bpf_odmcleanup() calls. This was int

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-13 Thread Jean-Louis Charton
Guy Harris alum.mit.edu> writes: > > > I changed bpf_odmcleanup() so that, if it's passed a null pointer, it > doesn't bother returning an error string, and passed it a null pointer > in both those cases. That change has been checked in and pushed. > Yes, this is certainly the best soluti

[tcpdump-workers] Libpcap and 32 bits binary compatibility with Linux x86_64

2009-11-06 Thread Jean-Louis Charton
Hi, Is there any known issue running a 32 bits binary program that uses libpcap on a x86_64 Linux system ? I ask this question because it does not seem to work for me. The timestamps I've got from the pcap header are wrong and the buffer containing the captured bytes don't include the 14 bytes e