[tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
Hi, (Guy, I wrote you a separate email about that nearly 2 years ago and got side tracked for that long on other stuff). A number of Ethernet switches from Broadcom, Marvell, Microchip, Qualcomm, Lantiq/Intel, etc. utilize proprietary tags that are processed by these switches in-line with the Eth

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
On 1/17/19 3:41 PM, Guy Harris wrote: > On Jan 17, 2019, at 2:39 PM, Florian Fainelli wrote: > >> A number of Ethernet switches from Broadcom, Marvell, Microchip, >> Qualcomm, Lantiq/Intel, etc. utilize proprietary tags that are processed >> by these switches in-line

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
Le 1/17/19 à 5:24 PM, Guy Harris a écrit : > On Jan 17, 2019, at 4:56 PM, Florian Fainelli wrote: > >> These Ethernet adapters can be regular/normal Ethernet adapters, e.g: >> e1000e/igb/ixgbe on a PC connected to an Ethernet switch via GMII (for >> data path), and contr

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
Le 1/17/19 à 6:29 PM, Guy Harris a écrit : > On Jan 17, 2019, at 6:01 PM, Florian Fainelli wrote: > >> Correct. The other ports are exposed as regular Ethernet network devices. > > OK, I've updated a comment in the pull request for that. > > So, in any pre-4.19 ker

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
On 1/17/2019 6:56 PM, Guy Harris wrote: > On Jan 17, 2019, at 2:39 PM, Florian Fainelli wrote: > >> DSA currently supports the following tagging protocols (details can be >> found under net/dsa/tag_*.c in Linux source for exactly length and offset >> w

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-17 Thread Florian Fainelli
On 1/17/2019 8:12 PM, Guy Harris wrote: > On Jan 17, 2019, at 7:49 PM, Florian Fainelli wrote: > >> Le 1/17/19 à 6:29 PM, Guy Harris a écrit : >>> On Jan 17, 2019, at 6:01 PM, Florian Fainelli wrote: >>> >>>> Correct. The other ports are exposed as re

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-18 Thread Florian Fainelli
On 1/18/19 6:13 AM, Michael Richardson wrote: > > Guy Harris wrote: > >> OK, then requesting 10 DLT values, one per-tag is reasonable? > > > Yes. > > This is totally how it should be done. > > Guy, do we want to allocate 16 or 32 values, aligned, so that the > it be can DLT_TAG_BASE +

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-18 Thread Florian Fainelli
On 1/17/19 9:55 PM, Guy Harris wrote: > On Jan 17, 2019, at 9:16 PM, Florian Fainelli wrote: > >> On 1/17/2019 8:12 PM, Guy Harris wrote: >> >>> But if /sys/class/net/{device}/dsa doesn't exist in pre-4.19 kernels, how >>> can you determine, from userl

Re: [tcpdump-workers] Requesting DLT_* values for Ethernet switches proprietary tagging protocol

2019-01-20 Thread Florian Fainelli
On 1/20/2019 11:52 AM, Andrew Lunn wrote: > On Fri, Jan 18, 2019 at 10:19:04AM -0800, Florian Fainelli wrote: >> On 1/18/19 6:13 AM, Michael Richardson wrote: >>> >>> Guy Harris wrote: >>> >> OK, then requesting 10 DLT values, one per-tag is reas