Re: [tcpdump-workers] Update configure for libpcap

2018-07-12 Thread Jan Stary
On Jul 11 10:27:50, ghar...@sonic.net wrote: > On Jul 11, 2018, at 4:22 AM, Petr Vorel wrote: > > Libpcap's configure script is outdated. > > Although I'd prefer remove configure from git +1 > We have CMake support, so, as far as I'm concerned, getting autotools to work > on Windows is Somebody

Re: [tcpdump-workers] Update configure for libpcap

2018-07-12 Thread Dagobert Michelsen
Hi, Am 12.07.2018 um 12:07 schrieb Jan Stary : > On Jul 11 10:27:50, ghar...@sonic.net wrote: >> I would *personally* prefer that we not have generated configure files in >> Git and require that autoconf be run (or, if it needs to be run with >> particular arguments, supply an autopen.sh file an

[tcpdump-workers] [RFC LIBPCAP PATCH 1/1] Implement DLT_LINUX_SLL2

2018-07-12 Thread Petr Vorel
From: Petr Vorel Implements: GH the-tcpdump-group/libpcap#127 Signed-off-by: Petr Vorel Signed-off-by: Petr Vorel --- INSTALL.md | 2 +- cmakeconfig.h.in | 3 +++ config.h.in | 4 configure| 20 configure.ac | 10 ++ gencode.c

[tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi, this is an attempt to implement LINKTYPE_LINUX_SLL2 [1]. The main adventure over LINKTYPE_LINUX_SLL [2] is having "Interface index" field, which allows to show interface name for "any" device. This part is required for following patch in tcpdump, here I describe libpcap part. Unfortunately I

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi, > For users which needs, who needs to have LINKTYPE_LINUX_SLL, they have > to compile libpcap with --enable-sll-v2 option. Sorry, I meant --disable-sll-v2. Kind regards, Petr ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https:/

[tcpdump-workers] [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi, this patch depends on libpcap compiled with patch [1]. By default LINKTYPE_LINUX_SLL2 is compiled in (--enable-sll-v2 is the default). Users of old libpcap (or new compiled with --disable-sll-v2) need to compile tcpdump with --disable-sll-v2 option. MAJOR ISSUES Main problem is that libpcap s

[tcpdump-workers] [RFC TCPDUMP PATCH 1/2] Update configure

2018-07-12 Thread Petr Vorel
Signed-off-by: Petr Vorel --- This commit is just to make changes in configure in next commit clearer. Getting rid of configure in git might be accepted faster than this patch. --- configure | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/configure b/configure i

[tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-12 Thread Petr Vorel
From: Petr Vorel Implements: GH the-tcpdump-group/libpcap#127 Signed-off-by: Petr Vorel --- config.h.in | 4 configure | 20 configure.ac | 10 ++ missing/dlnames.c | 3 +++ print-sll.c | 27 +-- print.c

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Guy Harris
On Jul 12, 2018, at 11:02 AM, Petr Vorel wrote: > Unfortunately I haven't found a way how to coexist in runtime library > both LINKTYPE_LINUX_SLL and LINKTYPE_LINUX_SLL2, See libpcap commit 8cff296dc7c321c76933359d586dbde5b580ce8c, which adds DLT_LINUX_SLL2/LINKTYPE_LINUX_SLL2 support. Both DL

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Guy Harris
On Jul 12, 2018, at 11:33 AM, Petr Vorel wrote: > Main problem is that libpcap supports only one from LINKTYPE_LINUX_SLL > and LINKTYPE_LINUX_SLL2 Not in the version in the libpcap Git repository; both are supported. > Tests (make check) are broken as the output is different [2]. Not in the ve

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-12 Thread Guy Harris
On Jul 12, 2018, at 11:33 AM, Petr Vorel wrote: > +#ifdef PCAP_SUPPORT_SLL_V2 > + char ifname[IF_NAMESIZE]; > + if (if_indextoname(EXTRACT_BE_U_6(sllp->sll_ifindex), ifname)) > + ND_PRINT("IFNAME %s ", ifname); > +#endif What happens if you capture traffic on machine A and pr

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi Guy, > On Jul 12, 2018, at 11:02 AM, Petr Vorel wrote: > > Unfortunately I haven't found a way how to coexist in runtime library > > both LINKTYPE_LINUX_SLL and LINKTYPE_LINUX_SLL2, > See libpcap commit 8cff296dc7c321c76933359d586dbde5b580ce8c, which adds > DLT_LINUX_SLL2/LINKTYPE_LINUX_SLL

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Petr Vorel
Hi Guy, > On Jul 12, 2018, at 11:33 AM, Petr Vorel wrote: > > Main problem is that libpcap supports only one from LINKTYPE_LINUX_SLL > > and LINKTYPE_LINUX_SLL2 > Not in the version in the libpcap Git repository; both are supported. > > Tests (make check) are broken as the output is different

Re: [tcpdump-workers] [RFC LIBPCAP PATCH 0/1] LINKTYPE_LINUX_SLL2 implementation

2018-07-12 Thread Denis Ovsienko
On Thu, 12 Jul 2018 19:53:57 +0100 Guy Harris wrote > On Jul 12, 2018, at 11:02 AM, Petr Vorel wrote: > > > Unfortunately I haven't found a way how to coexist in runtime library > > both LINKTYPE_LINUX_SLL and LINKTYPE_LINUX_SLL2, > > See libpcap commit 8cff296dc7c321c7693335

Re: [tcpdump-workers] [RFC TCPDUMP PATCH 2/2] Add sll_ifindex into sll_header + use it to print ifname

2018-07-12 Thread Petr Vorel
Hi Guy, > What happens if you capture traffic on machine A and print it on machine B, > where machines A and B have different sets of network interfaces? > (This is why pcapng has Interface Description Blocks - so that the list of > interfaces is part of the file, so you use *that*, rather than