Re: [tcpdump-workers] [the-tcpdump-group/tcpdump] Color support: WIP with code+screenshots (#686)

2018-06-21 Thread Ryan Doyle
Hi Michael On Thu, 21 Jun 2018, at 12:14, Michael Richardson wrote: > > Ryan Doyle wrote: > > Anyhow, this is the email I sent. I'm keen to open up a discussion! > > I never saw the email on the list... > > > > --

Re: [tcpdump-workers] [the-tcpdump-group/tcpdump] Color support: WIP with code+screenshots (#686)

2018-06-21 Thread Guy Harris
On Jun 21, 2018, at 12:28 AM, Ryan Doyle wrote: > Step2. Expand by adding meaning to XML. The printer could then start to know > what a is and what it's attributes mean. At this point we could > start adding color to these. ... > Step3. Expand further, protocol by protocol adding pri

Re: [tcpdump-workers] [the-tcpdump-group/tcpdump] Color support: WIP with code+screenshots (#686)

2018-06-21 Thread Ryan Doyle
On Thu, 21 Jun 2018, at 17:33, Guy Harris wrote: > On Jun 21, 2018, at 12:28 AM, Ryan Doyle wrote: > > > Step2. Expand by adding meaning to XML. The printer could then start to > > know what a is and what it's attributes mean. At this point we > > could start adding color to these. > >

Re: [tcpdump-workers] [the-tcpdump-group/tcpdump] Color support: WIP with code+screenshots (#686)

2018-06-21 Thread Ray Bellis
On 21/06/2018 08:28, Ryan Doyle wrote: > We could build XML dynamically by changing ND_PRINT to store the > string contents instead of printing it directly and then actually > print once we've reached the end of the packet. Please, not XML. You'd need to define a schema for each and every singl