Re: [tcpdump-workers] [tcpdump] Sanity check on major/minor libpcap version

2015-10-08 Thread Michael Richardson
wrote: > Using pcap_major_version() and pcap_minor_version()) in tcpdump when > reading a file, I found: > Most pcap file have major.minor: 2.4 (current PCAP_VERSION_MAJOR and > PCAP_VERSION_MINOR), > a few have: 1.0 (ahcp.pcap, hdlc_slarp.pcap, msnlb2.pcap, > of10_7050q

Re: [tcpdump-workers] [tcpdump] Sanity check on major/minor libpcap version

2015-10-08 Thread Guy Harris
On Oct 8, 2015, at 11:33 AM, Michael Richardson wrote: > wrote: >> Using pcap_major_version() and pcap_minor_version()) in tcpdump when >> reading a file, I found: > >> Most pcap file have major.minor: 2.4 (current PCAP_VERSION_MAJOR and >> PCAP_VERSION_MINOR), > >> a few have: 1.0 (ahcp.pcap

Re: [tcpdump-workers] [tcpdump] Sanity check on major/minor libpcap version

2015-10-08 Thread Michael Richardson
Guy Harris wrote: > We might also want to, if major == PCAP_VERSION_MAJOR, make sure minor > <= PCAP_VERSION_MINOR, just in case somebody does a pcap 2.5 that code > that only knows up to version 2.4 can't handle. I thought that we'd have to call that 3.0... In my mind, a minor vers

Re: [tcpdump-workers] [tcpdump] Sanity check on major/minor libpcap version

2015-10-08 Thread Francois-Xavier Le Bail
On 08/10/2015 22:05, Michael Richardson wrote: Guy Harris wrote: > We might also want to, if major == PCAP_VERSION_MAJOR, make sure minor > <= PCAP_VERSION_MINOR, just in case somebody does a pcap 2.5 that code > that only knows up to version 2.4 can't handle. I thought that we'