Thanks,
That might be enough information for me to get a start on tackling some of
this.
Just for reference, this is the version of valgrind for FreeBSD i've been
working off of
http://wiki.freebsd.org/Valgrind
On Tue, Jan 8, 2013 at 11:32 PM, Guy Harris wrote:
>
> On Jan 8, 2013, at 7:08 PM
>> Thats irrelevant. This only shows that user land was depending on a
>> prior undocumented behavior.
Why do you say that? The following patch from Pirko ensured that on
both RX and TX regardless whether the driver/hw supported vlan
acceleration, the outermost vlan tags will always be extracted o
On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:
> This is wrong. Accelerated or not, the kernel code was organized to
> have the tags in the packet aux data. So I think this is how user land
> should be coded as well.
You have your opinion, thats good.
My opinion as a kernel developer is tha
On Wed, Jan 9, 2013 at 11:51 AM, Eric Dumazet wrote:
> On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:
>
>> This is wrong. Accelerated or not, the kernel code was organized to
>> have the tags in the packet aux data. So I think this is how user land
>> should be coded as well.
>
> You have you
On Wed, Jan 9, 2013 at 12:01 PM, Ani Sinha wrote:
> On Wed, Jan 9, 2013 at 11:51 AM, Eric Dumazet wrote:
>> On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:
>>
>>> This is wrong. Accelerated or not, the kernel code was organized to
>>> have the tags in the packet aux data. So I think this is h
Well, after tracking down some of the structures being used in the ioctl
arguments, and memset() them to zero, I think all of the errors went away
without the need to write any additional wrappers other than the pselect()
wrapper. Most of those calls were int he bpf-pcap.c file. I am not sure
wheth
On Jan 9, 2013, at 1:29 PM, Derek Cole wrote:
> Well, after tracking down some of the structures being used in the ioctl
> arguments, and memset() them to zero, I think all of the errors went away
> without the need to write any additional wrappers other than the pselect()
> wrapper. Most of
On Jan 9, 2013, at 1:34 PM, Guy Harris wrote:
> On Jan 9, 2013, at 1:29 PM, Derek Cole wrote:
>
>> I am not sure whether that is a worthwhile check-in to make for pcap or not.
>
> I'd rather fix valgrind. I'll see if I can beat it into working on Mountain
> Lion,
Well, the top-of-trunk SV
