cool
i would encourage tcpdump-workers to try to eventually support opening up
multiple devices and listening on all of them
for instance, the command,
tcpdump -e -i any
that would show output like:
11:42:25.170257 >eth100:24:bf:5b:d4:d6 > 00:0c:29:f7:7f:e9,
ethertype IPv4 (0x0
On Wed, Oct 31, 2012 at 5:50 PM, Guy Harris wrote:
>
> On Oct 31, 2012, at 3:35 PM, Ani Sinha wrote:
>
>> yes but if the packet is passed to the filter within libpcap (when we
>> are not using the kernel filter) before the reinsertion,
>
> ...that would be a bug.
>
> Currently, that bug doesn't e
On Sat, Nov 17, 2012 at 3:33 PM, Eric W. Biederman
wrote:
> the vlan header in packets as we receive them.
>
> The code is correct except for the case of packets in vlan 0. Currently
> the packet reconstruction is ambiguous. The most recent kernels have
> a TP_STATUS_VLAN_VALID flag that can be
Ani Sinha writes:
> On Sat, Nov 17, 2012 at 3:33 PM, Eric W. Biederman
> wrote:
>> the vlan header in packets as we receive them.
>>
>> The code is correct except for the case of packets in vlan 0. Currently
>> the packet reconstruction is ambiguous. The most recent kernels have
>> a TP_STATUS
On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman wrote:
> Ani Sinha writes:
>
>> On Sat, Nov 17, 2012 at 3:33 PM, Eric W. Biederman
>> wrote:
>>> the vlan header in packets as we receive them.
>>>
>>> The code is correct except for the case of packets in vlan 0. Currently
>>> the packet recons
On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman wrote:
> Ani Sinha writes:
>>>
>>
>> May be this?
>
> Two things.
>
> - TP_STATUS_VLAN_VALID lives in the tp_status field not the tp_vlan_tci field.
> - To work on older kernels with binaries compiled with newer headers you
> first want to test
Ani Sinha writes:
> On Thu, Dec 6, 2012 at 2:19 PM, Eric W. Biederman
> wrote:
>> Ani Sinha writes:
>>>
>>> May be this?
>>
>> Two things.
>>
>> - TP_STATUS_VLAN_VALID lives in the tp_status field not the tp_vlan_tci
>> field.
>> - To work on older kernels with binaries compiled with new
>
> The patch is whitespace damaged. And one of your test is using ||
> instead of &&
>
OK, using alpine now :-)
>
> The test should be && not ||.
>
aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-)
ani
pcap-linux.c | 50 +++---
1 fil
>
> The patch is whitespace damaged. And one of your test is using ||
> instead of &&
OK, using alpine now :-)
>
> The test should be && not ||.
aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-)
ani
pcap-linux.c | 50 +++---
1 files
Ani Sinha writes:
>>
>> The patch is whitespace damaged. And one of your test is using ||
>> instead of &&
>
> OK, using alpine now :-)
>>
>> The test should be && not ||.
>
> aargh! I am retarded! Fixed. Hopefully 3rd time is a charm :-)
Acked-by: "Eric W. Biederman"
The code looks ok here.
> "Eric" == Eric W Biederman writes:
Eric> It is a bit odd that you are indenting with spaces instead of tabs
Eric> in a file that is indented with tab. Again libpcap isn't my code so I
Eric> don't care but someone else might.
tabs are hysterical raisens.
Send two patches
1) ta
11 matches
Mail list logo
