Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-30 Thread Guy Harris
On Mar 26, 2018, at 11:09 AM, Guy Harris wrote: > On Mar 26, 2018, at 4:40 AM, Joerg Mayer wrote: > >> attache are four tiny patches to current git head of libpcap: >> >> 0001-Fix-warning-from-Wshadow.patch > > I need to stare at the code some more to figure out *why* it has an > on-the-stac

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-28 Thread Guy Harris
On Mar 28, 2018, at 1:14 AM, Joerg Mayer wrote: > Can you please apply 0004-Add-Wdocumentation-to-development-warnings.patch > from the original mail as well, now that the warnings are taken care of? Done. ___ tcpdump-workers mailing list tcpdump-work

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-28 Thread Joerg Mayer
On Tue, Mar 27, 2018 at 08:00:56PM -0700, Guy Harris wrote: > Checked in, with a missing \ added. and with the comment updated. > I'm not seeing it with flex 2.6.0, which I have installed in /usr/local/bin, > so maybe some later Flex version fixes the problem. Thanks! Can you please apply 0004-Ad

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-27 Thread Guy Harris
On Mar 27, 2018, at 3:58 AM, Joerg Mayer wrote: > On Tue, Mar 27, 2018 at 12:54:48PM +0200, Joerg Mayer wrote: >> There is no doxygen code in scanner.l. I followed your advice above and the >> attached patch fixes the problem. > > I should have added that I currently don't have GCC to test but

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-27 Thread Guy Harris
On Mar 27, 2018, at 3:54 AM, Joerg Mayer wrote: > On Mon, Mar 26, 2018 at 11:09:03AM -0700, Guy Harris wrote: >>> 0004-Add-Wdocumentation-to-development-warnings.patch >>> >>> Patch 4 is kind of "unclean" as it still generates warnings in the >>> generated file >>> scanner.c on my system (curre

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-27 Thread Ali Abdulkadir
Sorry, but I am only getting some messages. Can you "Reply All" from now on? > On Mar 27, 2018, at 1:58 PM, Joerg Mayer wrote: > >> On Tue, Mar 27, 2018 at 12:54:48PM +0200, Joerg Mayer wrote: >> There is no doxygen code in scanner.l. I followed your advice above and the >> attached patch fixes

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-27 Thread Joerg Mayer
On Tue, Mar 27, 2018 at 12:54:48PM +0200, Joerg Mayer wrote: > There is no doxygen code in scanner.l. I followed your advice above and the > attached patch fixes the problem. I should have added that I currently don't have GCC to test but that it most likely needs to be added to the GCC path as

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-27 Thread Joerg Mayer
On Mon, Mar 26, 2018 at 11:09:03AM -0700, Guy Harris wrote: > > 0004-Add-Wdocumentation-to-development-warnings.patch > > > > Patch 4 is kind of "unclean" as it still generates warnings in the > > generated file > > scanner.c on my system (current macos with current xcode). > > Is that due to pr

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-26 Thread Guy Harris
On Mar 26, 2018, at 11:11 AM, Ali Abdulkadir wrote: > How about also adding -Wshadow to check_and_add_compiler_option()? You mean like check_and_add_compiler_option(-Wshadow) which is currently at line 1626 of CMakeLists.txt as of commit 64cada32a854ef0b47e865e30be341867653c7f3? _

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-26 Thread Ali Abdulkadir
How about also adding -Wshadow to check_and_add_compiler_option()? How do you generate documentation? With doxygen? > On Mar 26, 2018, at 2:40 PM, Joerg Mayer wrote: > > Hello, > > attache are four tiny patches to current git head of libpcap: > > 0001-Fix-warning-from-Wshadow.patch > 0002-Fi

Re: [tcpdump-workers] 4 small patches to libpcap

2018-03-26 Thread Guy Harris
On Mar 26, 2018, at 4:40 AM, Joerg Mayer wrote: > attache are four tiny patches to current git head of libpcap: > > 0001-Fix-warning-from-Wshadow.patch I need to stare at the code some more to figure out *why* it has an on-the-stack copy of sockmain. > 0002-Fix-warnnigs-from-Wdocumentation.pa