Re: [tcpdump-workers] tcpslice when first file not used [PATCH]

2009-10-23 Thread Michael Richardson
Concerning tcpslice I asked Paul if he could pull it into a git repo... I then went back to my email, and remembered that mouse wrote an inverse program that he emailed to me last week, which due to lack of any name, I'll call pcapmerge. (it merges pcap files based upon time stamps) I'm thin

Re: [tcpdump-workers] tcpslice when first file not used [PATCH]

2009-10-23 Thread Alexander Dupuy
Hi Paul, I wrote: Also, looking at the source code, there appears to be an omission in the error() function call in the pcap_dump_open failure case - the third parameter (pcap_geterr call) seems not to be used (This is a pre-existing bug that just happens to be in the vicinity of your change).

[tcpdump-workers] tcpslice when first file not used [PATCH]

2009-10-21 Thread Paul Herman
Hi tcpdump-workers, Problem: When the first file contains no data to be extracted, tcpslice gives an error "error creating output file" even if other data in other source files can be used. Reason: in tcpslice.c:extract_slice(), states[0]->p ends up being closed, but then is later used to ca