Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-14 Thread Randal T. Rioux
Guy Harris wrote: On Oct 9, 2009, at 7:11 AM, Michael Richardson wrote: I do not know if there are any AIX users left. For me, it's been at least 15 years since I had one with a compiler. (Not counting the VIO LPAR server on IBM pSeries...) I wonder if we can even maintain this branch of pcap

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-13 Thread Jean-Louis Charton
Guy Harris alum.mit.edu> writes: > > > I changed bpf_odmcleanup() so that, if it's passed a null pointer, it > doesn't bother returning an error string, and passed it a null pointer > in both those cases. That change has been checked in and pushed. > Yes, this is certainly the best soluti

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-12 Thread Guy Harris
On Oct 12, 2009, at 12:28 AM, Jean-Louis Charton wrote: However, I've got a little comment: in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of errbuf to the 2 bpf_odmcleanup() calls. This was intentional to avoid squashing errbuf if for some reason bpf_odmclea

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-12 Thread Jean-Louis Charton
Hi Guy, > > I've checked in and pushed your changes on the main Git branch. > Thank you for commiting the fix I suggested. However, I've got a little comment: in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of errbuf to the 2 bpf_odmcleanup() calls. This was int

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Guy Harris
On Oct 9, 2009, at 7:11 AM, Michael Richardson wrote: I do not know if there are any AIX users left. For me, it's been at least 15 years since I had one with a compiler. (Not counting the VIO LPAR server on IBM pSeries...) I wonder if we can even maintain this branch of pcap at this point? W

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Guy Harris
On Oct 8, 2009, at 12:30 PM, Jean-Louis CHARTON wrote: Am I right? Almost certainly - I'm not an AIX expert, but I don't see any reason why you *wouldn't* be right. I've checked in and pushed your changes on the main Git branch. - This is the tcpdump-workers list. Visit https://cod.sandel

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Guy Harris
On Oct 9, 2009, at 3:22 AM, Jean-Louis CHARTON wrote: BTW, does someone know why the number of BPF devices is limited to 4 (at least on AIX)? Because the people at IBM who maintain AIX's BPF and tcpdump/libpcap don't have a clue? That's certainly the impression I get, from 1) the fact

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Michael Richardson
I do not know if there are any AIX users left. For me, it's been at least 15 years since I had one with a compiler. (Not counting the VIO LPAR server on IBM pSeries...) I wonder if we can even maintain this branch of pcap at this point? -- ] He who is tired of Weird Al is tired of life!

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-09 Thread Jean-Louis Charton
BTW, does someone know why the number of BPF devices is limited to 4 (at least on AIX)? Is there a technical reason for this ? I've tried to add one more bpf device (/dev/bpf4) on an AIX 5.1 box. The device configuration seems ok (i.e. the sysconfig() calls are successfull). I can launch up to 4

[tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-08 Thread Jean-Louis CHARTON
Hi, In the following piece of AIX specific code from pcap-bpf.c that creates and configures the /dev/bpf*; I think a call to bpf_odmcleanup is required in the cases where either genmajor() or genminor() fail (see "FIX HERE" below). Otherwise, the bpf_load() function returns without unlocking the