Re: [tcpdump-workers] clean exit from tcpdump with asan

--- Begin Message --- On Tue, Oct 27, 2020 at 5:42 AM Michael Richardson wrote: > > > enh via tcpdump-workers wrote: > > this patch fixes the use-after-free of `pd`, and also fixes the leak > > of `device`. let me know if you need this uploaded to github > > instead... > > Please make

Re: [tcpdump-workers] clean exit from tcpdump with asan

--- Begin Message --- this patch fixes the use-after-free of `pd`, and also fixes the leak of `device`. let me know if you need this uploaded to github instead... diff --git a/tcpdump.c b/tcpdump.c index 658d8b34..4fa390fd 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -2239,8 +2239,12 @@ main(int argc

[tcpdump-workers] clean exit from tcpdump with asan

--- Begin Message --- i haven't reproduced it myself yet (though i'll try shortly) but we got an automated crash report from tcpdump on Android via [gwp-asan](https://developer.android.com/ndk/guides/gwp-asan). the bug is a use-after-free, specifically when pcap_breakloop() tries to write to the a