Re: [tcpdump-workers] Patches for MingW etc.

2005-02-09 Thread Guy Harris
Gisle Vanem wrote: Some of the ifdefs for MingW/MSVC are completely unnecessary. There should be no need for _errno() etc in the sources. Looks like tcpdump was patched to suite a very old MingW. MingW also have getnameinfo(). Checked in. I've also added: IPv6 capability to inet_pton.c. Courtesy

Re: [tcpdump-workers] Patches for MingW etc.

2005-01-30 Thread Guy Harris
(Sorry about letting this one slip through the cracks) Gisle Vanem wrote: "Guy Harris" wrote: Does anything other than tcpdump.c and util.c need ? If not, then there's no need to include in tcpdump-stdinc.h - you can just move the include of in tcpdump.c outside of the #ifndef WIN32. tcpd

Re: [tcpdump-workers] Patches for MingW etc.

2005-01-05 Thread Gisle Vanem
"Guy Harris" wrote: Are there any OSes where ntohl() and ntohs() are defined as assembler macros on x86? If so, we might not want to override those definitions, if either 1) the OS is 486-and-later-only and uses the 32-bit byte-swapping instruction for ntohl() My version (ripped from Linux) sh

Re: [tcpdump-workers] Patches for MingW etc.

2005-01-04 Thread Guy Harris
On Dec 28, 2004, at 7:07 AM, Gisle Vanem wrote: inline ntohl() / ntohs() functions for gcc/i386. Are there any OSes where ntohl() and ntohs() are defined as assembler macros on x86? If so, we might not want to override those definitions, if either 1) the OS is 486-and-later-only and uses the

Re: [tcpdump-workers] Patches for MingW etc.

2005-01-04 Thread Gisle Vanem
"Guy Harris" wrote: Does anything other than tcpdump.c and util.c need ? If not, then there's no need to include in tcpdump-stdinc.h - you can just move the include of in tcpdump.c outside of the #ifndef WIN32. is needed in missing/get*info.c and missing/inet*.c too. And in machdep.c for __o

Re: [tcpdump-workers] Patches for MingW etc.

2005-01-03 Thread Guy Harris
On Dec 28, 2004, at 7:07 AM, Gisle Vanem wrote: Some of the ifdefs for MingW/MSVC are completely unnecessary. There should be no need for _errno() etc in the sources. Does anything other than tcpdump.c and util.c need ? If not, then there's no need to include in tcpdump-stdinc.h - you can just

[tcpdump-workers] Patches for MingW etc.

2004-12-28 Thread Gisle Vanem
Some of the ifdefs for MingW/MSVC are completely unnecessary. There should be no need for _errno() etc in the sources. Looks like tcpdump was patched to suite a very old MingW. MingW also have getnameinfo(). I've also added: IPv6 capability to inet_pton.c. Courtesy of Paul Vixie. inline ntohl(