ubject: Re: [tcpdump-workers] Bug in libpcap: savefile.c / get_selectable_fd()
On Mar 19, 2009, at 5:56 AM, Shaked, Nitzan wrote:
> What's next? Realistically speaking, should I hold my breath for those
> changes? (Should I implement them and submit a patch?)
Yes. I can't guarantee
On Mar 19, 2009, at 5:56 AM, Shaked, Nitzan wrote:
What's next? Realistically speaking, should I hold my breath for those
changes? (Should I implement them and submit a patch?)
Yes. I can't guarantee I'll have time to look at implementing them in
the immediate future.
-
This is the tcpdu
dump.org
[mailto:tcpdump-workers-ow...@lists.tcpdump.org] On Behalf Of Guy Harris
Sent: Thursday, March 19, 2009 12:34 PM
To: tcpdump-workers@lists.tcpdump.org
Subject: Re: [tcpdump-workers] Bug in libpcap: savefile.c /
get_selectable_fd()
On Mar 19, 2009, at 2:39 AM, Shaked, Nitzan wrote:
> 2) I
org
[mailto:tcpdump-workers-ow...@lists.tcpdump.org] On Behalf Of Guy Harris
Sent: Thursday, March 19, 2009 12:34 PM
To: tcpdump-workers@lists.tcpdump.org
Subject: Re: [tcpdump-workers] Bug in libpcap: savefile.c /
get_selectable_fd()
On Mar 19, 2009, at 2:39 AM, Shaked, Nitzan wrote:
> 2) I believe the curren
On Mar 19, 2009, at 2:39 AM, Shaked, Nitzan wrote:
2) I believe the current code doesn't have the notion of "non-
blocking",
which it doesn't have the notion of "I read only part of what was
request, maybe half a packet, or half a header",
...and it would even need that if you got rid of buf
Hello again
Thanks for the reply. With your permission, I'd like to keep this up a
little bit (I am actually quoting not in the original order, to cover
the "easy" part first):
> If that means that you can't tell the difference between "end of file
> on the pipe", "no more packets available righ
On Mar 17, 2009, at 4:38 PM, Guy Harris wrote:
If that means that you can't tell the difference between "end of
file on the pipe", "no more packets available right now", and "an
error occurred while reading from the pipe", as might be the case,
file a bug on that.
This will almost certai
On Mar 17, 2009, at 3:33 PM, Shaked, Nitzan wrote:
In general, it's a bad thing to mix buffered IO (stdlib, such as
fread,fread,fseek, etc) with kernel io (read/write/seek/select, etc).
At least when it comes to mixing stdio and select(), it's not a bad
thing, you just have to know what yo
Hello all
I hope this mailing list is active, and that this is the right place to post
to. In any case, I believe I have discovered a bug: get_selectable_fd() does
not work well when used with pcap_open_offline(). The symptom is that if you
use, as was the poet's intention, get_selectable_fd()