On Jul 6, 2005, at 1:56 PM, Guy Harris wrote:
So presumably "-X" should suppress the "print_default()" calls in
link-layer printers (i.e., the
if (!xflag && !qflag)
print_default(...);
calls). I'll look at doing that, unless somebody objects.
I've done that.
Should "-A" do so as
On Wed, 6 Jul 2005, Guy Harris wrote:
> So presumably "-X" should suppress the "print_default()" calls in
> link-layer printers (i.e., the
>
>if (!xflag && !qflag)
> print_default(...);
>
> calls). I'll look at doing that, unless somebody objects.
>
> Should "-A" do so as well?
hmm.
On Fri, 8 Jul 2005, Guy Harris wrote:
>
> On Jul 5, 2005, at 9:46 PM, dean gaudet wrote:
>
> > i also think the 3.9 behaviour needs some slight modifications, so
> > i'vemade two changes on top of your patch Guy.
>
> Well, on top of one of the versions of my patch; it's not the version
> th
On Jul 5, 2005, at 9:46 PM, dean gaudet wrote:
i also think the 3.9 behaviour needs some slight modifications, so
i'vemade two changes on top of your patch Guy.
Well, on top of one of the versions of my patch; it's not the version
that got checked in. (I did the original version at work,
Michael Richardson wrote:
Now, we need to commit the fix :-)
I took that as an indication that I should check in the patch whose URL
I sent to the list; I've checked it into the main and x.9 branches.
There's also the other issue I mentioned:
However, I also noticed that, while "-x" suppres
-BEGIN PGP SIGNED MESSAGE-
> "Guy" == Guy Harris <[EMAIL PROTECTED]> writes:
Guy> I guess that explains why *neither* of my messages had the
Guy> patch.
Guy> OK, it's at
Guy> http://www.sonic.net/~gharris/patch
The list filters out non-text/plain mime types.
-BEGIN PGP SIGNED MESSAGE-
> "dean" == dean gaudet <[EMAIL PROTECTED]> writes:
dean> heheh cool, you seem to have come to the same conclusions as
dean> me... and i've got a regression test at
dean> http://arctic.org/~dean/patches/tcpdump-3.9.1-test-print-flags.patch
I c
dean gaudet wrote:
heheh cool, you seem to have come to the same conclusions as me... and
i've got a regression test at
http://arctic.org/~dean/patches/tcpdump-3.9.1-test-print-flags.patch
i tried posting this earlier but i exceeded the 40k posting limit.
I guess that explains why *neither*
On Tue, 5 Jul 2005, Guy Harris wrote:
Guy Harris wrote:
> Here's a patch that has separate routines for "-A", "-x", and "-X", and
> that separately tests Aflag, xflag, and Xflag, and gives them all
> appropriate names.
Ok, *here's* the patch.
It also changes "-A" not to print the "\n\t" stuf
Guy Harris wrote:
Here's a patch that has separate routines for "-A", "-x", and "-X", and
that separately tests Aflag, xflag, and Xflag, and gives them all
appropriate names.
Ok, *here's* the patch.
It also changes "-A" not to print the "\n\t" stuff before the last
bufferful of ASCII data
On Jul 5, 2005, at 7:30 PM, Michael Richardson wrote:
oh, a regression test would have shown this.
...and a cleaner implementation of "-A" - i.e., one with a new
routine to print out the packet data as ASCII, rather than one that
jams that functionality into a routine that does a hex-an
-BEGIN PGP SIGNED MESSAGE-
dean> the -A flag prints hex rather than ascii-only... i think the
dean> following patch is necessary.
>>
dean> case 'A': - ++xflag; ++Xflag; ++Aflag; break; -
oh, a regression test would have shown this.
Can you submit a patch done with 3.8
-BEGIN PGP SIGNED MESSAGE-
> "Guy" == Guy Harris <[EMAIL PROTECTED]> writes:
>> -BEGIN PGP SIGNED MESSAGE-
>>
>>
>>
>>> "dean" == dean gaudet <[EMAIL PROTECTED]>
>>> writes:
>>>
dean> the -A flag prints hex rather than ascii-only
On Jul 5, 2005, at 6:29 PM, Michael Richardson wrote:
-BEGIN PGP SIGNED MESSAGE-
"dean" == dean gaudet <[EMAIL PROTECTED]>
writes:
dean> the -A flag prints hex rather than ascii-only... i think the
dean> following patch is necessary.
dean> case 'A': - ++xfl
On Tue, 5 Jul 2005, Michael Richardson wrote:
> -BEGIN PGP SIGNED MESSAGE-
>
>
> > "dean" == dean gaudet <[EMAIL PROTECTED]> writes:
> dean> the -A flag prints hex rather than ascii-only... i think the
> dean> following patch is necessary.
>
> dean> case 'A':
-BEGIN PGP SIGNED MESSAGE-
> "dean" == dean gaudet <[EMAIL PROTECTED]> writes:
dean> the -A flag prints hex rather than ascii-only... i think the
dean> following patch is necessary.
dean> case 'A': - ++xflag; ++Xflag; ++Aflag; break; -
Guy added that line 1
the -A flag prints hex rather than ascii-only... i think the following
patch is necessary.
-dean
p.s. i submitted a bug/patch but it's been suggested that nobody monitors
the sourceforge bug/patch thingers :)
--- tcpdump-3.9.1/tcpdump.c 2005-07-05 14:09:05.0 -0700
+++ tcpdump-3.9.1
17 matches
Mail list logo
