Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-08-23 Thread Guy Harris
On Aug 23, 2010, at 12:17 PM, Mcmillan, Scott A wrote: > As I was testing your changes, I noticed some very minor build issues, > resolved by this small patch: Thanks. I've checked your fixes into the trunk and 1.1 branches and pushed them. - This is the tcpdump-workers list. Visit https://co

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-08-23 Thread Mcmillan, Scott A
Guy, Thank you for significantly improving and merging this capability into the official repository. I fully agree with your changes. I was thinking that way myself, but was hesitant to propose changes of that degree as my first contribution. As I was testing your changes, I noticed some ver

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-08-22 Thread Guy Harris
On May 24, 2010, at 7:26 AM, Mcmillan, Scott A wrote: > This patch adds the capability to select the packet timestamp source. It > also adds support for the PACKET_TIMESTAMP Linux kernel setting to specify > the source of packet timestamps. The corresponding Linux kernel patch is > being sub

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-06-03 Thread Mcmillan, Scott A
Scott -Original Message- From: tcpdump-workers-ow...@lists.tcpdump.org [mailto:tcpdump-workers-ow...@lists.tcpdump.org] On Behalf Of Guy Harris Sent: Friday, May 28, 2010 10:28 PM To: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support O

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-06-01 Thread Mcmillan, Scott A
fully fall back to sw timestamps. The updated tcpdump patch I posted simplifies this situation by removing the option to select the "raw" timestamps. Thanks, Scott -Original Message- From: tcpdump-workers-ow...@lists.tcpdump.org [mailto:tcpdump-workers-ow...@lists.tcpdum

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-28 Thread Guy Harris
On May 26, 2010, at 9:03 AM, Mcmillan, Scott A wrote: > Both the 'raw' and 'nic' timestamps are in the form of seconds since the Unix > epoch, plus fractions of a second. Please see my response to Darren for more > info on the difference between these two timestamp sources. Which reply was th

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-28 Thread Guy Harris
On May 24, 2010, at 7:26 AM, Mcmillan, Scott A wrote: > This patch adds the capability to select the packet timestamp source. It > also adds support for the PACKET_TIMESTAMP Linux kernel setting to specify > the source of packet timestamps. The corresponding Linux kernel patch is > being sub

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-26 Thread Darren Reed
r...@oracle.com] Sent: Tuesday, May 25, 2010 7:37 PM To: Mcmillan, Scott A Cc: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support Scott, Is it just the 82580 or others too? If I look in the source code for OpenSolaris, I see: igb_

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-26 Thread Aaron Turner
On Wed, May 26, 2010 at 9:03 AM, Mcmillan, Scott A wrote: > Guy, > > Both the 'raw' and 'nic' timestamps are in the form of seconds since the Unix > epoch, plus fractions of a second.  Please see my response to Darren for more > info on the difference between these two timestamp sources. > > The

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-26 Thread Rick Jones
Guy Harris wrote: Is there ever any reason *NOT* to use the hardware timestamp if it's available? Only if it and the host time are not sufficiently in sync and you want to correlate with other things timestamped with host time. rick jones - This is the tcpdump-workers list. Visit https://cod

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-26 Thread Mcmillan, Scott A
ren.r...@oracle.com] Sent: Tuesday, May 25, 2010 7:37 PM To: Mcmillan, Scott A Cc: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support Scott, Is it just the 82580 or others too? If I look in the source code for OpenSolaris, I see: igb_82575.h:#d

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-26 Thread Mcmillan, Scott A
mp-workers-ow...@lists.tcpdump.org] On Behalf Of Guy Harris Sent: Tuesday, May 25, 2010 8:37 PM To: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support On May 24, 2010, at 7:26 AM, Mcmillan, Scott A wrote: > [My apologies if this double post

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-25 Thread Guy Harris
On May 24, 2010, at 7:26 AM, Mcmillan, Scott A wrote: > [My apologies if this double posts. The mail server didn't care for the > first submission.] > > This patch adds the capability to select the packet timestamp source. Is there ever any reason *NOT* to use the hardware timestamp if it's a

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-25 Thread Darren Reed
Original Message- From: tcpdump-workers-ow...@lists.tcpdump.org [mailto:tcpdump-workers-ow...@lists.tcpdump.org] On Behalf Of yon ar c'hall Sent: Tuesday, May 25, 2010 4:41 AM To: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support Hello S

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-25 Thread Mcmillan, Scott A
--Original Message- From: tcpdump-workers-ow...@lists.tcpdump.org [mailto:tcpdump-workers-ow...@lists.tcpdump.org] On Behalf Of yon ar c'hall Sent: Tuesday, May 25, 2010 4:41 AM To: tcpdump-workers@lists.tcpdump.org Subject: Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support Hello

Re: [tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-25 Thread yon ar c'hall
Hello Scott, By the way, do you know which NICs/network controllers support HW timestamping for all packets (not only the PTP datagrams -- IEEE 1588) ? Yon On Mon, May 24, 2010 at 4:26 PM, Mcmillan, Scott A < scott.a.mcmil...@intel.com> wrote: > [My apologies if this double posts. The mail ser

[tcpdump-workers] [RFC PATCH 0/2]: hw timestamp support

2010-05-24 Thread Mcmillan, Scott A
[My apologies if this double posts. The mail server didn't care for the first submission.] This patch adds the capability to select the packet timestamp source. It also adds support for the PACKET_TIMESTAMP Linux kernel setting to specify the source of packet timestamps. The corresponding Li