Re: [tcpdump-workers] [PATCH] fix usb off by one

2006-10-24 Thread ronnie sahlberg
Do we really need 4 bytes to store the endpoint address in the header? Without changing the size of the header, what about splitting the four bytes of endpoint address into two 16 bit integers one of them is endpoint address and the other is which usb interface the capture was taken on ? the us

Re: [tcpdump-workers] [PATCH] fix usb off by one

2006-10-23 Thread Joerg Mayer
On Sun, Oct 15, 2006 at 07:35:36PM +0200, Paolo Abeni wrote: > p.s. the gettimeofday syscall give some overhead to the sniffing code, > but currently the text interface provided by the kernel is IMHO the real > bottleneck. Could you post a kernel-patch that fixes the worst problems with the interf

Re: [tcpdump-workers] [PATCH] fix usb off by one

2006-10-15 Thread Guy Harris
Paolo Abeni wrote: the attached patch fix an off by one in current usb sniffing code. It also substitute the kernel-provided timestamp with gettimeofday. The kernel provided timestamp use 32 bits to represent a struct timeval (8 bits for tv_sec and 24 for tv_usec), so it's content is quite misle

[tcpdump-workers] [PATCH] fix usb off by one

2006-10-15 Thread Paolo Abeni
hello, the attached patch fix an off by one in current usb sniffing code. It also substitute the kernel-provided timestamp with gettimeofday. The kernel provided timestamp use 32 bits to represent a struct timeval (8 bits for tv_sec and 24 for tv_usec), so it's content is quite misleading. ciao,