Re: [tcpdump-workers] [PATCH] enable memory mapped access toethernet device for linux

2007-12-07 Thread Paolo Abeni
hello, First, thanks for the detailed review. It seems that some of the relevant point has been addressed by Guy Harris, so I'll try to catch the others... On Thu, 2007-12-06 at 12:54 -0500, Alexander Dupuy wrote: > Rounding the ring size to nearest power of two wastes quite a bit of > memory f

Re: [tcpdump-workers] [PATCH] enable memory mapped access toethernet

2007-12-05 Thread Gianluca Varenni
do not use memory mapped access). Have a nice day GV - Original Message - From: "Gregor Maier" <[EMAIL PROTECTED]> To: Sent: Wednesday, December 05, 2007 10:27 AM Subject: Re: [tcpdump-workers] [PATCH] enable memory mapped access toethernet -BEGIN PG

Re: [tcpdump-workers] [PATCH] enable memory mapped access toethernet

2007-12-05 Thread Gregor Maier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > The idea behind the snaplen [miss-]use is to permit legacy application > to take advantage of the memory mapped access and permit new ones to > control the ring behaviur. Such goal could be obtained even with other > solution, but I was a bit 'sc

Re: [tcpdump-workers] [PATCH] enable memory mapped access toethernet device for linux

2007-12-05 Thread Paolo Abeni
hello, On Wed, 2007-12-05 at 08:23 -0800, Gianluca Varenni wrote: > From what you said, you basically changed the behavior of the snaplen > parameter of pcap_open_live(). At the risk of being annoing, I find it a > really bad idea. If it's called snaplen, it's the snaplen, period. > Isn't it pos