Re: [tcpdump-workers] vlan handling

2014-04-04 Thread Shoham peller
Hi, I'm having problems implementing it. The problem is the action precedence bison does. For example: "vlan or vlan" I've written code that makes the "or" keyword to restore the off_linktype so that the second "vlan" keyword uses off_linktype that is reseted. But the action precede

Re: [tcpdump-workers] vlan handling

2014-03-31 Thread Shoham peller
There is a few problems with your solution: * It isn't backward-compatible * I doesn't solve the issue. (vlanid-2 and arp or vlanid-3 and ip) is not neccessarily solving the offset problems. If you think the vlan syntax should change it's doable, only you have to be backward-compatible and it's

Re: [tcpdump-workers] [libpcap] OR'ing vlans impossible in tcpdump filter (issue #158)

2014-03-20 Thread Shoham Peller
yahoo.com> writes: > > That does not solve the cases I wrote below. The filters I wrote are also difficult to translate to the syntax > you suggested: > * (vlan 1 or vlan 2) and ip > * (vlan 1 or ether) and ip > > I'm hoping to be free to implement the algorithm I suggested in the near future.

Re: [tcpdump-workers] [libpcap] OR'ing vlans impossible in tcpdump filter (issue #158)

2013-10-26 Thread Shoham Peller
Thought about it, and this is not a complete solution. It doesn't solve things like: * (vlan 1 or vlan 2) and ip * (vlan 1 or ether) and ip So the solution isn't complete, but it sure does improve the current situation. So what do you say? Should we proceed to develop this logic? Sho

[tcpdump-workers] [libpcap] OR'ing vlans impossible in tcpdump filter (issue #158)

2013-10-12 Thread Shoham Peller
an with the current offset (0) and increment offset ( = 8) 4. or. reset the offset to it's state in the last parenthesis from the offset stack ( = 4) 5. filter arp with the current offset (4) 6. close parenthesis. pop the offset's state 7. or. reset the offset to it's state in the l