On Thu, Jan 18, 2007 at 08:36:34AM +0100, Hannes Gredler wrote:
: well the correct thing would then be:
:
: 1. embrace .SFP into Flags [.SPF],
: 2. add commas to sep. the rest of the field
I don't see commas (in general) adding to readability of fields
when you have 'field-name value' or when pos
I started looking at this because the minimum length check was
off by one.
0) fix off by one (4 vs. 3)
1) print flag bits
2) print rcode fields if either is non-zero
Index: bootp.h
===
RCS file: /tcpdump/master/tcpdump/bootp.h,v
retr
On Wed, Jan 17, 2007 at 11:42:48PM +0100, Hannes Gredler wrote:
: can you re-explain your concern ?
: we use the comma here as a means of seperating
: fields suitable to human-processors.
3 main issues:
0) not consistent with rest of tcp output (no commas used)
1) distracts from output (e.g., see
commas aren't used in tcp fields so remove these that are
before and after cksum.
Index: print-tcp.c
===
RCS file: /tcpdump/master/tcpdump/print-tcp.c,v
retrieving revision 1.126
diff -u -r1.126 print-tcp.c
--- print-tcp.c 2 Nov 2006
ler wrote:
: but it removes all trailing columns (ip addresses) and makes things more
unreadable ...
:
: On Sun, Jan 14, 2007 at 02:20:41PM -0800, Kevin Steves wrote:
: | this seems nicer without extra spaces.
: |
: | Index: print-i
the other fields don't print 'field: value' so don't here either.
Index: print-ip.c
===
RCS file: /tcpdump/master/tcpdump/print-ip.c,v
retrieving revision 1.155
diff -u -r1.155 print-ip.c
--- print-ip.c 19 Feb 2006 05:00:19 -
this eliminates extra leading space for DNS dissector.
Index: print-domain.c
===
RCS file: /tcpdump/master/tcpdump/print-domain.c,v
retrieving revision 1.95
diff -u -r1.95 print-domain.c
--- print-domain.c 12 Nov 2006 23:12:03 -0
0) don't print spaces in [ flags ]
1) some whitespace cleanup in that area
Index: print-bootp.c
===
RCS file: /tcpdump/master/tcpdump/print-bootp.c,v
retrieving revision 1.83
diff -u -r1.83 print-bootp.c
--- print-bootp.c 14 Jan
this seems nicer without extra spaces.
Index: print-ip.c
===
RCS file: /tcpdump/master/tcpdump/print-ip.c,v
retrieving revision 1.155
diff -u -r1.155 print-ip.c
--- print-ip.c 19 Feb 2006 05:00:19 - 1.155
+++ print-ip.c 14
The following patch does the following:
0) use TTEST/TCHECK macros vs. snapend comparisons
1) when -vvv display PAD and END options
(multiple PAD options are summarized)
2) change a trunc string from bootp to rfc1048 because I think that is
what is intended (matches trunc label)
It may make
The following patch fixes a bug in print-bootp.c. It will print an
extra "\n\t " when the last line contains 4 options. It is also
simpler in general and eliminates the need for a first variable.
Also contains some formatting and whitespace cleanup.
Index: print-bootp.c
11 matches
Mail list logo
