[tcpdump-workers] Request for feedback on terminating tcpdump capture after specified time

2018-08-01 Thread Greg Steinbrecher
The actual PR needs some cleanup/rebasing, but before doing that it was pointed out that soliciting feedback would be a good idea. PR here: https://github.com/the-tcpdump-group/tcpdump/pull/684 Motivation on our end was termination of captures after short periods of time -- say, grabbing 50ms

[tcpdump-workers] Tcpdump doesn't check for pcap_set_tstamp_type warnings

2018-07-29 Thread Greg Steinbrecher
Hi all, When tcpdump calls pcap_set_tstamp_type, it only checks if the returned status is less than 0; if the specific type requested exists but isn't supported (e.g. `-j adapter` on a card that only supports adapter_unsynced) pcap_set_tstamp_type returns the warning code PCAP_WARNING_TSTAMP_T