Re: [tcpdump-workers] 4 small patches to libpcap

On Mar 26, 2018, at 11:11 AM, Ali Abdulkadir wrote: > How about also adding -Wshadow to check_and_add_compiler_option()? You mean like check_and_add_compiler_option(-Wshadow) which is currently at line 1626 of CMakeLists.txt as of commit 64cada32a854ef0b47e865e30be341867653c7f3? _

Re: [tcpdump-workers] 4 small patches to libpcap

How about also adding -Wshadow to check_and_add_compiler_option()? How do you generate documentation? With doxygen? > On Mar 26, 2018, at 2:40 PM, Joerg Mayer wrote: > > Hello, > > attache are four tiny patches to current git head of libpcap: > > 0001-Fix-warning-from-Wshadow.patch > 0002-Fi

Re: [tcpdump-workers] 4 small patches to libpcap

On Mar 26, 2018, at 4:40 AM, Joerg Mayer wrote: > attache are four tiny patches to current git head of libpcap: > > 0001-Fix-warning-from-Wshadow.patch I need to stare at the code some more to figure out *why* it has an on-the-stack copy of sockmain. > 0002-Fix-warnnigs-from-Wdocumentation.pa

[tcpdump-workers] 4 small patches to libpcap

Hello, attache are four tiny patches to current git head of libpcap: 0001-Fix-warning-from-Wshadow.patch 0002-Fix-warnnigs-from-Wdocumentation.patch 0003-Allow-.devel-file-to-be-in-the-build-directory-in-ad.patch 0004-Add-Wdocumentation-to-development-warnings.patch Patch 4 is kind of "unclean"