Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-10-31 Thread Ani Sinha
On Wed, Oct 31, 2012 at 5:50 PM, Guy Harris wrote: > > On Oct 31, 2012, at 3:35 PM, Ani Sinha wrote: > >> yes but if the packet is passed to the filter within libpcap (when we >> are not using the kernel filter) before the reinsertion, > > ...that would be a bug. > > Currently, that bug doesn't e

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-10-31 Thread Ani Sinha
On Wed, Oct 31, 2012 at 3:20 PM, Guy Harris wrote: > > On Oct 31, 2012, at 2:50 PM, Ani Sinha wrote: > >> pcap files that already have the tags reinsrted should work with >> current filter code. However for live traffic, one has to get the tags >> from CMSG() and then reinsert it back to the pack

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-10-31 Thread Ani Sinha
cc'ing netdev. On Wed, Oct 31, 2012 at 2:01 PM, Michael Richardson wrote: > > Thanks for this email. > >> "Ani" == Ani Sinha writes: > Ani> remove "inline" from vlan_core.c functions > Ani> Signed-off-by: David S. Miller > > Ani> As a result of this patch, with or without HW ac

[tcpdump-workers] Fwd: scan_sys_class_net bug in pcap-linux.c

2012-10-31 Thread Paul Sheer
forwarding to list -paul -- Forwarded message -- From: Paul Sheer Date: Tue, Oct 30, 2012 at 7:40 PM Subject: scan_sys_class_net bug in pcap-linux.c To: Bill Fenner , Fulvio Risso , Guy Harris , Hannes Gredler , Michael Richardson Hi there! I notice you guys have in scan_sy

[tcpdump-workers] vlan tagged packets and libpcap breakage

2012-10-31 Thread Ani Sinha
hello folks : Before I go into describing the real problem, I'd like to give some background information for the context. Please bear with me. As you guys might be aware, the way the Linux kernel handles vlan tagged packets have changed. Please see the following commit in mainline Torvalds' tree