[tcpdump-workers] [PATCH] ifSpeed in sFlow is 64 bits not 32

2011-05-27 Thread Rick Jones
The ifSpeed field of a generic interface counter in sFlow is 64 bits. The "overlay" definition in print-sflow.c is correct, but the actual extract for printing is using EXTRACT_32BITS rather than EXTRACT_64BITS, which leads to an incorrect report for speed. Signed-off-by: Rick Jones diff --git a

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Ben Greear
On 05/27/2011 11:03 AM, Guy Harris wrote: On May 27, 2011, at 5:20 AM, ri...@happyleptic.org wrote: If I understand this code correctly, in the next release of the libpcap if a client program ask for a capture length bigger than the MTU then the size allocated for each frame in the ring buffer

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Guy Harris
On May 27, 2011, at 12:04 PM, Ben Greear wrote: > Might want to add an extra 4 bytes for a possible VLAN header too. prepare_tpacket_socket() sets the "reserve" for VLAN tag reconstruction to 4; the "reserve", along with the maximum packet size, is involved in calculating the frame slot size.

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Guy Harris
On May 27, 2011, at 10:54 AM, Rick Jones wrote: > Excellent! And that makes me wonder if I should add similar offload > checking (and reporting) code to netperf for its omni tests... It's modeled after what ethtool does, so if your tests are wrapped in a shell script, you could run ethtool on

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Guy Harris
On May 27, 2011, at 5:20 AM, ri...@happyleptic.org wrote: > If I understand this code correctly, in the next release of the libpcap > if a client program ask for a capture length bigger than the MTU then > the size allocated for each frame in the ring buffer will be sized down > to avoid wasting

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Rick Jones
On Fri, 2011-05-27 at 10:39 -0700, Guy Harris wrote: > On May 27, 2011, at 10:16 AM, Rick Jones wrote: > > > Is this new libpcap going to be guaranteed that the underlying NIC HW > > isn't doing Large Receive Offload, or that the tracepoint in the stack > > is below any stack's attempt to do Gener

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Guy Harris
On May 27, 2011, at 10:16 AM, Rick Jones wrote: > Is this new libpcap going to be guaranteed that the underlying NIC HW > isn't doing Large Receive Offload, or that the tracepoint in the stack > is below any stack's attempt to do Generic Receive Offload? If 1) your kernel supports the e

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread Rick Jones
On Fri, 2011-05-27 at 14:20 +0200, ri...@happyleptic.org wrote: > -[ Mon, May 23, 2011 at 12:38:43AM -0700, Guy Harris ] > > > > On May 23, 2011, at 12:31 AM, ri...@happyleptic.org wrote: > > > > > Which brings the question: how one could find out the MTU of a > > > pcap_handle in order no to

Re: [tcpdump-workers] libpcap capture performance drop

2011-05-27 Thread rixed
-[ Mon, May 23, 2011 at 12:38:43AM -0700, Guy Harris ] > > On May 23, 2011, at 12:31 AM, ri...@happyleptic.org wrote: > > > Which brings the question: how one could find out the MTU of a > > pcap_handle in order no to set caplen to 65535 ? > > See pcap-linux.c in the top of the trunk or of t