[tcpdump-workers] [PATCH 3/4] Use proper type (16bit) when extracting path id count

2011-01-25 Thread Jamal Hadi Salim
Signed-off-by: Jamal Hadi Salim --- forces.h |2 +- print-forces.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/forces.h b/forces.h index b9cf072..ed497d4 100644 --- a/forces.h +++ b/forces.h @@ -585,7 +585,7 @@ int pkeyitlv_print(register const u_char * p

[tcpdump-workers] [PATCH 1/4] Fix mixing recursive and flat Path Data

2011-01-25 Thread Jamal Hadi Salim
+--PD . +--PD . | . | . +--PD . . +--PD | | +--PD or +--PD . +--PD . + . | . +--PD . + . | . +-- PD . + . | . +-- PD +--PD | | +--PD etc Signed-off-by: Jamal Hadi Salim --- print-forces.c | 18

[tcpdump-workers] [PATCH 2/4] Fix indent space when we have padded data

2011-01-25 Thread Jamal Hadi Salim
See if you can spot the difference between Pathdata: Flags 0x0 ID count 1 ID#01: 3 FULLDATA TLV (Length 10 DataLen 6 pad 2 Bytes) [ 0x: 0002 0406 080a ] and: Pathdata: Flags 0x0 ID count 1 ID#01: 3 FULLDATA TLV (Length 10 DataLen 6 pad

[tcpdump-workers] [PATCH 0/4] ForCES fixes

2011-01-25 Thread Jamal Hadi Salim
These set of patches address a recursive path data which encapsulates a flat data path Jamal Hadi Salim (4): Fix mixing recursive and flat Path Data Fix indent space when we have padded data Use proper type (16bit) when extracting path id count Add test pcap and output for nested and recur

Re: [tcpdump-workers] [PATCH 2/4] Fix indent space when we have padded data

2011-01-25 Thread Michael Richardson
Jamal, all of the patches applied, except for this one, which seemed to already be applied. Perhaps it was reversed? Thank you kindly for including test cases with your patches. -- ] He who is tired of Weird Al is tired of life! | firewalls [ ] Michael Richardson, Sandelman

Re: [tcpdump-workers] [PATCH 2/4] Fix indent space when we have padded data

2011-01-25 Thread Jamal Hadi Salim
On Tue, Jan 25, 2011 at 8:02 PM, Michael Richardson wrote: > Thank you kindly for including test cases with your patches. I should have mentioned that i tested the other two ForCES tests already there and they are unaffected by this change. cheers, jamal - This is the tcpdump-workers list. Visi

Re: [tcpdump-workers] [PATCH 2/4] Fix indent space when we have padded data

2011-01-25 Thread Jamal Hadi Salim
Michael, I just updated from the tcpdump tree and i see it somehow going in as 1/4. So it is there, commit: 375352c72b7c958e520a49dd5a58eb19877e833b Thanks for applying the patches. cheers, jamal On Tue, Jan 25, 2011 at 8:02 PM, Michael Richardson wrote: > > Jamal, all of the patches applied,

Re: [tcpdump-workers] Obtaining interface IP address and MAC address

2011-01-25 Thread roy hills
> The interfaces used to do both of the above are almost universal now: > SIOCGIFADDR and SIOCGIFHWADDR. I don't think SIOCGIFHWADDR is supported on MacOS or Windows. For MacOS and other BSD operating systems, I use sysctl with the MIB { CTL_NET, PF_ROUTE, 0, AF_LINK, NET_RT_IFLIST, 0 } and lo

Re: [tcpdump-workers] new hardware integration to libpcap/wireshark

2011-01-25 Thread Guy Harris
On Jan 24, 2011, at 5:03 AM, Jens Grimmer wrote: > I will submit the patches with my enhancements as soon as possible. Yes, its > right, our packet data begins with a pseudo-header. For sure I will provide > you with a documentation for the pseudo-header. Would a mailed PDF-document > be OK fo

Re: [tcpdump-workers] Request for new DLT value for Wireshark Dissector

2011-01-25 Thread Guy Harris
On Jan 20, 2011, at 3:05 AM, Schemmel, Hans-Christoph wrote: > The format of the additional header is: > > | Header_Size | Msg_ID | Freq_ID | Start_Pos | End_Pos | Flag | ... | > Msg_ID | > Freq_ID | Start_Pos | End_Pos | Flag | Direction | MUX_Frame > > Header_Size (1 Octet): Total length