Re: [tcpdump-workers] [net-2.6 PATCH] af_packet: move strict addr_len check right

2010-03-02 Thread Eric Dumazet
Le mercredi 03 mars 2010 à 07:40 +0100, Jiri Pirko a écrit : > Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before > dev_[mc/unicast]_[add/del] > > My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed > the length check in packet_mc_add to be more

[tcpdump-workers] [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]

2010-03-02 Thread Jiri Pirko
Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed the length check in packet_mc_add to be more strict. The problem is that userspace is not filling this field (and i

Re: [tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set

2010-03-02 Thread Jiri Pirko
Wed, Mar 03, 2010 at 02:00:48AM CET, pro...@gnu.org wrote: >Hello! > >The current wireless-testing appears to have some non-wireless bits from >the upcoming Linux 2.6.34. As a result, libpcap and all capture >programs that use it are broken. > >This patch to libpcap helps: > >--- a/pcap-linux.c >+

[tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set

2010-03-02 Thread Pavel Roskin
Hello! The current wireless-testing appears to have some non-wireless bits from the upcoming Linux 2.6.34. As a result, libpcap and all capture programs that use it are broken. This patch to libpcap helps: --- a/pcap-linux.c +++ b/pcap-linux.c @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle,

Re: [tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set

2010-03-02 Thread John W. Linville
On Tue, Mar 02, 2010 at 08:00:48PM -0500, Pavel Roskin wrote: > Also, pulling bleeding edge stuff into wireless-testing before rc1 > appears to be either a mistake or a bad decision. Feel free to use an earlier commit... -- John W. Linville                Someday the world will need a hero, and

Re: [tcpdump-workers] Packet drop counts via pcap_stats()

2010-03-02 Thread Jim Lloyd
On Sat, Feb 27, 2010 at 5:35 PM, Dustin Spicuzza wrote: > Jim Lloyd wrote: > > Over the last couple months we have developed and deployed into a > production > > environment an application using libpcap, where we sniff upwards of > 350Mbps > > of HTTP traffic arriving via a SPAN. On the whole I a

[tcpdump-workers] Can't install an inbound/outbound filter in the Linux kernel ?

2010-03-02 Thread John Cormie
I've noticed that using either the inbound or outbound keyword in my capture expression results in a filter that cannot be installed in the kernel and gets processed in user mode instead. I believe the problem is that these filters generate BPF code that pcap-linux.c:fix_program() is unable to rewr