Re: [tcpdump-workers] select() regression in libpcap-devel?

2009-10-12 Thread Guy Harris
On Jun 23, 2009, at 7:34 PM, Mike Kershaw wrote: (This now actually hits my error catcher where 100 fd highs in a row with no packets triggers a shutdown of the source, since libpcap-1.0.0 seems to not return errors in pcap_dispatch when a netdev is removed (ie usb unplugged or driver crash)

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-12 Thread Guy Harris
On Oct 12, 2009, at 12:28 AM, Jean-Louis Charton wrote: However, I've got a little comment: in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of errbuf to the 2 bpf_odmcleanup() calls. This was intentional to avoid squashing errbuf if for some reason bpf_odmclea

Re: [tcpdump-workers] [PATCH] SocketCAN support for libpcap -

2009-10-12 Thread Felix Obenhuber
On Sun, 2009-10-11 at 10:35 -0700, Guy Harris wrote: > > > > DLT_CAN_SOCKETCAN > > OK, I've assigned 227 to DLT_CAN_SOCKETCAN, and checked into the main > branch and pushed changes for that Thank you Guy! I've updated the patch in the SF tracker item to use the DLT and improved the device ind

Re: [tcpdump-workers] pcap-bpf and AIX odm related code

2009-10-12 Thread Jean-Louis Charton
Hi Guy, > > I've checked in and pushed your changes on the main Git branch. > Thank you for commiting the fix I suggested. However, I've got a little comment: in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of errbuf to the 2 bpf_odmcleanup() calls. This was int