Re: [tcpdump-workers] BUG: pcap_fopen_offline doesn't work with pcap_next [patch]

2009-08-11 Thread Guy Harris
On Aug 11, 2009, at 2:26 PM, Dustin Spicuzza wrote: In git, pcap_fopen_offline (and consequently, any of the other savefile opens) doesn't work with pcap_next because the oneshot_op is not set to anything. One can remedy this by using pcap_create_common to create the pcap_t instead of doin

[tcpdump-workers] BUG: pcap_fopen_offline doesn't work with pcap_next [patch]

2009-08-11 Thread Dustin Spicuzza
In git, pcap_fopen_offline (and consequently, any of the other savefile opens) doesn't work with pcap_next because the oneshot_op is not set to anything. One can remedy this by using pcap_create_common to create the pcap_t instead of doing it manually. Of course, the 'source' isn't set properly...

Re: [tcpdump-workers] pcap_activate can cause pcap_geterr to return a blank string

2009-08-11 Thread Guy Harris
On Aug 7, 2009, at 5:02 PM, Dustin Spicuzza wrote: However, thats another decision that has to be made by the user, so it seems like it would be nice and simple if pcap_geterr just worked no matter what kind of error was returned. Add two lines to pcap_activate to make pcap_geterr work as expec